Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2064863imu; Thu, 10 Jan 2019 07:44:33 -0800 (PST) X-Google-Smtp-Source: ALg8bN6KPab/A5LBLMCs5CBrgW2viwfr7NgGbofm8t9eTLTypgBUw72SmvVIkr0YESnGEwOkkTj5 X-Received: by 2002:a62:61c3:: with SMTP id v186mr10771441pfb.55.1547135073363; Thu, 10 Jan 2019 07:44:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547135073; cv=none; d=google.com; s=arc-20160816; b=KgE94qT0Pt2r4dkeL2wz4JfF3xiVmAj0GZdKqvemwHYWZbFbg+pmw34CAg1sw0h7o7 dEGshod2GpPbN6NE2IaDhiY1FG4qTc2h0kZsrQS45Hc45sBz60gjqCv/4h7v+JKm4B5S jpyHSubIQmoEpQjuxF31bqMkN/S98fktwJ5lRf3qEbIjNU0R2Lr9EMxgecLiIxxJ1hfB xZdNvj8czbkj5fWsiFwXWaDkF7ea6k2KUSSlqaIi2FOpl37mlRUN8hkD8aKPs/XFMjAq JVq7PTB2Hgc/eCikIUQSyBv10FjrS8zYm9IrJoiJV8RmG1aeSHqhdyRYTwHW9JTvyj7Z xxiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=FIo17yS5foLiDNl25sS9lgnD+T4jl/8vOevtYNc+rHg=; b=VF/ngehDZI3NGGxTqB4GA2kXEwBNfi+rkL4nbUOfQkuykpcC4vkQ0ceYL1FL/FMdHX lg7m8ZGs+uC7T9nOgfAB4X5cIfkCx5l5+99sKCeMkoHwYW4/bBWQYDezvC9p11YpSda8 rjb2plzXg0A2Tx7NbBqyowooiWSi2TUZmV3L1D54k1BHcF2uIP+QR3NvuynqrbRoMWdN LpeTQo9IRXP9u4UTefC7tRe0T96zP7IdxbVSoA3YqqZOi4ibJAjrj1YyUntVhFgSERwl 9GDktBHAlDFgrnwgVijjO5QfWswbIxfGHqQCq/QCYKwjSg08DMQ2Ln9UNaK4liT3VljV iEeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e93si4348833plk.56.2019.01.10.07.44.18; Thu, 10 Jan 2019 07:44:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729537AbfAJPm7 (ORCPT + 99 others); Thu, 10 Jan 2019 10:42:59 -0500 Received: from mail-oi1-f169.google.com ([209.85.167.169]:32995 "EHLO mail-oi1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727819AbfAJPm7 (ORCPT ); Thu, 10 Jan 2019 10:42:59 -0500 Received: by mail-oi1-f169.google.com with SMTP id c206so9645153oib.0; Thu, 10 Jan 2019 07:42:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FIo17yS5foLiDNl25sS9lgnD+T4jl/8vOevtYNc+rHg=; b=SJn9gLTR/G2deuQU4MmtQyxsJSrjFlMdfLmgC7+DzuXAlaC+dM2+Om8B2YrKgIMiCo ey/8NvULG+miD/z5IjfHtyq4guQWAmfOJ5mHS7pNEo12JgIxeL4CAOuq+g1STYrhC0Ef jDEIfpd/unP3TfyiHCMhFNzqyWeimdZC7bJ+prv66gHdWPSNHMHfRU2aqRg4TCfN9WND lF8DNy2XF2fcUj9pmle13rnjDWN2/mYt4UQcgzEZVu1BpdOh0jM2egl4I8Pp1gLf4Qz1 hMyvsrImNEYFZP+BkiCTWJSJQcRxTBn3njBL4oVS5J9pzwSSUIjj0g1e1dPW7z7jM2Z0 UZRA== X-Gm-Message-State: AJcUukfEIiPCUryVAFU1P13CG9Hc9w2/S2ZoXhcUSbPGcwrRjlHURtZN 9tVHlUOTcC7pF09ad3RozRDwEN1Um7WJRolB2rI= X-Received: by 2002:aca:b642:: with SMTP id g63mr6418177oif.195.1547134977996; Thu, 10 Jan 2019 07:42:57 -0800 (PST) MIME-Version: 1.0 References: <20190109174341.19818-1-keith.busch@intel.com> <20190109174341.19818-4-keith.busch@intel.com> In-Reply-To: <20190109174341.19818-4-keith.busch@intel.com> From: "Rafael J. Wysocki" Date: Thu, 10 Jan 2019 16:42:46 +0100 Message-ID: Subject: Re: [PATCHv3 03/13] acpi/hmat: Parse and report heterogeneous memory To: Keith Busch Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Memory Management List , Greg Kroah-Hartman , Rafael Wysocki , Dave Hansen , Dan Williams Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 9, 2019 at 6:47 PM Keith Busch wrote: > > Systems may provide different memory types and export this information > in the ACPI Heterogeneous Memory Attribute Table (HMAT). Parse these > tables provided by the platform and report the memory access and caching > attributes. > > Signed-off-by: Keith Busch While this is generally fine by me, it's another piece of code going under drivers/acpi/ just because it happens to use ACPI to extract some information from the platform firmware. Isn't there any better place for it? > --- > drivers/acpi/Kconfig | 8 +++ > drivers/acpi/Makefile | 1 + > drivers/acpi/hmat.c | 180 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 189 insertions(+) > create mode 100644 drivers/acpi/hmat.c > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 7b65a807b3dd..b102d9f544ee 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -326,6 +326,14 @@ config ACPI_NUMA > depends on (X86 || IA64 || ARM64) > default y if IA64_GENERIC || IA64_SGI_SN2 || ARM64 > > +config ACPI_HMAT > + bool "ACPI Heterogeneous Memory Attribute Table Support" > + depends on ACPI_NUMA > + help > + Parses representation of the ACPI Heterogeneous Memory Attributes > + Table (HMAT) and set the memory node relationships and access > + attributes. > + > config ACPI_CUSTOM_DSDT_FILE > string "Custom DSDT Table file to include" > default "" > diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile > index 7c6afc111d76..2a435dcfaa9c 100644 > --- a/drivers/acpi/Makefile > +++ b/drivers/acpi/Makefile > @@ -55,6 +55,7 @@ acpi-$(CONFIG_X86) += x86/apple.o > acpi-$(CONFIG_X86) += x86/utils.o > acpi-$(CONFIG_DEBUG_FS) += debugfs.o > acpi-$(CONFIG_ACPI_NUMA) += numa.o > +acpi-$(CONFIG_ACPI_HMAT) += hmat.o > acpi-$(CONFIG_ACPI_PROCFS_POWER) += cm_sbs.o > acpi-y += acpi_lpat.o > acpi-$(CONFIG_ACPI_LPIT) += acpi_lpit.o > diff --git a/drivers/acpi/hmat.c b/drivers/acpi/hmat.c > new file mode 100644 > index 000000000000..833a783868d5 > --- /dev/null > +++ b/drivers/acpi/hmat.c > @@ -0,0 +1,180 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Heterogeneous Memory Attributes Table (HMAT) representation > + * > + * Copyright (c) 2018, Intel Corporation. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static __init const char *hmat_data_type(u8 type) > +{ > + switch (type) { > + case ACPI_HMAT_ACCESS_LATENCY: > + return "Access Latency"; > + case ACPI_HMAT_READ_LATENCY: > + return "Read Latency"; > + case ACPI_HMAT_WRITE_LATENCY: > + return "Write Latency"; > + case ACPI_HMAT_ACCESS_BANDWIDTH: > + return "Access Bandwidth"; > + case ACPI_HMAT_READ_BANDWIDTH: > + return "Read Bandwidth"; > + case ACPI_HMAT_WRITE_BANDWIDTH: > + return "Write Bandwidth"; > + default: > + return "Reserved"; > + }; > +} > + > +static __init const char *hmat_data_type_suffix(u8 type) > +{ > + switch (type) { > + case ACPI_HMAT_ACCESS_LATENCY: > + case ACPI_HMAT_READ_LATENCY: > + case ACPI_HMAT_WRITE_LATENCY: > + return " nsec"; > + case ACPI_HMAT_ACCESS_BANDWIDTH: > + case ACPI_HMAT_READ_BANDWIDTH: > + case ACPI_HMAT_WRITE_BANDWIDTH: > + return " MB/s"; > + default: > + return ""; > + }; > +} > + > +static __init int hmat_parse_locality(union acpi_subtable_headers *header, > + const unsigned long end) > +{ > + struct acpi_hmat_locality *loc = (void *)header; > + unsigned int init, targ, total_size, ipds, tpds; > + u32 *inits, *targs, value; > + u16 *entries; > + u8 type; > + > + if (loc->header.length < sizeof(*loc)) { > + pr_err("HMAT: Unexpected locality header length: %d\n", > + loc->header.length); > + return -EINVAL; > + } > + > + type = loc->data_type; > + ipds = loc->number_of_initiator_Pds; > + tpds = loc->number_of_target_Pds; > + total_size = sizeof(*loc) + sizeof(*entries) * ipds * tpds + > + sizeof(*inits) * ipds + sizeof(*targs) * tpds; > + if (loc->header.length < total_size) { > + pr_err("HMAT: Unexpected locality header length:%d, minimum required:%d\n", > + loc->header.length, total_size); > + return -EINVAL; > + } > + > + pr_info("HMAT: Locality: Flags:%02x Type:%s Initiator Domains:%d Target Domains:%d Base:%lld\n", > + loc->flags, hmat_data_type(type), ipds, tpds, > + loc->entry_base_unit); > + > + inits = (u32 *)(loc + 1); > + targs = &inits[ipds]; > + entries = (u16 *)(&targs[tpds]); > + for (targ = 0; targ < tpds; targ++) { > + for (init = 0; init < ipds; init++) { > + value = entries[init * tpds + targ]; > + value = (value * loc->entry_base_unit) / 10; > + pr_info(" Initiator-Target[%d-%d]:%d%s\n", > + inits[init], targs[targ], value, > + hmat_data_type_suffix(type)); > + } > + } > + return 0; > +} > + > +static __init int hmat_parse_cache(union acpi_subtable_headers *header, > + const unsigned long end) > +{ > + struct acpi_hmat_cache *cache = (void *)header; > + u32 attrs; > + > + if (cache->header.length < sizeof(*cache)) { > + pr_err("HMAT: Unexpected cache header length: %d\n", > + cache->header.length); > + return -EINVAL; > + } > + > + attrs = cache->cache_attributes; > + pr_info("HMAT: Cache: Domain:%d Size:%llu Attrs:%08x SMBIOS Handles:%d\n", > + cache->memory_PD, cache->cache_size, attrs, > + cache->number_of_SMBIOShandles); > + > + return 0; > +} > + > +static int __init hmat_parse_address_range(union acpi_subtable_headers *header, > + const unsigned long end) > +{ > + struct acpi_hmat_address_range *spa = (void *)header; > + > + if (spa->header.length != sizeof(*spa)) { > + pr_err("HMAT: Unexpected address range header length: %d\n", > + spa->header.length); > + return -EINVAL; > + } > + pr_info("HMAT: Memory (%#llx length %#llx) Flags:%04x Processor Domain:%d Memory Domain:%d\n", > + spa->physical_address_base, spa->physical_address_length, > + spa->flags, spa->processor_PD, spa->memory_PD); > + return 0; > +} > + > +static int __init hmat_parse_subtable(union acpi_subtable_headers *header, > + const unsigned long end) > +{ > + struct acpi_hmat_structure *hdr = (void *)header; > + > + if (!hdr) > + return -EINVAL; > + > + switch (hdr->type) { > + case ACPI_HMAT_TYPE_ADDRESS_RANGE: > + return hmat_parse_address_range(header, end); > + case ACPI_HMAT_TYPE_LOCALITY: > + return hmat_parse_locality(header, end); > + case ACPI_HMAT_TYPE_CACHE: > + return hmat_parse_cache(header, end); > + default: > + return -EINVAL; > + } > +} > + > +static __init int hmat_init(void) > +{ > + struct acpi_table_header *tbl; > + enum acpi_hmat_type i; > + acpi_status status; > + > + if (srat_disabled()) > + return 0; > + > + status = acpi_get_table(ACPI_SIG_HMAT, 0, &tbl); > + if (ACPI_FAILURE(status)) > + return 0; > + > + for (i = ACPI_HMAT_TYPE_ADDRESS_RANGE; i < ACPI_HMAT_TYPE_RESERVED; i++) { > + if (acpi_table_parse_entries(ACPI_SIG_HMAT, > + sizeof(struct acpi_table_hmat), i, > + hmat_parse_subtable, 0) < 0) > + goto out_put; > + } > +out_put: > + acpi_put_table(tbl); > + return 0; > +} > +subsys_initcall(hmat_init); > -- > 2.14.4 >