Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 10 Jan 2019 10:49:09 -0500
From:   Kyle Williams <kdgwill@chromium.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org,
        Alan Stern <stern@rowland.harvard.edu>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Jon Flatley <jflat@chromium.org>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/2] USB: quirks: Check device interface LPM capability
Message-ID: <20190110154909.GB142026@google.com>
References: <20181205093902.GA18633@kroah.com>
 <20181208014724.951-1-kdgwill@google.com>
 <20181208014724.951-2-kdgwill@google.com>
 <20181212113709.GA20058@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181212113709.GA20058@kroah.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Dec 12, 2018 at 12:37:09PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 07, 2018 at 08:47:21PM -0500, Kyle Williams wrote:
> > From: Kyle Williams <kdgwill@chromium.org>
> > 
> > Description: enable the ability to disable LPM for all devices matched
> > by interface information
> 
> Why have "Description:" in here?  Of course this is the description :)
> 
> And the subject doesn't make much sense, what does this have to do with
> quirks?
> 
> Also, you need more information here in the description about why you
> are doing all of this, as it is, I have no idea why this patch is needed
> at all.
> 
> thanks,
> 
> greg k-h

It seems the underlying issue has been solved in
0472bf0 xhci: Prevent U1/U2 link pm states if exit latency is too long

However, the patch to fix the issue when matching the USB_QUIRK_NO_LPM
quirk by iterface could be useful in the future. Currently nothing will
happen that quirk is matched by interface instead of by vid/pid pair.
Is their anything that would need to be changed besides removing the
Description tag?

-Kyle