Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 10 Jan 2019 23:09:42 +0530
From:   Nishad Kamdar <nishadkamdar@gmail.com>
To:     Johan Hovold <johan@kernel.org>
Cc:     Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alex Elder <elder@kernel.org>,
        Rui Miguel Silva <rmfrfs@gmail.com>,
        greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, nishadkamdar@gmail.com
Subject: Re: [PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data()
 in place of gpio_chip_to_gb_gpio_controller()
Message-ID: <20190110173941.GB24566@nishad>
References: <cover.1545488665.git.nishadkamdar@gmail.com>
 <03b274a2b5777d67e9d9b6318b5b2f13ce5c2b66.1545488665.git.nishadkamdar@gmail.com>
 <20190109105824.GJ14782@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190109105824.GJ14782@localhost>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 09, 2019 at 11:58:24AM +0100, Johan Hovold wrote:
> On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote:
> > This patch drops gpio_chip_to_gb_gpio_controller(),
> > and uses gpiochip_get_data() to retrieve the container
> > of struct gpio_chip.
> 
> So this will break the driver, since gpiochip_add() sets the data
> pointer to NULL.
> 
> These kind of changes are getting too complicated to do without
> something to test against. We had a module simulator at one point, but
> not sure what the state of that is now.
> 
Ok, I get it.
> I appreciate the effort though, and since we already started, let's try
> to finish, but please drop this patch for now.
> 
Ok I'll do that.
> Johan

Thanks for the review.

Regards,
Nishad