Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 10 Jan 2019 22:44:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Sidong Yang <realwakka@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local
 variable
Message-ID: <20190110192942.GF1718@kadam>
References: <20190110061347.31326-1-realwakka@gmail.com>
 <20190110122358.GC1743@kadam>
 <20190110170023.4vcyws3ktsf2sz3g@raspberrypi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190110170023.4vcyws3ktsf2sz3g@raspberrypi>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 10, 2019 at 05:00:24PM +0000, Sidong Yang wrote:
> I think you just point out that my code isn't obvious because the
> function returns negative error codes. I agree with you. But what if
> change my code like if(hgsmi_query_conf() != 0). 
> 

That's even worse!  :P

You should do comparisons with zero when you are talking about zero
meaning the number zero.  In this case, hgsmi_query_conf() returns "zezro
meaning success" not "zero meaning the number zero".  How many bytes?
Zero.  That is the number zero.

!= zero is a double negative, because NOT and ZERO are negatives.  If
double negatives simplified the code we would add four of them instead
of just the one:

	if ((((hgsmi_query_conf() != 0) != 0) != 0) != 0) {

See?  Adding != 0 doesn't make it simpler...

The other place where != 0 is appropriate besides talking about the
number is when you're using a strcmp() function because it works like
this:

	if (strcmp(a, b) < 0) {  <-- means a < b
	if (strcmp(a, b) == 0) { <-- means a == b
	if (strcmp(a, b) != 0) { <-- means a != b

regards,
dan carpenter