Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2386246imu; Thu, 10 Jan 2019 13:16:26 -0800 (PST) X-Google-Smtp-Source: ALg8bN4SUfF9XZKHqOHEfj3F0ufX9h4SuPsLTsYDnLC9xb2friNF4Et8OoxeD2Gqh8dAGB2aHvtf X-Received: by 2002:a63:5b48:: with SMTP id l8mr10880010pgm.80.1547154986678; Thu, 10 Jan 2019 13:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547154986; cv=none; d=google.com; s=arc-20160816; b=PUL5rltCJ7FthZ6jOGlo0jfx9Fwr2sqWSkdNtShhD38YsqbnKqvO5o2bx9blw6P+z0 R65jC5CLTEwD91HFha9Hvxm6yJjeSzi+in1LelJNrtYrgyxXcJSDCV+JenU3iF76SfCc wUWzH7CMOcWGeroJUBxj4FcvazIiiHi/107oLk6qw9JEIMjjA6IlIY0CH3rSz6XC1DIa KpwcmfSUBGDlwrQHhztlcEx9qn3dVIwCW11roSuKPgu8caNFHIfhW/Dkpcm73agBMEWG lzowS3JNmF09k2JB1TVlJtx0A3ntZ1W4CSFM3VyQhg0YCWjolIrjkEwZzxcW2keVjbq9 7tfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=KwdK5fQx/5g6TdCkDFpjTfbU5Ko6/FvtbWSBvTt6lyw=; b=DUcAUGfB0Wq0oHBFH/uqF7i4YmifihfJtd5auI4WXBYEoFHBXzdfDTLitvyrYc1IVI FJDmpVj/s+9i80ndjDvsVuDS4aY5e7UXtbcJBlxtY3j1yxYcWWF6QtaSKRIO8tWLG+cW JKNIs3jhuobbZaei5h2HP6sWffQoZvUIyRnh/fRObavxpmc7nuAVLfvRDcP30kTANljj dmGorS6ed913s++0jkqUZprTFG2123WmlAk3iF0WPyr3KQMCS4zjegF+uLDBPqlj5VtU XpTqPLTNF0VmeXnaEIWPdLB3iXobYqGNQUrNoZWXvL/qPBVN7cjDbOD89NztiQxIvvq7 RJPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o11si3405408pll.160.2019.01.10.13.16.11; Thu, 10 Jan 2019 13:16:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729851AbfAJUKz (ORCPT + 99 others); Thu, 10 Jan 2019 15:10:55 -0500 Received: from gateway36.websitewelcome.com ([192.185.187.5]:27490 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729366AbfAJUKz (ORCPT ); Thu, 10 Jan 2019 15:10:55 -0500 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 087D5400C8BDD for ; Thu, 10 Jan 2019 13:23:05 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id hgfHgZrC02PzOhgfHgDwhv; Thu, 10 Jan 2019 14:10:55 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=41258 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1ghgfG-002dTS-M6; Thu, 10 Jan 2019 14:10:54 -0600 Subject: Re: [PATCH 13/41] scsi: csiostor: csio_wr: mark expected switch fall-through From: "Gustavo A. R. Silva" To: linux-kernel@vger.kernel.org Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org References: <5e846a635bfaf121af56e1f60a99816091e55170.1543374820.git.gustavo@embeddedor.com> Message-ID: <8f7b1fb9-260a-93aa-ec88-8d48ca9b2513@embeddedor.com> Date: Thu, 10 Jan 2019 14:10:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1ghgfG-002dTS-M6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.250.130.205]:41258 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 40 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Martin: apparently, the only maintainers for this driver are you and James. Thanks -- Gustavo On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping: > > Who can ack or review this patch, please? > > Thanks > -- > Gustavo > > On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Addresses-Coverity-ID: 1056538 ("Missing break in switch") >> Signed-off-by: Gustavo A. R. Silva >> --- >>   drivers/scsi/csiostor/csio_wr.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/scsi/csiostor/csio_wr.c b/drivers/scsi/csiostor/csio_wr.c >> index dc12933533d5..b6861ea66c9f 100644 >> --- a/drivers/scsi/csiostor/csio_wr.c >> +++ b/drivers/scsi/csiostor/csio_wr.c >> @@ -808,6 +808,7 @@ csio_wr_destroy_queues(struct csio_hw *hw, bool cmd) >>                   csio_q_eqid(hw, i) = CSIO_MAX_QID; >>               } >> +            /* fall through */ >>           case CSIO_INGRESS: >>               if (csio_q_iqid(hw, i) != CSIO_MAX_QID) { >>                   csio_wr_cleanup_iq_ftr(hw, i); >>