Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2386874imu; Thu, 10 Jan 2019 13:17:06 -0800 (PST) X-Google-Smtp-Source: ALg8bN4D+y2Ucez/E3HUSAOdMYJ5ILcV4iQeDcPAMQQ2WrMLgM57u/krKVoAvuYYahDYigsuhjdC X-Received: by 2002:a17:902:5ac2:: with SMTP id g2mr11947257plm.313.1547155026864; Thu, 10 Jan 2019 13:17:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547155026; cv=none; d=google.com; s=arc-20160816; b=skoWNbQEWl8ymlSzH/pWxPUGCiX3njLZ4iAOPBD0e5ToNqwEvCSvwFSSk8+OAJGHAH YxNmYqrNJIi2VnIaM6gly3XBB7PNm9XnnkawYRKlcx0/3hs7utQ7JeXiTvzBKSrY+mk5 D5QzkZVZ+Zs3nwJTqqDJkV1haYTrgWjJGKVnlm07CJ6O2xKq1wzdnpEw+rwEX6o+kP6n 6AwUF11mcbfWzU1ooGj4crxXUu6zRiWFlvUhHhf0dEShmINA+Ia1+6YAasHM2obnKDE3 1n95e8ZB4N7ei9p9UOk30AXBYvjfzLD5KrA6FFV7yVtgJgaMSHZTgcJDV+q2CbRU9XFQ +lsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=AHJbcyDxtRJVvCCsfT65pneTaya8jXrvibMvU45vTsM=; b=AWml4rctcoIwzx/g/jge+ICA70KP8X8fPnNbldaRp+UD+tORAyplns4tBezd3kLx66 /OXxJtE4/zVeYoq8F7VoqD13LQMPfEsoc9JGZDZPvODRibqy1U2Maneq2hddmabDy9bG gV1Op3jwDhNAmtTCm1tjC9BYqLRTl7YzYEh8kn5uvRJUIHLUMz3M+jU0hbN3b2CKTLMU V3V4dp+VnlODZK8j92ziXl/OsxF8m9HP63/oqSlLar8c+RzUcbwB6k/4PAYNrIJsS0s1 b9TIQRv9Y/fVQlNgf3osRJYVQov17J8makb0KbWB0Z74ZJN9R/tffFSL1PWfQJbfNyrW 0m3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d36si52536336pla.216.2019.01.10.13.16.52; Thu, 10 Jan 2019 13:17:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730207AbfAJUNF (ORCPT + 99 others); Thu, 10 Jan 2019 15:13:05 -0500 Received: from gateway34.websitewelcome.com ([192.185.148.194]:32812 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730063AbfAJUNF (ORCPT ); Thu, 10 Jan 2019 15:13:05 -0500 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 751608689B3 for ; Thu, 10 Jan 2019 14:13:04 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id hghMgUq6WdnCehghMgaRDa; Thu, 10 Jan 2019 14:13:04 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=41300 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1ghghK-002fBg-Ee; Thu, 10 Jan 2019 14:13:02 -0600 Subject: Re: [PATCH 08/41] scsi: be2iscsi: be_main: Mark expected switch fall-through From: "Gustavo A. R. Silva" To: Subbu Seetharaman , Ketan Mukadam , Jitendra Bhivare Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <8cecc2e7-5008-678f-e2de-7d8ab3b95195@embeddedor.com> Message-ID: Date: Thu, 10 Jan 2019 14:12:57 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <8cecc2e7-5008-678f-e2de-7d8ab3b95195@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1ghghK-002fBg-Ee X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.250.130.205]:41300 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 74 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 12/19/18 9:38 AM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping: > > Who can ack or review this patch, please? > > Thanks > -- > Gustavo > > On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Addresses-Coverity-ID: 1357387 ("Missing break in switch") >> Signed-off-by: Gustavo A. R. Silva >> --- >>   drivers/scsi/be2iscsi/be_main.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c >> index effb6fc95af4..b6449da1320c 100644 >> --- a/drivers/scsi/be2iscsi/be_main.c >> +++ b/drivers/scsi/be2iscsi/be_main.c >> @@ -1539,6 +1539,7 @@ beiscsi_hdl_get_handle(struct beiscsi_conn *beiscsi_conn, >>           break; >>       case UNSOL_DATA_DIGEST_ERROR_NOTIFY: >>           error = 1; >> +        /* fall through */ >>       case UNSOL_DATA_NOTIFY: >>           pasync_handle = pasync_ctx->async_entry[ci].data; >>           break; >>