Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2467323imu; Thu, 10 Jan 2019 14:48:58 -0800 (PST) X-Google-Smtp-Source: ALg8bN52Jte6hjLD2ngC3V/oqQjaWlHwzoT1Ee3uOefz7Aa8qwXAPYKPcfRsM6Yr/DLgJlM0y19M X-Received: by 2002:a65:40c5:: with SMTP id u5mr10761098pgp.46.1547160538157; Thu, 10 Jan 2019 14:48:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547160538; cv=none; d=google.com; s=arc-20160816; b=WnFb0bWjghjUVxnaDwwZLvKNzGmWyMyb32C3eBrm42i6LeJrnbDJy71t0oG9e249NW ci56sLOyqCQGYS3GOqdt6EHqxSQJbDjXkqXSRzJvu+aOb3vajcZl8p7Va52W1zX+4Kjk 9eSZu0/S9sZTh3caVyq1q0qwyAY7brZaZtfuppX9txHFqp+x73RU33SYnAaEp1IaVJjK Kdy+VkpFC8lE07AnH4vxiZqyn3XjWOvDNv5peWDkHQiUTDECY7kRz3lJfNGIacJIH2wj iyGbecnLev06AN7wdLQ0fra5rS0I0/qc1G+j87prWOoJFTNrfsA6VRxUvpueauU/441K D4GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=t/FLnWUPyPjZdZ6XwfU1KWVBDwJ0iDhFLZWn306piqM=; b=QWffQ3MCIL/eDxFFa5+7S8pzM4/5RmZyW4jbqOTxMwDG0O4FGL1arDwdfSAZxh5Q0G UmjOZBg7u1nvHP9Xpr3/BnpM5MnCFospO+ZFWMI2s8AUSDv07jUpzl4ZvWG0vkXy3bRP wG8sYdhVil8A7PmPl2lsehmHu9Ol1Rll9cDLozOu92f0vfNppf83/6ocH2/VdgvBuZMl nBRwgSNpImRC1QYVxcK2GA3khyplSzOe1EuEnKnRiIddt0H10pC9lSw2OZIwTohPIJGy iOBcPlw8oV1hyNIzYiVcBDfa+wX8+F4uck+g/Zibr2CIT6eauVNXzLnWuuUSk2SPYvYI sbNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a35si15285606pla.226.2019.01.10.14.48.43; Thu, 10 Jan 2019 14:48:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729197AbfAJUDg (ORCPT + 99 others); Thu, 10 Jan 2019 15:03:36 -0500 Received: from gateway24.websitewelcome.com ([192.185.51.36]:25770 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728343AbfAJUDf (ORCPT ); Thu, 10 Jan 2019 15:03:35 -0500 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 794B9A82E for ; Thu, 10 Jan 2019 14:03:34 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id hgYAgu3QL4FKphgYAgLB1c; Thu, 10 Jan 2019 14:03:34 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=41172 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1ghgY9-002X2w-A3; Thu, 10 Jan 2019 14:03:33 -0600 Subject: Re: [PATCH 23/41] scsi: lpfc: lpfc_els: Mark expected switch fall-throughs To: James Smart , Dick Kennedy Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: From: "Gustavo A. R. Silva" Message-ID: <39c21b2b-7f38-1da3-1f67-93e2ae5d9339@embeddedor.com> Date: Thu, 10 Jan 2019 14:03:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1ghgY9-002X2w-A3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.250.130.205]:41172 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 24 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Friendly ping (second one): Who can ack/review/take this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114978 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/scsi/lpfc/lpfc_els.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c > index 5c34bfa624ef..1f20c35e0f84 100644 > --- a/drivers/scsi/lpfc/lpfc_els.c > +++ b/drivers/scsi/lpfc/lpfc_els.c > @@ -8649,6 +8649,7 @@ lpfc_cmpl_reg_new_vport(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) > lpfc_nlp_put(ndlp); > return; > } > + /* fall through */ > > default: > /* Try to recover from this error */ >