Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp29559imu; Thu, 10 Jan 2019 16:23:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN7e2q38XEynHYpo2FLqtvnN71gtBUjmRUunuPNanqHD/J0YcmjSV+YxM9ANNyuZ9g8hOUYH X-Received: by 2002:a63:d104:: with SMTP id k4mr1242592pgg.227.1547166185234; Thu, 10 Jan 2019 16:23:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547166185; cv=none; d=google.com; s=arc-20160816; b=ebBgQVWztvA6/FWrKR+Rs4AGobteiPPPWcFvti6kWrDVs+ACIi3M03eCGiOsxS54Gd wfEyePx/tdCOICbMMV/cIholsqKyTl0BA35jyWlJeaoiwGTZ9ZL24kioGUgCZ/+vdRM5 B4aDS3Jn0T3IQj66CkPF1iPWKQlGTYzyxaPUkRVhYyH6z5pbUPqQm0tHX9Yk2YuCGc/K 1nKWKlpxtJyrzls/O9ys5DDD56SH5oJFN1ffznGq5vH5BwvZEZAr/acSuFQPEx40/mus 7OxRzJFg3SBP8hPtRmIsA1IYG9LneAINtFg1Jan80giYETebnj3OwCmdxoWncx0lnG53 j4VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :content-language:content-transfer-encoding:in-reply-to:date :message-id:from:cc:to:subject; bh=2vRuS9+oP46YadcnHURDFvVnx6eu7eom9B3ILBUpFh0=; b=B1xLLeim4gVaUxqopJIfzrf/Q3p5kYXLfWXW2sncP1GbqB3VPSuMcfWKsORmDvYmYj 8+rRqJ81/qtF1ynNIMt+cuwiLiUVbNtn4NDu8gITX0wax9i1TQ4HdpCjI40YFMHPqIHP K55k91rDaKA6sE5xGQYCVIigc2pXIaxOS/Im4WoW0AmA7IRRy/zLPPQBxhXzLkk1ZEVt pIOQ/ZQfs/Ug7UGx5z+/oezxJOS4oulOEI8TzIrqqibgdhpTOI6zDHqopxW5hJgh179y 5O3FNzgJrdzxQMGOEv6HBwMdC7P2cH1Q+Nho+qiSSFzIQe2ZylzoX7wq3pQFZ+ACYsPt Cnvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=attotech.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3si24553172pgj.300.2019.01.10.16.22.49; Thu, 10 Jan 2019 16:23:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=attotech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729255AbfAJW0j convert rfc822-to-8bit (ORCPT + 99 others); Thu, 10 Jan 2019 17:26:39 -0500 Received: from sw.attotech.com ([208.69.85.34]:11692 "EHLO NOTESERV1.attotech.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728042AbfAJW0j (ORCPT ); Thu, 10 Jan 2019 17:26:39 -0500 X-Greylist: delayed 919 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Jan 2019 17:26:39 EST Received: from [10.30.1.34] ([10.30.1.34]) by NOTESERV1.attotech.com (IBM Domino Release 9.0.1FP10 HF314) with ESMTP id 2019011017111804-18675 ; Thu, 10 Jan 2019 17:11:18 -0500 Subject: Re: [PATCH 14/41] scsi: esas2r: esas2r_init: mark expected switch fall-throughs To: "Gustavo A. R. Silva" , Bradley Grove Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: "Grove, Bradley" Message-ID: <6bcead36-dc21-0ba9-48e4-35a9fa19df09@attotech.com> Date: Thu, 10 Jan 2019 17:11:18 -0500 In-Reply-To: <3751e0eb-e57b-9aed-c23a-f593b780605b@embeddedor.com> Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US References: <3751e0eb-e57b-9aed-c23a-f593b780605b@embeddedor.com> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on NOTESERV1/SERV/ATTO(Release 9.0.1FP10 HF314|September 20, 2018) at 01/10/2019 05:11:18 PM X-TNEFEvaluated: 1 X-Disclaimed: 7795 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Bradley Grove On 1/10/2019 3:08 PM, Gustavo A. R. Silva wrote: > Hi, > > Friendly ping (second one): > > Who can ack/review/take this patch, please? > > Thanks > -- > Gustavo > > On 12/19/18 9:39 AM, Gustavo A. R. Silva wrote: >> Hi, >> >> Friendly ping: >> >> Who can ack or review this patch, please? >> >> Thanks >> -- >> Gustavo >> >> On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >>> >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>>   drivers/scsi/esas2r/esas2r_init.c | 3 ++- >>>   1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/scsi/esas2r/esas2r_init.c >>> b/drivers/scsi/esas2r/esas2r_init.c >>> index 46b2c83ba21f..950cd92df2ff 100644 >>> --- a/drivers/scsi/esas2r/esas2r_init.c >>> +++ b/drivers/scsi/esas2r/esas2r_init.c >>> @@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct >>> esas2r_adapter *a, >>>               a->init_msg = ESAS2R_INIT_MSG_GET_INIT; >>>               break; >>>           } >>> +        /* fall through */ >>>       case ESAS2R_INIT_MSG_GET_INIT: >>>           if (msg == ESAS2R_INIT_MSG_GET_INIT) { >>> @@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct >>> esas2r_adapter *a, >>>                   esas2r_hdebug("FAILED"); >>>               } >>>           } >>> -    /* fall through */ >>> +        /* fall through */ >>>       default: >>>           rq->req_stat = RS_SUCCESS; >>> This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.