Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp29990imu; Thu, 10 Jan 2019 17:17:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN6klvkFC925RFLoI9UMR+Fn7pwAELJjm4G1codrjGo9rJWxBrJo7hdqsr2d5IWVlKy5d5KF X-Received: by 2002:a17:902:f81:: with SMTP id 1mr12188585plz.174.1547169439089; Thu, 10 Jan 2019 17:17:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547169439; cv=none; d=google.com; s=arc-20160816; b=SPQb9ygnUDYWnmRfqawOSj6gciB0LJ5GafrVPsNkn9PqWJV3cuzBz9eFKeTzedpX9V EOF++Cpr3DwsykbXWD/HuAxVMXNMIXm+iMLkCXKYt+V/DDMzBDiDV9a7pDqiTaZAgzh2 G0IC/TmIZCmQRVTFsn1Q33YXivJc/mGrEmJ15JYfq5WGJZROKeGcCDbXwW90T2FGcWxo sRy0/FMIGCOLXf4X6hqBweHeyJQMsluXkOWN8/doklm390iWsoTmeO+Og9tufSpAlPwu 666hpVt+bKpGowLVzF0C0rdSICNPcjHE5uppnNQ2X1Ln/TE68twGc1yHj9Jw/O4EOrPX dqpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=O5anRohzFKdZMNpwRT5ORcnNjwTasrFgL91cKFFTUBs=; b=KkkWf5UUyd4BMOHkz6qR07PWesVeKOl167qI685iEskMm+A9kWCVmXpsErKfsJQ6NJ 0zqAcRsdP9p5rJl4ZBy6fMxyPPFFQabrMicbH6Z6s5UJ8uWIke0YacQjCcpiun2VFbl4 5B9BmVAKt9/6cy1zVfyl64eivyqc2QALtoc2ye5/QVc2fvsL7CtCNBzC9aMCnWMmBU0S 8CrcfjZPjOEN7i744+/ULpbsHL/uhFstKGwKrSbq+1clWZ/yiSDo/qGU3vtgQUQhsHrV XrrSwHr6FGsilKWtj6TlIamhHkTV9HsqblXSitKgWpRgdgJjUWRNMuUeD0gv6b7T90+B HcMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ozlabs-ru.20150623.gappssmtp.com header.s=20150623 header.b=njs7DNdH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si7729992pgk.291.2019.01.10.17.17.01; Thu, 10 Jan 2019 17:17:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ozlabs-ru.20150623.gappssmtp.com header.s=20150623 header.b=njs7DNdH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729117AbfAKBNs (ORCPT + 99 others); Thu, 10 Jan 2019 20:13:48 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:36272 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728681AbfAKBNs (ORCPT ); Thu, 10 Jan 2019 20:13:48 -0500 Received: by mail-pf1-f195.google.com with SMTP id b85so6131492pfc.3 for ; Thu, 10 Jan 2019 17:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O5anRohzFKdZMNpwRT5ORcnNjwTasrFgL91cKFFTUBs=; b=njs7DNdHsOYgtvqwErqjVyagjhlaV/tPkenBgoeyJugY/chsAFjiU/xvCvSCryQ4n3 EO3ywnkOQnflyGSBATFU22B3CN4Yu1DCb4EFsn5zuqO2Lks1+ZzFi+HoEYtgvizgdJj1 2ROMRoTSi/pTQO1MoUyqbX6KauERJ94gI9urnqg5qpt+NCezROPHTXH4Zr1FQ2j+5RsS xsmSTO3q5yrbgj7jbjL+VN6STsLUxb3NOCa+j12/H6Am6s2a7UefoK7jbjQW+J2J3MyE a0HGWiDZiedC/GMQGWLVT+Qmj5nFwEPBZZFIZmr+Lr3yqAg/zMDKn+Wo6I4NXLSHFcwq n1eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=O5anRohzFKdZMNpwRT5ORcnNjwTasrFgL91cKFFTUBs=; b=eGT2t9B+Yfv5iVUqTU+Fd9pBCmajON3NTMuMZhfWZ5yQ7+GcTEV9WxfzbtkPwWQVUh x4ZVYA3EVSMe2I5svBOAetjCJpurTwHmn73sZDGFkP7mwnWQILq8uSxbEriGHQ1ad5ZR o70dBVjdiTb6Pv0sbGQvK86zs9Z/mQ2oLQrBNal4YEQhfwTlX1/fITOBbLtWcFBC816N DetvLzQcWXXRIvBogwjXPs8ZVDDp4OhlCgwnvQNb1HNcFvRNfRTCFRIt/Xug0CD4jjpX 3Otg1L0ZfezEJ/z9r4hZhWJrpI7ev6Wor9+l/qbHBl9oy31aGAI/WOk8VT3OZxZtJTVw VW3w== X-Gm-Message-State: AJcUukfbbtTRyNv/qmcAHESpqktcTL+0EKtkfiM/MIBRJq/TDSPMMKtS QsN5lfqupj/YVZQ0D2Jig6mJ+2JIT9Y= X-Received: by 2002:a63:61c8:: with SMTP id v191mr11598102pgb.242.1547169226443; Thu, 10 Jan 2019 17:13:46 -0800 (PST) Received: from [10.61.2.175] ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id c23sm100871751pfi.83.2019.01.10.17.13.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jan 2019 17:13:45 -0800 (PST) Subject: Re: [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error To: Steven Rostedt , Masahiro Yamada Cc: Alex Williamson , kvm@vger.kernel.org, Laura Abbott , Michael Ellerman , Cornelia Huck , linux-kernel@vger.kernel.org References: <1546916883-25911-1-git-send-email-yamada.masahiro@socionext.com> <20190110144701.ah3hmedqmyqf5uzt@home.goodmis.org> From: Alexey Kardashevskiy Openpgp: preference=signencrypt Autocrypt: addr=aik@ozlabs.ru; keydata= mQINBE+rT0sBEADFEI2UtPRsLLvnRf+tI9nA8T91+jDK3NLkqV+2DKHkTGPP5qzDZpRSH6mD EePO1JqpVuIow/wGud9xaPA5uvuVgRS1q7RU8otD+7VLDFzPRiRE4Jfr2CW89Ox6BF+q5ZPV /pS4v4G9eOrw1v09lEKHB9WtiBVhhxKK1LnUjPEH3ifkOkgW7jFfoYgTdtB3XaXVgYnNPDFo PTBYsJy+wr89XfyHr2Ev7BB3Xaf7qICXdBF8MEVY8t/UFsesg4wFWOuzCfqxFmKEaPDZlTuR tfLAeVpslNfWCi5ybPlowLx6KJqOsI9R2a9o4qRXWGP7IwiMRAC3iiPyk9cknt8ee6EUIxI6 t847eFaVKI/6WcxhszI0R6Cj+N4y+1rHfkGWYWupCiHwj9DjILW9iEAncVgQmkNPpUsZECLT WQzMuVSxjuXW4nJ6f4OFHqL2dU//qR+BM/eJ0TT3OnfLcPqfucGxubhT7n/CXUxEy+mvWwnm s9p4uqVpTfEuzQ0/bE6t7dZdPBua7eYox1AQnk8JQDwC3Rn9kZq2O7u5KuJP5MfludMmQevm pHYEMF4vZuIpWcOrrSctJfIIEyhDoDmR34bCXAZfNJ4p4H6TPqPh671uMQV82CfTxTrMhGFq 8WYU2AH86FrVQfWoH09z1WqhlOm/KZhAV5FndwVjQJs1MRXD8QARAQABtCRBbGV4ZXkgS2Fy ZGFzaGV2c2tpeSA8YWlrQG96bGFicy5ydT6JAjgEEwECACIFAk+rT0sCGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAAAoJEIYTPdgrwSC5fAIP/0wf/oSYaCq9PhO0UP9zLSEz66SSZUf7 AM9O1rau1lJpT8RoNa0hXFXIVbqPPKPZgorQV8SVmYRLr0oSmPnTiZC82x2dJGOR8x4E01gK TanY53J/Z6+CpYykqcIpOlGsytUTBA+AFOpdaFxnJ9a8p2wA586fhCZHVpV7W6EtUPH1SFTQ q5xvBmr3KkWGjz1FSLH4FeB70zP6uyuf/B2KPmdlPkyuoafl2UrU8LBADi/efc53PZUAREih sm3ch4AxaL4QIWOmlE93S+9nHZSRo9jgGXB1LzAiMRII3/2Leg7O4hBHZ9Nki8/fbDo5///+ kD4L7UNbSUM/ACWHhd4m1zkzTbyRzvL8NAVQ3rckLOmju7Eu9whiPueGMi5sihy9VQKHmEOx OMEhxLRQbzj4ypRLS9a+oxk1BMMu9cd/TccNy0uwx2UUjDQw/cXw2rRWTRCxoKmUsQ+eNWEd iYLW6TCfl9CfHlT6A7Zmeqx2DCeFafqEd69DqR9A8W5rx6LQcl0iOlkNqJxxbbW3ddDsLU/Y r4cY20++WwOhSNghhtrroP+gouTOIrNE/tvG16jHs8nrYBZuc02nfX1/gd8eguNfVX/ZTHiR gHBWe40xBKwBEK2UeqSpeVTohYWGBkcd64naGtK9qHdo1zY1P55lHEc5Uhlk743PgAnOi27Q ns5zuQINBE+rT0sBEACnV6GBSm+25ACT+XAE0t6HHAwDy+UKfPNaQBNTTt31GIk5aXb2Kl/p AgwZhQFEjZwDbl9D/f2GtmUHWKcCmWsYd5M/6Ljnbp0Ti5/xi6FyfqnO+G/wD2VhGcKBId1X Em/B5y1kZVbzcGVjgD3HiRTqE63UPld45bgK2XVbi2+x8lFvzuFq56E3ZsJZ+WrXpArQXib2 hzNFwQleq/KLBDOqTT7H+NpjPFR09Qzfa7wIU6pMNF2uFg5ihb+KatxgRDHg70+BzQfa6PPA o1xioKXW1eHeRGMmULM0Eweuvpc7/STD3K7EJ5bBq8svoXKuRxoWRkAp9Ll65KTUXgfS+c0x gkzJAn8aTG0z/oEJCKPJ08CtYQ5j7AgWJBIqG+PpYrEkhjzSn+DZ5Yl8r+JnZ2cJlYsUHAB9 jwBnWmLCR3gfop65q84zLXRQKWkASRhBp4JK3IS2Zz7Nd/Sqsowwh8x+3/IUxVEIMaVoUaxk Wt8kx40h3VrnLTFRQwQChm/TBtXqVFIuv7/Mhvvcq11xnzKjm2FCnTvCh6T2wJw3de6kYjCO 7wsaQ2y3i1Gkad45S0hzag/AuhQJbieowKecuI7WSeV8AOFVHmgfhKti8t4Ff758Z0tw5Fpc BFDngh6Lty9yR/fKrbkkp6ux1gJ2QncwK1v5kFks82Cgj+DSXK6GUQARAQABiQIfBBgBAgAJ BQJPq09LAhsMAAoJEIYTPdgrwSC5NYEP/2DmcEa7K9A+BT2+G5GXaaiFa098DeDrnjmRvumJ BhA1UdZRdfqICBADmKHlJjj2xYo387sZpS6ABbhrFxM6s37g/pGPvFUFn49C47SqkoGcbeDz Ha7JHyYUC+Tz1dpB8EQDh5xHMXj7t59mRDgsZ2uVBKtXj2ZkbizSHlyoeCfs1gZKQgQE8Ffc F8eWKoqAQtn3j4nE3RXbxzTJJfExjFB53vy2wV48fUBdyoXKwE85fiPglQ8bU++0XdOr9oyy j1llZlB9t3tKVv401JAdX8EN0++ETiOovQdzE1m+6ioDCtKEx84ObZJM0yGSEGEanrWjiwsa nzeK0pJQM9EwoEYi8TBGhHC9ksaAAQipSH7F2OHSYIlYtd91QoiemgclZcSgrxKSJhyFhmLr QEiEILTKn/pqJfhHU/7R7UtlDAmFMUp7ByywB4JLcyD10lTmrEJ0iyRRTVfDrfVP82aMBXgF tKQaCxcmLCaEtrSrYGzd1sSPwJne9ssfq0SE/LM1J7VdCjm6OWV33SwKrfd6rOtvOzgadrG6 3bgUVBw+bsXhWDd8tvuCXmdY4bnUblxF2B6GOwSY43v6suugBttIyW5Bl2tXSTwP+zQisOJo +dpVG2pRr39h+buHB3NY83NEPXm1kUOhduJUA17XUY6QQCAaN4sdwPqHq938S3EmtVhsuQIN BFq54uIBEACtPWrRdrvqfwQF+KMieDAMGdWKGSYSfoEGGJ+iNR8v255IyCMkty+yaHafvzpl PFtBQ/D7Fjv+PoHdFq1BnNTk8u2ngfbre9wd9MvTDsyP/TmpF0wyyTXhhtYvE267Av4X/BQT lT9IXKyAf1fP4BGYdTNgQZmAjrRsVUW0j6gFDrN0rq2J9emkGIPvt9rQt6xGzrd6aXonbg5V j6Uac1F42ESOZkIh5cN6cgnGdqAQb8CgLK92Yc8eiCVCH3cGowtzQ2m6U32qf30cBWmzfSH0 HeYmTP9+5L8qSTA9s3z0228vlaY0cFGcXjdodBeVbhqQYseMF9FXiEyRs28uHAJEyvVZwI49 CnAgVV/n1eZa5qOBpBL+ZSURm8Ii0vgfvGSijPGbvc32UAeAmBWISm7QOmc6sWa1tobCiVmY SNzj5MCNk8z4cddoKIc7Wt197+X/X5JPUF5nQRvg3SEHvfjkS4uEst9GwQBpsbQYH9MYWq2P PdxZ+xQE6v7cNB/pGGyXqKjYCm6v70JOzJFmheuUq0Ljnfhfs15DmZaLCGSMC0Amr+rtefpA y9FO5KaARgdhVjP2svc1F9KmTUGinSfuFm3quadGcQbJw+lJNYIfM7PMS9fftq6vCUBoGu3L j4xlgA/uQl/LPneu9mcvit8JqcWGS3fO+YeagUOon1TRqQARAQABiQRsBBgBCAAgFiEEZSrP ibrORRTHQ99dhhM92CvBILkFAlq54uICGwICQAkQhhM92CvBILnBdCAEGQEIAB0WIQQIhvWx rCU+BGX+nH3N7sq0YorTbQUCWrni4gAKCRDN7sq0YorTbVVSD/9V1xkVFyUCZfWlRuryBRZm S4GVaNtiV2nfUfcThQBfF0sSW/aFkLP6y+35wlOGJE65Riw1C2Ca9WQYk0xKvcZrmuYkK3DZ 0M9/Ikkj5/2v0vxz5Z5w/9+IaCrnk7pTnHZuZqOh23NeVZGBls/IDIvvLEjpD5UYicH0wxv+ X6cl1RoP2Kiyvenf0cS73O22qSEw0Qb9SId8wh0+ClWet2E7hkjWFkQfgJ3hujR/JtwDT/8h 3oCZFR0KuMPHRDsCepaqb/k7VSGTLBjVDOmr6/C9FHSjq0WrVB9LGOkdnr/xcISDZcMIpbRm EkIQ91LkT/HYIImL33ynPB0SmA+1TyMgOMZ4bakFCEn1vxB8Ir8qx5O0lHMOiWMJAp/PAZB2 r4XSSHNlXUaWUg1w3SG2CQKMFX7vzA31ZeEiWO8tj/c2ZjQmYjTLlfDK04WpOy1vTeP45LG2 wwtMA1pKvQ9UdbYbovz92oyZXHq81+k5Fj/YA1y2PI4MdHO4QobzgREoPGDkn6QlbJUBf4To pEbIGgW5LRPLuFlOPWHmIS/sdXDrllPc29aX2P7zdD/ivHABslHmt7vN3QY+hG0xgsCO1JG5 pLORF2N5XpM95zxkZqvYfC5tS/qhKyMcn1kC0fcRySVVeR3tUkU8/caCqxOqeMe2B6yTiU1P aNDq25qYFLeYxg67D/4w/P6BvNxNxk8hx6oQ10TOlnmeWp1q0cuutccblU3ryRFLDJSngTEu ZgnOt5dUFuOZxmMkqXGPHP1iOb+YDznHmC0FYZFG2KAc9pO0WuO7uT70lL6larTQrEneTDxQ CMQLP3qAJ/2aBH6SzHIQ7sfbsxy/63jAiHiT3cOaxAKsWkoV2HQpnmPOJ9u02TPjYmdpeIfa X2tXyeBixa3i/6dWJ4nIp3vGQicQkut1YBwR7dJq67/FCV3Mlj94jI0myHT5PIrCS2S8LtWX ikTJSxWUKmh7OP5mrqhwNe0ezgGiWxxvyNwThOHc5JvpzJLd32VDFilbxgu4Hhnf6LcgZJ2c Zd44XWqUu7FzVOYaSgIvTP0hNrBYm/E6M7yrLbs3JY74fGzPWGRbBUHTZXQEqQnZglXaVB5V ZhSFtHopZnBSCUSNDbB+QGy4B/E++Bb02IBTGl/JxmOwG+kZUnymsPvTtnNIeTLHxN/H/ae0 c7E5M+/NpslPCmYnDjs5qg0/3ihh6XuOGggZQOqrYPC3PnsNs3NxirwOkVPQgO6mXxpuifvJ DG9EMkK8IBXnLulqVk54kf7fE0jT/d8RTtJIA92GzsgdK2rpT1MBKKVffjRFGwN7nQVOzi4T XrB5p+6ML7Bd84xOEGsj/vdaXmz1esuH7BOZAGEZfLRCHJ0GVCSssg== Message-ID: <9b1c9668-98cb-2a30-2fb0-b797b47aa9b6@ozlabs.ru> Date: Fri, 11 Jan 2019 12:13:35 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190110144701.ah3hmedqmyqf5uzt@home.goodmis.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/2019 01:47, Steven Rostedt wrote: > On Tue, Jan 08, 2019 at 12:08:03PM +0900, Masahiro Yamada wrote: >> --- >> >> drivers/vfio/pci/trace.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/vfio/pci/trace.h b/drivers/vfio/pci/trace.h >> index 228ccdb..4d13e51 100644 >> --- a/drivers/vfio/pci/trace.h >> +++ b/drivers/vfio/pci/trace.h >> @@ -94,7 +94,7 @@ TRACE_EVENT(vfio_pci_npu2_mmap, >> #endif /* _TRACE_VFIO_PCI_H */ >> >> #undef TRACE_INCLUDE_PATH >> -#define TRACE_INCLUDE_PATH . >> +#define TRACE_INCLUDE_PATH ../../drivers/vfio/pci > > Note, the reason why I did not show this method in the samples/trace_events/ > is that there's one "gotcha" that you need to be careful about. It may not be > an issue here, but please be aware of it. > > The words in TRACE_INCLUDE_PATH can be updated by C preprocessor defines. For > example, if for some reason you had: > > #define pci special_pci > > The above would turn into: > > ../../drivers/vfio/special_pci > > and it wont build, and you will be left scratching your head wondering why. Lovely :) imho it is +1 for CFLAGS_vfio_pci_nvlink2.o += -I$(src) and a comment. -- Alexey