Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266186AbUA1VVT (ORCPT ); Wed, 28 Jan 2004 16:21:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266187AbUA1VVT (ORCPT ); Wed, 28 Jan 2004 16:21:19 -0500 Received: from phoenix.infradead.org ([213.86.99.234]:2319 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S266186AbUA1VVS (ORCPT ); Wed, 28 Jan 2004 16:21:18 -0500 Date: Wed, 28 Jan 2004 21:21:15 +0000 From: Christoph Hellwig To: Marcelo Tosatti Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PC300 update Message-ID: <20040128212115.A2027@infradead.org> Mail-Followup-To: Christoph Hellwig , Marcelo Tosatti , torvalds@osdl.org, linux-kernel@vger.kernel.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from marcelo.tosatti@cyclades.com on Wed, Jan 28, 2004 at 05:42:11PM -0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 435 Lines: 13 > - Mark pci_device_id list with __devinitdata This is bogus and can crash the kernel if you're unlucky. > - Add #ifdef DEBUG around debug printk() What about dprintk or friends instead? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/