Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   11 Jan 2019 09:52:12 +0900
Message-ID: <871s5kqb43.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        <linux-tegra@vger.kernel.org>, Matthias Reichl <hias@horus.com>,
        <alsa-devel@alsa-project.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Takashi Iwai <tiwai@suse.com>, <linux-kernel@vger.kernel.org>,
        Marcel Ziswiler <marcel@ziswiler.com>
Subject: Re: [alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement
In-Reply-To: <a2068291-e554-cc4f-9af9-0022f3c4de34@nvidia.com>
References: <20181218174040.k7u26vnnoplllnwb@camel2.lan>
        <952471da-b355-6471-6c19-5120d6704f81@nvidia.com>
        <87lg3vuc7p.wl-kuninori.morimoto.gx@renesas.com>
        <b5164c93-8be8-1c3d-9415-c895da6ad622@nvidia.com>
        <d1e41ed2-da7c-b46c-bc6d-64cf3e536771@nvidia.com>
        <865d2a3e-bf6b-1f30-1179-7e922c0d0641@nvidia.com>
        <87k1je38w7.wl-kuninori.morimoto.gx@renesas.com>
        <0660a471-3698-2059-4494-ad146518a4ed@nvidia.com>
        <20190109125340.GD10405@sirena.org.uk>
        <52f5f2cf-9260-f9c5-f73d-3c3d5debc86b@nvidia.com>
        <20190109141439.GE10405@sirena.org.uk>
        <875zuxb9uy.wl-kuninori.morimoto.gx@renesas.com>
        <a2068291-e554-cc4f-9af9-0022f3c4de34@nvidia.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Jon

> Actually no. Looking at snd_soc_init_multicodec() it always allocates
> memory if any of the 'legacy' codec members
> (codec_name/codec_of_node/codec_dai_name) are populated. However, this
> looks quite fragile to me and is susceptible to leaking memory if the
> user/machine driver already incorrectly allocated the memory as well as
> populating these legacy codec members.

Yeah, sorry I was 100% misunderstood.
I thought there is a case that defered card connected to
unbind_card_list, and try snd_soc_init_platform/codec again
without freeing memory...
very mess

> My concern about all of this is it is not fool proof and hard to detect
> if a machine driver is doing something bad that it should not.

Yeah, agree.
Best solution is removing legacy style, I think.

> It is still fragile. Again the machine driver could have incorrectly set
> these 'allocated_platform/codecs' members as they are exposed to the
> machine driver. You have no way to determine if the machine driver is
> doing the correct thing or not. The problem becomes more complex with
> probe deferral.

Indeed there is such case so far, but my understanding is that current
driver should select "legacy style" or "modern style".
If driver setup it as "legacy", but access to "modern" member,
it is driver side bug, right ?

Best regards
---
Kuninori Morimoto