Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266204AbUA1VpT (ORCPT ); Wed, 28 Jan 2004 16:45:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266206AbUA1VpS (ORCPT ); Wed, 28 Jan 2004 16:45:18 -0500 Received: from mail.kroah.org ([65.200.24.183]:38294 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S266204AbUA1Vn4 (ORCPT ); Wed, 28 Jan 2004 16:43:56 -0500 Date: Wed, 28 Jan 2004 13:43:56 -0800 From: Greg KH To: Marcelo Tosatti Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PC300 update Message-ID: <20040128214356.GA8999@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 20 On Wed, Jan 28, 2004 at 05:42:11PM -0200, Marcelo Tosatti wrote: > > - Mark pci_device_id list with __devinitdata Noooo!!! I think we've finally audited all uses of this. Do not do this please, it is wrong for 2.6. > - Add #ifdef DEBUG around debug printk() What's wrong with dev_dbg()? It gives you a much better idea of which device is spitting out the messages. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/