Date: Wed, 28 Jan 2004 14:22:25 -0800
From: Tim Hockin <thockin@sun.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       rusty@rustcorp.com.au
Subject: Re: NGROUPS 2.6.2rc2
Message-ID: <20040128222225.GH9155@sun.com>
Reply-To: thockin@sun.com
References: <Pine.LNX.4.44.0401281757190.6213-100000@localhost.localdomain> <Pine.LNX.4.58.0401281007420.27790@home.osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.58.0401281007420.27790@home.osdl.org>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1011
Lines: 29

On Wed, Jan 28, 2004 at 10:10:02AM -0800, Linus Torvalds wrote:
> Although I do believe that it would be better written as
> 
> 	#define MAXGROUPS (1000) /* Arbitrary, but we have to limit it somehere */
> 
> 	if ((unsigned) info->ngroups > MAXGROUPS)
> 		return -ETOOEFFINGLARGE;
> 
> as I absolutely _despise_ code that tries to be too generic. 
> 
> What is it with CS classes that have removed "common sense" from the 
> equation?

OK, there are two easy answers to this.  I can re-work it with a simple 32k
limit that needs to be recompiled to change, or I can add a sysctl to
control it (it appeared in an early version of this patch).

Preference?

-- 
Tim Hockin
Sun Microsystems, Linux Software Engineering
thockin@sun.com
All opinions are my own, not Sun's
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/