Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Manu Gautam <mgautam@codeaurora.org>
Cc:     linux-arm-msm@vger.kernel.org,
        Manu Gautam <mgautam@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list\:DESIGNWARE USB3 DRD IP DRIVER" 
        <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: gadget: Fail request submission if it was already queued
In-Reply-To: <20190111060212.7390-1-mgautam@codeaurora.org>
References: <20190111060212.7390-1-mgautam@codeaurora.org>
Date:   Fri, 11 Jan 2019 09:43:41 +0200
Message-ID: <87pnt3od02.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Manu Gautam <mgautam@codeaurora.org> writes:
> If a function driver tries to re-submit an already queued request,
> it can results in corruption of pending/started request lists.
> Catch such conditions and fail the request submission to DCD.
>
> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
> ---
>  drivers/usb/dwc3/gadget.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 679c12e14522..51716c6b286a 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -1290,6 +1290,12 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *=
dep, struct dwc3_request *req)
>  				&req->request, req->dep->name))
>  		return -EINVAL;
>=20=20
> +	if (req->request.status =3D=3D -EINPROGRESS) {

this test is really not enough. What if gadget driver set status to
EINPROGRESS before submission? A better check would involve making sure
req isn't part of dep->pending_list or dep->started_list or
dep->cancelled_list. It's clear that this won't work very well as the
amount of requests grow.

Anyway, which gadget driver did this? Why is it only affecting dwc3?

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlw4SS0ACgkQzL64meEa
mQa3hA//bnVIRjIdt9cCTa1TdxjxLIm7gWgUTTKIBCAHaV+rBsldkCu20tECdlxL
/BURIZonF7CS4WgGj6hth2ZoPwP9KzMorvo5FG824mLPVJ6AkOssZOVD+HjezLyB
q+ixy90CIiZgYBtKObY6zTo7IxiuwIKL/E/sDzxn75bosJa6JBdkDtgi5oeirynF
5Xse1ODym+/CzxXABOMmOGTS+ymyhhSBHLdhVuafua8SUKNxrL7xnhrX6kEQ+DjD
Unu2Ws1QrK+gp0HzEtzaIyfrFKk20rfFw5trwhTfjjws2W+xCFFWX90qjbFd3aQt
0+HEW34N+NBBThRVN4yT8tSnRmp1FS3x8OPOpWPIa5gwJCCzhGwEs/D7BB1fuab9
yk9XYhgDC/u3heDK/C8McPF0V74kSLZAnL2ZYgNXEbBlHKTNrLZebIVIygVAWs/F
GqPuL/lupJ54totYQvbIs+5a0s4QBW9EXaLa5YY0Kjqc3fZ/vYMfcHYZTO2Gzk9n
p0vW9z54mCmPWvGOukx8HTFSHq3P4agXvwHJ7n6vxwx/J2FzED3YRmxYHTEtLjf6
6dqmDoA2BC52Z1bj7Q3Vf/qd15j5eltjm2WKHrkSroYHqH+ht7cxh1olMJ+bL+cm
VbXHxz41nX1fww4WYI4enUEbS0sys0BMV8RQQ3lzNXPwA0bCs8c=
=+Cqs
-----END PGP SIGNATURE-----
--=-=-=--