Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp370693imu; Fri, 11 Jan 2019 01:48:17 -0800 (PST) X-Google-Smtp-Source: ALg8bN4SqWesRSbm1FuXMk4y2JKUJ20kCrtBlCmUM4SeCatE2kNv0i9SCG1BRi0oiojnBiSRB9yI X-Received: by 2002:a63:5455:: with SMTP id e21mr12839631pgm.316.1547200096996; Fri, 11 Jan 2019 01:48:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547200096; cv=none; d=google.com; s=arc-20160816; b=RBGoCl6KBBs7L37068HOAfJs7/p5daYw4HkM057qEPzx46cZ5FZhM62H/Sd7av3Eo3 TdBG3b66GR2c1LjWUQZBbGDKEikZ/Kgu5ZDWuSw8i11yUV1oOiJ7PsSFOLR4TgAvUmr0 DXL1P621X1fNmtqhNzB29VbNo1PTNN+f336P4iPTvZHWTVPWJRWEgPcvLdYr0iJQQePZ jHW3lsIo1fKr4JsfCi+GGT+K2H/zIHOfGjGwfQeV4JexfI7JDc3fudj50EfMClgxLuAf hf2M52ek06wioBSgOKqEzr2HFEEjpgrq5pEAI7hWoQ+0EY1x3EX0452mRBinpxaXGYZ8 MOyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MX/2rZ9Ui1xuyU6im60xpO0Kqrmer0lOdAC4uufDsDs=; b=dOYEyVCrOj5fAVmVc0gvBJwbQzZqWS1xGxXOpMmTFbgiAU35OKJ9QOSSVm6FX5vtAG Nf85IB7r7uKDrlc7EGekD2SZs8oCoqm+jUQXUZmdIszjXeRv+VO7YHPaqvgg1VSyKByf bHFGfrG58IdwZrf4+6INQ2TvzNFnMsJmQqwvZG6ycTvNk8F8TDv6q8kSsS4SYyq8mcf+ IY+SXxubIcvwSqJM+AmR1TGdO1JJHSesfBLc/S6O3U546g94ouosGClkpxDPyXEezni8 Qi+/kQemZeVe6RwaepiN5AXKtbYPis72TzKvRkjD2eKghijd7tuFPJkra0/kQyVo3/3o u3sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=aHIGgFGN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si14634636pgi.387.2019.01.11.01.47.58; Fri, 11 Jan 2019 01:48:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=aHIGgFGN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729795AbfAKJfC (ORCPT + 99 others); Fri, 11 Jan 2019 04:35:02 -0500 Received: from mail-yb1-f182.google.com ([209.85.219.182]:34517 "EHLO mail-yb1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727008AbfAKJfB (ORCPT ); Fri, 11 Jan 2019 04:35:01 -0500 Received: by mail-yb1-f182.google.com with SMTP id w186so4700374ybg.1 for ; Fri, 11 Jan 2019 01:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MX/2rZ9Ui1xuyU6im60xpO0Kqrmer0lOdAC4uufDsDs=; b=aHIGgFGNs4DnhRrImTc5oEoRBdzp1iNCKHYyulmaTQLMJsdaR0lA/Q9ATLwpgYDZsm 9MK7RYnoAYnGuSGotDeZ5r0hkk8OjcKeVcQ91kzZxGdYcUNNMNgsC/RklsXD/uxpOo4q Kw7cVUYR+ly+SYsW+wpv0tv6r/VW2cTAnep56divkpmC1pRc95oieNZIMyl0EjrQwBNN 015CNb3eyxjvg3ukjE4XnjPPXDT4KIV+GK6aznAlMFefJgk6B/eF+HRnGojbD0Ne7JUX rFmISRCCFUf8AlDcBU4tKV3oP3Z1L+XRbCu80H605MEclby03dVsKeI+Lt2laRrqlrLp VE/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MX/2rZ9Ui1xuyU6im60xpO0Kqrmer0lOdAC4uufDsDs=; b=sExe3BqM3PPk4msTuu811Tc4clud6gBuoj2VImWlYnht5bYO1UjuBKrMkADYfahVUw hh/2Ho5pLI/R/MMQmVLSnDyNU66NpHgDIawZZucJuwaNFSiMb0rdJPKdA5UVnOCSwIJ0 4nPCnSzPUIdam/t2ZfGiwfyQyrgVFdOvNOr4shSN0VhPceyEFc+NRelLTNYhGV5VQng8 Rrau/juUGO1hQ10BedKAleZ1Ltfq9HdiMbIh+NX7FrRyIcJy9CKOpZAg/W3eBi1wFI33 R1cQ9JEwilsEk9fUxzcAcNTtCMHvXCdut0jgw/85qW4YnMtjuOWCCF7RBKkPDr/B4YOe Olww== X-Gm-Message-State: AJcUukcjFTsipxMEM6f3OzX3e5jByYwCodxLtEgA5w+09nES6FUtyRpT wL0Pbr0NKwusM2by2BlCKtOihLA5+r7Ohq98q4GenA== X-Received: by 2002:a25:b08b:: with SMTP id f11mr13308071ybj.236.1547199300403; Fri, 11 Jan 2019 01:35:00 -0800 (PST) MIME-Version: 1.0 References: <351f5da149072c8c1165f8f205ac5c852a92dff8.camel@redhat.com> In-Reply-To: <351f5da149072c8c1165f8f205ac5c852a92dff8.camel@redhat.com> From: Eric Dumazet Date: Fri, 11 Jan 2019 01:34:49 -0800 Message-ID: Subject: Re: [BUG] moving fq back to clock monotonic breaks my setup To: Paolo Abeni Cc: ian.kumlien@gmail.com, netdev , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 10, 2019 at 12:55 AM Paolo Abeni wrote: > > On Thu, 2019-01-10 at 09:25 +0100, Ian Kumlien wrote: > > This works, and so does: https://marc.info/?l=linux-netdev&m=154696956604748&w=2 > > > > Pointed out by Paolo (tested both separately) > > Note: I cleared the tstamp in br_forward_finish() instead of > br_dev_queue_push_xmit() because I think the latter could be called > also in the local xmit path, via br_nf_post_routing. > > We must preserve the tstamp in output path, right? > I was not aware of your patch, SGTM, thanks.