Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drivers/md.c: Make bio_alloc_mddev return
 bio_alloc_bioset
To:     Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc:     shli@kernel.org, Jens Axboe <axboe@kernel.dk>
References: <20181222100845.566772-1-marcos.souza.org@gmail.com>
 <20190111021740.GB1228567@bebop>
From:   Guoqing Jiang <gqjiang@suse.com>
Message-ID: <df34a41a-0818-2251-9316-9a6f0c8d6ace@suse.com>
Date:   Fri, 11 Jan 2019 17:07:50 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20190111021740.GB1228567@bebop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/11/19 10:17 AM, Marcos Paulo de Souza wrote:
> ping?
>
> On Sat, Dec 22, 2018 at 08:08:45AM -0200, Marcos Paulo de Souza wrote:
>> bio_alloc_bioset return a bio pointer or NULL, so we can avoid storing
>> the returned data into a new variable.
>>
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Add Jens to cc list, anyway, Acked-by: Guoqing Jiang <gqjiang@suse.com>

Thanks,
Guoqing

>> ---
>>   drivers/md/md.c | 7 +------
>>   1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/md/md.c b/drivers/md/md.c
>> index fc488cb30a94..42e018f014cb 100644
>> --- a/drivers/md/md.c
>> +++ b/drivers/md/md.c
>> @@ -207,15 +207,10 @@ static bool create_on_open = true;
>>   struct bio *bio_alloc_mddev(gfp_t gfp_mask, int nr_iovecs,
>>   			    struct mddev *mddev)
>>   {
>> -	struct bio *b;
>> -
>>   	if (!mddev || !bioset_initialized(&mddev->bio_set))
>>   		return bio_alloc(gfp_mask, nr_iovecs);
>>   
>> -	b = bio_alloc_bioset(gfp_mask, nr_iovecs, &mddev->bio_set);
>> -	if (!b)
>> -		return NULL;
>> -	return b;
>> +	return bio_alloc_bioset(gfp_mask, nr_iovecs, &mddev->bio_set);
>>   }
>>   EXPORT_SYMBOL_GPL(bio_alloc_mddev);
>>   
>> -- 
>> 2.16.4
>>