Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp505382imu;
        Fri, 11 Jan 2019 04:21:17 -0800 (PST)
X-Google-Smtp-Source: ALg8bN4dHBXTCKLqH0ltApkec0gw0hnEXhPTcvQaHndrdhGQ+4SC/E1OIQOxBmEkCt36NkAinLmA
X-Received: by 2002:a17:902:e012:: with SMTP id ca18mr14381671plb.218.1547209277056;
        Fri, 11 Jan 2019 04:21:17 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1547209277; cv=none;
        d=google.com; s=arc-20160816;
        b=RePNvVG2/THDZGJUenG3Sk58iLJCtsDZJdtUEvSqi43+NzgjBt6hfHXbjmaKx74fgD
         oFoWlJpw6NTrK1wetG1PxUn+2pcqZDE7kcTUG+13NeInBPUiijHX2ln7kDkv7QDE84rf
         EcBWLMB91oTBxEu06GV2m5ej0DxUptnHFAbkvc8uvO2a8m0VJJ59RhtuPhgU0WzpnDWO
         afTkgGTY/jMq4ENRsRk1RJ0/z7wc4Zw5Jm6qzMhjS0GEIMyWMK4tI/nd6CXGWgw31j28
         CclezHUVFdE2WbMbhM5xzq1INXQXcLE+djAQbPXZqIFQHNRoHr+aZ84D9wK5PNFr0bW+
         uoBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=1rrvMM4MjDeO//ECKMPyDeXrm6Ya4/OwKYxd/hh4D14=;
        b=Tot6c1ofrJ5VyH5n1LrFJ0EDNsj/slkR8MW2L8wYipMKELIbrWOzb3tMx/wi3Mzjmv
         1myDIKXTEpyxnKxjbQDjs8CN+8zHEaU7cCBtmGZ3E+9D/YwQORtkgQqGGpHKVCsfOvs6
         gxrVG3xI33ppYFUinUAxOD5Zi/WBVZM6KTmFX4f6OuZ//rihShVQRkVfhrGFeoiF8rfa
         jdWQ+1tGZ9i56DPZgYkbMDra0almmwTSa98xcFQl5M9r4pZWj0dPtfENGUQwYhGFtZMN
         fkeugP6po+ozGLSijEujdNVe2TQoE/wMm09FO93AN56E/96KFnx0qorEioJLwGcxksjl
         qDYg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=DsDYTZNh;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id m3si3897931plt.394.2019.01.11.04.20.32;
        Fri, 11 Jan 2019 04:21:17 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=DsDYTZNh;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731366AbfAKJPs (ORCPT <rfc822;morganleezd2003@gmail.com>
        + 99 others); Fri, 11 Jan 2019 04:15:48 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:12270 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731355AbfAKJPr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Jan 2019 04:15:47 -0500
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c385ea80001>; Fri, 11 Jan 2019 01:15:20 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Fri, 11 Jan 2019 01:15:46 -0800
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Fri, 11 Jan 2019 01:15:46 -0800
Received: from [10.21.132.148] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 11 Jan
 2019 09:15:44 +0000
Subject: Re: [alsa-devel] [PATCH v1 3/3] ASoC: soc-core: fix platform name vs.
 of_node assignement
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
CC:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        <linux-tegra@vger.kernel.org>, Matthias Reichl <hias@horus.com>,
        <alsa-devel@alsa-project.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Takashi Iwai <tiwai@suse.com>, <linux-kernel@vger.kernel.org>,
        Marcel Ziswiler <marcel@ziswiler.com>
References: <20181218174040.k7u26vnnoplllnwb@camel2.lan>
 <952471da-b355-6471-6c19-5120d6704f81@nvidia.com>
 <87lg3vuc7p.wl-kuninori.morimoto.gx@renesas.com>
 <b5164c93-8be8-1c3d-9415-c895da6ad622@nvidia.com>
 <d1e41ed2-da7c-b46c-bc6d-64cf3e536771@nvidia.com>
 <865d2a3e-bf6b-1f30-1179-7e922c0d0641@nvidia.com>
 <87k1je38w7.wl-kuninori.morimoto.gx@renesas.com>
 <0660a471-3698-2059-4494-ad146518a4ed@nvidia.com>
 <20190109125340.GD10405@sirena.org.uk>
 <52f5f2cf-9260-f9c5-f73d-3c3d5debc86b@nvidia.com>
 <20190109141439.GE10405@sirena.org.uk>
 <875zuxb9uy.wl-kuninori.morimoto.gx@renesas.com>
 <a2068291-e554-cc4f-9af9-0022f3c4de34@nvidia.com>
 <871s5kqb43.wl-kuninori.morimoto.gx@renesas.com>
 <dfdc497f-9e52-99d7-208c-d8eef31fe61d@nvidia.com>
 <87h8efpoxh.wl-kuninori.morimoto.gx@renesas.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <ea6b6a3a-b4eb-1d29-51fd-330b2b170005@nvidia.com>
Date:   Fri, 11 Jan 2019 09:15:42 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <87h8efpoxh.wl-kuninori.morimoto.gx@renesas.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1547198121; bh=1rrvMM4MjDeO//ECKMPyDeXrm6Ya4/OwKYxd/hh4D14=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=DsDYTZNhPgMJ3FDbLxs78qyl1Hn3WGNpHIGRlvG5LfkIFdfswnEuqwQryE1vOrODg
         UX4oCRAQ4yLH4DC9pqt4V1iWn7e7TwZawUBSSC+/EC0bLgSBNYA3p9oz/9RLQXkQ4n
         4t+faVsgEQkeRuGfYCeQwtwe5Ji/U+iy1MbQ6qM/304xNmzCSJcxhU0TSfpt1vnJgo
         BKejbAhKVYdbJbG4EOL/LRvbyYCGGVQRRF7SPlyez5Yiz6ruF4cPKb9ynWwx4RPKrx
         M2plav0bbaOXeO1wv/jkgaEhUqaQrEToQZeEMBJpvHhINGSb8iLkhj5IIr5EvDud70
         ETRac366QakoA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/01/2019 08:51, Kuninori Morimoto wrote:
>>> Indeed there is such case so far, but my understanding is that current
>>> driver should select "legacy style" or "modern style".
>>> If driver setup it as "legacy", but access to "modern" member,
>>> it is driver side bug, right ?
>>
>> Yes absolutely it is a driver bug, but looking at the snd_soc_dai_link
>> structure today it is not clear what the driver should be setting and
>> what is 'modern' and what is 'legacy'. You need to dig through the git
>> history and code to figure this out. So you could say it is not very
>> well documented/commented from a soc-core perspective and could be easy
>> for a driver writer to get themselves in a pickle/mess. Anyway, that is
>> easy to fix and we could add some comments to clear it up.
> 
> Thank you for your feedback.
> Yes, indeed there is no enough information/documentation about
> legacy/modern style, and its plan
> (= all driver will be switched to modern, legacy will be removed, etc, etc..).
> 
> So, can you agree about these ?
> 1) Add enough information/documentation about legacy/modern style and its plan.
> 2) Add dirty pointer fixup patch as workaround
> 3) switch to modern style as much as possible

I think that Mark needs to decided on whether use your 'dirty pointer'
fix or not.

Jon

-- 
nvpublic