Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp518335imu; Fri, 11 Jan 2019 04:35:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN4oT4HdkRRyC8voKI0BLupHE0yOrwKC43eFfh4hf5oXjqyN/TPdFpfz/X+60opZ9lHsbjGU X-Received: by 2002:a63:e156:: with SMTP id h22mr13280158pgk.255.1547210140950; Fri, 11 Jan 2019 04:35:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547210140; cv=none; d=google.com; s=arc-20160816; b=zIn791YpfATm3FX+zigRH+hCh8rfafvcPSYY2D5Eo8yVJ/dZT16RCS01ppTzTpkzdN liT2V8I3kqHlzQlsbVF4CRNKHk0rI1FZDbX+1+k9K6HFyQjSpsz3g5pUfg6cwcM+8/Pj QA1Rq42+KqlPPZx7py7bzV6ySXXVzZRDEKljK/GkqZI42CqICDSDwQoz4qlYxnMXpU9c wlPAa+lmUxGFXTfDLnbElL7YwZ4E71eSeLuA35PwsNyFDQiA+HmW/xdg0iNjgt7HWUfX s3kVUDU+T7Q1MVoS5gILrWRAH67EycGg4FEKDLkBZv34fuz+IooqTUJyeZsNLoYi7WKq ot/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=XIQwehbPrlY7BUP6CB2B8k1PMAjTFQv50MV82hxeWcg=; b=hRkYXVGUzzJpXRvRC1B9Js599rxpIgxsya0JV8fkxqtrNvIVk/3Y/9XLPCNR/p/HIq z1IyM9TE5ibf6x0YZynbjup6myr/g/N/b7/Veoz5jSLGUKtKCZ2T8UYCnWnBQdJ65qHo Sg2cwEF8KCmmWS9hkha671TLbD5A4aISRU66c5PakEqkuojFZEIcy9KJjPPqo2rRuqcu NAJ7UBjcIaYe0MIGP8eZI7kQKUWAW3m6UCfk2AjN4rUZ8a61hSxzJU6XYzQ1nIDxs3BU m/cnMO6FwTpXnMbgb3L9JWqPc15guWvq4ou7fSshnJyHVFgeAtERL7eiccjH1GiuBemL UcoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tWXRdCZ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v61si7167715plb.54.2019.01.11.04.35.24; Fri, 11 Jan 2019 04:35:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tWXRdCZ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731516AbfAKJwO (ORCPT + 99 others); Fri, 11 Jan 2019 04:52:14 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:39641 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730155AbfAKJwL (ORCPT ); Fri, 11 Jan 2019 04:52:11 -0500 Received: by mail-lf1-f66.google.com with SMTP id n18so10376815lfh.6; Fri, 11 Jan 2019 01:52:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XIQwehbPrlY7BUP6CB2B8k1PMAjTFQv50MV82hxeWcg=; b=tWXRdCZ2D6dwuoxQCh+RSNF1sdTWe5eu6rGt1gdnelgAg+UpYdmuyd3uGqpm/xKggV FwkYDfUC3iYLJORA37eEHgCPFduhyuXXTQgVWPGJ2RyG3pXAH8b9xci8KhOf2ycb7085 lYuzmfoke1FcGvVNSA1rJGdieywkiZ0Wix8XOBIy5kPlUilOpOYrEeLDU5bVE8eM2+dq J8RWKsmM43a0R1dwLBx+ds+qwbfYWyyCNLs37LcrgFEXSg82lJqu8N2bJLTILEIfZww8 mLccx6gmDpiy3wSlc6DGHhDcgwK1ePCMqksJWB8fm4zvVUh6XQngVmjgmCTMAtxb0k2l ldng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XIQwehbPrlY7BUP6CB2B8k1PMAjTFQv50MV82hxeWcg=; b=DNgfrPxcYYHJXv6NaKbTAF/dWU16V5gUbTz0o0+vFsfbCzii9fiS1G+JXwLeGAJL8T SMTj/coCl0Ls/9gQGE/Q6FV5hhNEaV6EEMgogfQjtXueymqMVzem0daKRzHoP3SUN+ft tMaV7CmyDJJPpREyoyPfjtbIq92vcxSz+HVHOFNCA8/AAj7fllXPZ86sPZ7iU6aMfyfM 58L46ZNO4MDDuTZ0LPQD0vPIpj7lHXtv+L+esuhvyp6dLgMiDVOukdvarPFGufO4+Ns6 Vyoghn5EIDxOkHjUOX38NpBVMvnqcCDR7OhsNSGee+nBMeUZ+33ti9XAxXtdUejU/gx7 de9A== X-Gm-Message-State: AJcUukcInNv+hixeun9ZUS1zDHnvQGKDSKQ6hPBl3XQlYd9YyrO8PibL kp5k9QICw5u6ihoZQ7YobKkqnLHZn93rph9twQk= X-Received: by 2002:a19:6514:: with SMTP id z20mr5734838lfb.31.1547200328069; Fri, 11 Jan 2019 01:52:08 -0800 (PST) MIME-Version: 1.0 References: <351f5da149072c8c1165f8f205ac5c852a92dff8.camel@redhat.com> In-Reply-To: From: Ian Kumlien Date: Fri, 11 Jan 2019 10:51:56 +0100 Message-ID: Subject: Re: [BUG] moving fq back to clock monotonic breaks my setup To: Eric Dumazet Cc: Paolo Abeni , netdev , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 11, 2019 at 10:35 AM Eric Dumazet wrote: > On Thu, Jan 10, 2019 at 12:55 AM Paolo Abeni wrote: > > On Thu, 2019-01-10 at 09:25 +0100, Ian Kumlien wrote: > > > > > This works, and so does: https://marc.info/?l=linux-netdev&m=154696956604748&w=2 > > > > > > Pointed out by Paolo (tested both separately) > > > > Note: I cleared the tstamp in br_forward_finish() instead of > > br_dev_queue_push_xmit() because I think the latter could be called > > also in the local xmit path, via br_nf_post_routing. > > > > We must preserve the tstamp in output path, right? > > > > I was not aware of your patch, SGTM, thanks. And you can add Tested-by: ian.kumlien@gmail.com