Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp623516imu; Fri, 11 Jan 2019 06:22:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN5AvZuKkrfOThl3aKF+8mr+rFIn1IZdE/tsOk1S7WKeCNZeKYWkmSe3eobOLajSrzxOedMG X-Received: by 2002:a62:cd44:: with SMTP id o65mr14700980pfg.222.1547216554593; Fri, 11 Jan 2019 06:22:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547216554; cv=none; d=google.com; s=arc-20160816; b=qy1V8LRjtsENoApQKW4yI+tUYbFbNgqSa4Ga4GQ/6Y478z2xFJ2JBYMWaqNo7zQgea L68qLGGIEWMQ/onUPGqIbLqtou9bMsmJiC19zFLkTp6ZNiN+OJSV18CI9KYcfMnF0MAt HptdqkAG4j5c/dwB1Re2+uytOuMWmMVNdDxUSToxaGkMKPUSsoT6psFkGckeh26NYA/0 vzeqGo8ya/xJrlYfzYc4cQgpDjeAF5uZ/66gfeUU1PzkKKQ/SbbMYRR519hHCJaz5YQx iuNI3cUwSIll5BlDXbGgy0PKvYT2xE1Q8XUVe8H6g3Vtm9kHSuLejtpSc4lod8Pjmvvc XRQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VDBJgxxbY2NrWHhBFQ+tGTwnQKhAzl68PFStSFa0F7A=; b=mOGhfP+ccO0DxVwasdOB9wsEKbJU3aFQeTSa0FeGWbCZEcLzBQ9I28pcyYUPi/RveH 0iWrKo1NWXntNWrQfcO8v7JkR2RiYbUuu3qqK9ZlFMpnVk+6eyy2F8PxXURK+CaILKgT idupcYeY7QCPOvyAJuXZUzUg1pq9H89nL3Ijg1zD0r1DWgkNRuw0+66Ss1MtSy+zIpW3 TFjHorMboTAdKYLUQYp0Pm03rNXt0W2Xu7H5N0CwFXvOjeGfZ3GkRZir9hJ1Fmxb923h 8HRwZg+QXtJjbNpNT64BZyCBlZQ8l5kMi5G5wx83Jmsc1Ws3eEZp1+Nd/D/v7Stoukpx lkZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dSjiSK1g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s5si12920913plp.139.2019.01.11.06.22.19; Fri, 11 Jan 2019 06:22:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dSjiSK1g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733012AbfAKOCt (ORCPT + 99 others); Fri, 11 Jan 2019 09:02:49 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:37615 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729247AbfAKOCt (ORCPT ); Fri, 11 Jan 2019 09:02:49 -0500 Received: by mail-qk1-f196.google.com with SMTP id g125so6562515qke.4 for ; Fri, 11 Jan 2019 06:02:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VDBJgxxbY2NrWHhBFQ+tGTwnQKhAzl68PFStSFa0F7A=; b=dSjiSK1gX3sungWxyzDzKb1aOU1lKMhUtKwsYtKTaHjcowk/XUXihvhu1Cqpd8prmJ pDNpG5vrVoVhfBnjxP4XlENftUFOPOoPo88sk4Erthtc+dpWnnQOQP7vNK0PHbdA0jR7 nL8wldtfSvv7V8go14VulRhVg509BtwQ/XYycRQGeB8t7//3CUWUk3nT+Aa6y2Lasqf1 sar3q7p4p8zn1OswCernromkWOif4Y7BuNA7A4vDJ1Hxu3vU1/MS/19tlm15LsLftplK SWZ7/PagdVLRxCDmppgz842/lxaTjHXiImK46g9x/Ml6lrWrrB5jyoS4lmO8fX+z0gZw hWyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VDBJgxxbY2NrWHhBFQ+tGTwnQKhAzl68PFStSFa0F7A=; b=i51D28R3MIFixj2k5NleuGnz+F4x0XJokPCa3ga7v30spE14OcSZOo2Ro4XheexcV6 HNaxX5R4Pbb+cTZapATrQ2MBrvwbufOaz2/F6KYQ7jo2SMe1l1fk/ZOwICo8s1ZHdNpU TurSKCeG6VUd4a4WOJ8fPU3ecXRnauKgbXlAt+biZIdB4F8wM9O90vOrg4gejzFVTfr8 jIrSWieGA7a9CGutrHvRFFPXt9+hzwHDFMROC9oUtotay0ahva7Bozk3xQv/cDALPeuC jZEhYw3uKSnNS/mMRXjx/bTpZWw3rePKSAPpUQf0XFRnGSZlRGF5st4Zkg75oKZmxEcB DEFA== X-Gm-Message-State: AJcUukf1rm1pEyx9OuMhZqJVq7nl8XBMmF4zk2h/ZHNZB+9qWBvAzvYu EqxhIS4gQln0sFryA29UoXg= X-Received: by 2002:a37:9442:: with SMTP id w63mr12697333qkd.109.1547215367911; Fri, 11 Jan 2019 06:02:47 -0800 (PST) Received: from localhost ([144.121.20.162]) by smtp.gmail.com with ESMTPSA id f19sm45081835qtf.1.2019.01.11.06.02.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 06:02:46 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: Rob Clark , Dave Airlie , Gerd Hoffmann , David Airlie , Thierry Reding , Daniel Stone , Thomas Zimmermann , YueHaibing , Rob Clark , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/cirrus: fix connector leak at unload Date: Fri, 11 Jan 2019 09:02:34 -0500 Message-Id: <20190111140242.29002-1-robdclark@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload. Signed-off-by: Rob Clark --- Similar case to the issue that was fixed recently in drm/ast drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus/cirrus_fbdev.c index 4dd499c7d1ba..bb379ec4c182 100644 --- a/drivers/gpu/drm/cirrus/cirrus_fbdev.c +++ b/drivers/gpu/drm/cirrus/cirrus_fbdev.c @@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev, { struct drm_framebuffer *gfb = gfbdev->gfb; + drm_crtc_force_disable_all(dev); + drm_fb_helper_unregister_fbi(&gfbdev->helper); vfree(gfbdev->sysram); -- 2.20.1