Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263462AbUA2JC3 (ORCPT ); Thu, 29 Jan 2004 04:02:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263526AbUA2JC3 (ORCPT ); Thu, 29 Jan 2004 04:02:29 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:1034 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S263462AbUA2JC0 (ORCPT ); Thu, 29 Jan 2004 04:02:26 -0500 Date: Thu, 29 Jan 2004 09:02:22 +0000 From: Russell King To: Marcelo Tosatti Cc: Christoph Hellwig , torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PC300 update Message-ID: <20040129090222.A20867@flint.arm.linux.org.uk> Mail-Followup-To: Marcelo Tosatti , Christoph Hellwig , torvalds@osdl.org, linux-kernel@vger.kernel.org References: <20040128212115.A2027@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from marcelo.tosatti@cyclades.com on Wed, Jan 28, 2004 at 10:06:25PM -0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 33 On Wed, Jan 28, 2004 at 10:06:25PM -0200, Marcelo Tosatti wrote: > On Wed, 28 Jan 2004, Christoph Hellwig wrote: > > > - Mark pci_device_id list with __devinitdata > > > > This is bogus and can crash the kernel if you're unlucky. > > Other wan drivers are doing the same: > > [marcelo@logos wan]$ grep __devinitdata * > farsync.c:static char *type_strings[] __devinitdata = { > wanxl.c:static struct pci_device_id wanxl_pci_tbl[] __devinitdata = { > > I believe a handful of others are using "__devinitdata". How can the > kernel crash because of this? Who will try to touch the data? It is particularly notable when someone inserts a Cardbus device. A new PCI device is added, and we scan all drivers looking for a match using the PCI ID tables. If _any_ PCI ID table which is part registered as part of a driver is marked using __devinitdata or __initdata, this will either cause the kernel to read invalid data (possibly entering a long loop) or oops. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/