Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 11 Jan 2019 14:49:56 +0100
From:   Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To:     Tomas Bortoli <tomasbortoli@gmail.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, syzkaller@googlegroups.com
Subject: Re: [PATCH] KVM: validate userspace input in
 kvm_clear_dirty_log_protect()
Message-ID: <20190111134955.GE14852@flask>
References: <20190102172937.28741-1-tomasbortoli@gmail.com>
 <99de332c-d4e3-0628-8ad1-982032e67690@redhat.com>
 <8418f6c8-0fc8-e22c-c39a-bfcaee7471e2@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8418f6c8-0fc8-e22c-c39a-bfcaee7471e2@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019-01-08 17:28+0100, Tomas Bortoli:
> Hi Paolo,
> 
> On 1/7/19 11:42 PM, Paolo Bonzini wrote:
> > On 02/01/19 18:29, Tomas Bortoli wrote:
> >>  	n = kvm_dirty_bitmap_bytes(memslot);
> >> +
> >> +	if (n << 3 < log->num_pages || log->first_page > log->num_pages)
> >> +		return -EINVAL;
> >> +
> > 
> > This should be
> > 
> > 	if (log->first_page > memslot->npages ||

(Wouldn't this be clearer with a >= instead?)

> > 	    log->num_pages > memslot->npages - log->first_page)
> > 		return -EINVAL;
> > 
> > i.e. the comparison should check the last page in the range, not the
> > number of pages.  In addition, using "n" is unnecessary since we do have
> > the memslot.  I'll do the changes myself if you prefer, but an ack would
> > be nice.
> > 
> > 
> 
> 
> Yeah, I agree. Thanks for the reply and sure you can do the changes, np :)

Done that and applied, thanks.