Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/3] riscv: Introduce huge page support for 32/64bit
 kernel
To:     Paul Walmsley <paul.walmsley@sifive.com>,
        Alexandre Ghiti <aghiti@upmem.com>
Cc:     aou@eecs.berkeley.edu, catalin.marinas@arm.com, palmer@sifive.com,
        ndesaulniers@google.com, linux-kernel@vger.kernel.org,
        mingo@kernel.org, atish.patra@wdc.com,
        linux-riscv@lists.infradead.org, akpm@linux-foundation.org,
        mike.kravetz@oracle.com
References: <20181210062146.24951-1-aghiti@upmem.com>
 <20181210062146.24951-2-aghiti@upmem.com>
 <alpine.DEB.2.21.9999.1901102215390.22105@viisi.sifive.com>
From:   Alexandre Ghiti <alex@ghiti.fr>
Message-ID: <8a96dec9-ac00-5b3c-e532-2c8ef0e3a537@ghiti.fr>
Date:   Fri, 11 Jan 2019 14:58:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.9999.1901102215390.22105@viisi.sifive.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/11/2019 07:18 AM, Paul Walmsley wrote:
> Hello Alexandre,
>
> On Mon, 10 Dec 2018, Alexandre Ghiti wrote:
>
>> This patch implements both 4MB huge page support for 32bit kernel
>> and 2MB/1GB huge pages support for 64bit kernel.
>>
>> Signed-off-by: Alexandre Ghiti <aghiti@upmem.com>
> This patch introduces a few minor checkpatch and strict checkpatch
> warnings, when tested against both v4.20 and v5.0-rc1 checkpatch versions.
> Could you fix those?  The other two patches in the series look OK from
> that point of view.

Yes, I had noted those warnings:

- the SPDX warning is weird, in all *.c files, the script seems to 
accept only
   "// SPDX-License-Identifier: GPL-2.0" and not "/* 
SPDX-License-Identifier: GPL-2.0 */".
   But on *.h files, this the contrary, maybe I missed something, I am going
   to take a look at the script spdxcheck.py.
   Note that kernel/ftrace.c and kernel/perf_event.c raise the same 
strange warning.

- I'll change the "printk(KERN_ERR" into a pr_err.

- I'll ignore the last warning regarding the new file.

Thanks for your feedback Paul,

Alex

>
>
> - Paul
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv