Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp921564imu; Fri, 11 Jan 2019 11:29:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN5R+Ac1G5yZtbs859+YW5unBg6vhWAgzUQqyNv+G8kDBP/QjwMycBkFuVRMIRr+91GuDg3g X-Received: by 2002:a17:902:f20b:: with SMTP id gn11mr15228553plb.274.1547234945550; Fri, 11 Jan 2019 11:29:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547234945; cv=none; d=google.com; s=arc-20160816; b=CYhYHpVRl1NVmdnAolVEIKW6bQT9NI9Nfpf31uBt9l4RXjE9wIIi+zTH+hVPV0GjLm 33+YaPxOrEnR1vAC6Enl/wpHCRnyIHvLUSHRrZsuOD76G2oFYAIjr8G0bUxj7ft+VGzs 2H7rhD8/ELpW6RP86z63Ysc6giwQNgo0ZdybJB2I9g2cpGRcsy7euehJHlXjV/JL/dy/ c0k5ueI5wCZx6I2gT2/nv1lfJPVwp5KyKTYpNl9JagcqxazfNPg9HDNrPcMgM+Y2gh8e AW+Ho4L/YLCoRaCc5TF2Utkq2MIg+VRNwIYkDMnhbHUhe5OLZMHYEBB7ahhdRy2R0Trk BPSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bpftuWcNFZTXHij4RFXkkkkYBOsTmMLn4yOnCQm9JJM=; b=BG5DPfSuktHyLHS/fKyTMom/riwcgtFdZSbzcjxLHaN8fE6FDLfZsJqa3vlhGY8RV5 XVty7Y1QTu5tyIPDkqgsTfXmf+AZpeJ4D1sQYX+apoQcWa3ZIyw4TNU1Rmbh3ARMjLL9 QJsMy38fPI89l+TBqMMFj8GPaJ/2GQpa8xBm9grPmKTEkapt/CHYqJoRZ/7zPdXrGLRQ GB2feQad+zeR+hr1ONYIyjYhUFN9tup9CQAJ8yA0i5CQ412z3fFKzOcU+GDINObrk+7h 007GgNPU+6pjsTapxB31l1MemkTORolPkmK+bKWB+lVmfcCQfVvk6aIkBya3leUFqrCC ke5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fXRujlhU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11si49037676pgo.474.2019.01.11.11.28.48; Fri, 11 Jan 2019 11:29:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fXRujlhU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388297AbfAKO0n (ORCPT + 99 others); Fri, 11 Jan 2019 09:26:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:34172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387897AbfAKORo (ORCPT ); Fri, 11 Jan 2019 09:17:44 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BBF102177B; Fri, 11 Jan 2019 14:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216264; bh=xguMtctK6F4fsqcmC4g3wDGgmz4Veasv2R0VDyhWB7Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fXRujlhU45/E0ZEk2oF9d4l1gG+ej6AUB+mLO333BkNINNOIFmB36RsVbqzofepAd 275aI9mKb4Woz2Ev5H8IfX0D7Ul083fbCdwbOTB2GwpyguuTqmmkvWhQtDMXJinbRi dkUjps1ld2Ode3mb5MUC74x08euPqiT7HpfdPfPw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mohan Kumar , Dara Ramesh , Sameer Pujar , Takashi Iwai Subject: [PATCH 4.4 35/88] ALSA: hda/tegra: clear pending irq handlers Date: Fri, 11 Jan 2019 15:08:04 +0100 Message-Id: <20190111131051.065992594@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111131045.137499039@linuxfoundation.org> References: <20190111131045.137499039@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sameer Pujar commit 63d2a9ec310d8bcc955574220d4631aa55c1a80c upstream. Even after disabling interrupts on the module, it could be possible that irq handlers are still running. System hang is seen during suspend path. It was found that, there were pending writes on the HDA bus and clock was disabled by that time. Above mentioned issue is fixed by clearing any pending irq handlers before disabling clocks and returning from hda suspend. Suggested-by: Mohan Kumar Suggested-by: Dara Ramesh Signed-off-by: Sameer Pujar Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_tegra.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -249,10 +249,12 @@ static int hda_tegra_suspend(struct devi struct snd_card *card = dev_get_drvdata(dev); struct azx *chip = card->private_data; struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip); + struct hdac_bus *bus = azx_bus(chip); snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); azx_stop_chip(chip); + synchronize_irq(bus->irq); azx_enter_link_reset(chip); hda_tegra_disable_clocks(hda);