Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp995186imu; Fri, 11 Jan 2019 12:56:59 -0800 (PST) X-Google-Smtp-Source: ALg8bN5/uPDpD8ZUaZKhmj7m6eoFA4Z4cTmxAKV+Zh3GuCNk5ZBD+5BkhlRzWKJi4bOZZuOdagBw X-Received: by 2002:a62:546:: with SMTP id 67mr15677759pff.99.1547240219111; Fri, 11 Jan 2019 12:56:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547240219; cv=none; d=google.com; s=arc-20160816; b=cxGY1zC8T+HiIboSKdF1nYkySB2K1Qy9tDQhQYmMJGlQEunPKEsbs4YpaPplUXCS9V A3gxt28ki6QztwFiym+kiUeOrGh/jOAOgjtL9IgHlFDVpfZbGFeVEerwcSYmvcW5DFZb DLyuuMu0sA6byilTvUnDRaoQbS5C/w+bZ758i8XeVTZVo3yhR/6F3dnlMh/fDokxAjD5 82AIp0sF4wIEyM4qoIZyGuqaVtDevMRQ2bCtlC+ADbKsly5wSyPuOIa11SiIRdTg1T/4 L64YbSstDPl1S9bHRxr1DBuh/bazNwezYRjn1f+jQNV9XDztwylWRhZVsVmMEHDb7Z6k A1Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=gcJD6bPVlZu80xGXZbHCfNg2C5gpHHlVbNKG5RfKAiU=; b=eY7UCiwmScHWIMlgv7GyvCXX1nw/aFNrooj5wU2gbgtLH2tlp+S4ZYvn9PuLfHbdrh Ulhsd6tWUcpUtYDDS8ffS+vkDyzkZ03Rv791WC5tBcwgAYku5Kbx5REoY0eevfIkaJND sjheR88H0rxLXEmJ0qn0exEtOap44sJz2RJyVVLtg7578td2M5HbsUOwUwXaOzFIPQIv hQctaweoZHUHh9Ve+bGO3u0LFs/E9WzRWuPnn7/5MtN+2fgnVKfCzE6dwc5EyQc8tQuk yBTuDwRm7r04JlRrOjFCbdomxLg/6gTTwkQTwcEVJMGL8UzaKvVd1InwiZNlCK2yOAuf b5dQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p32si70115938pgm.413.2019.01.11.12.56.43; Fri, 11 Jan 2019 12:56:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387854AbfAKRox (ORCPT + 99 others); Fri, 11 Jan 2019 12:44:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733206AbfAKRos (ORCPT ); Fri, 11 Jan 2019 12:44:48 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 713855A1F7; Fri, 11 Jan 2019 17:44:48 +0000 (UTC) Received: from treble (ovpn-122-231.rdu2.redhat.com [10.10.122.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 646AA60C67; Fri, 11 Jan 2019 17:44:44 +0000 (UTC) Date: Fri, 11 Jan 2019 11:44:42 -0600 From: Josh Poimboeuf To: Petr Mladek Cc: Jiri Kosina , Miroslav Benes , Jason Baron , Joe Lawrence , Evgenii Shatokhin , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v15 00/11] livepatch: Atomic replace feature Message-ID: <20190111174442.6jtvrr7qov3lruxi@treble> References: <20190109124329.21991-1-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190109124329.21991-1-pmladek@suse.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 11 Jan 2019 17:44:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2019 at 01:43:18PM +0100, Petr Mladek wrote: > Changes against v14: > > + Rename klp_active -> klp_added [Josh] > > + Do not clear klp_added variable in klp_free*() [Josh] > > + Rename klp_init_patch_before_free() -> klp_init_patch_early() > [Josh] > > + Do not call klp_free_patch() when > kobject_init_and_add(&patch->kobj) fails in 3rd patch. > The final code stays the same after the refactoring > in 5th patch. [Josh] > > + Better 4th patch subject [Josh] > > + Use safe iterators in klp_free() functions already in 7th > patch instead of in 8th [Josh] > > + Rename free_all -> nops_only and revert the logic in > klp_free*() and klp_unpatch_object*() functions [Josh] > > + Do not refuse loading conflicting patches. Just remove > the ordering (stacking) [Josh] > > + fixed typos, improved wording [all] Petr, This looks great to me. Thanks for all your patience and hard work! Acked-by: Josh Poimboeuf -- Josh