Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp995820imu; Fri, 11 Jan 2019 12:57:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN4cyNB+WrWdI7tq2cb2GIrCBXbazI6+b8WAmZRjV5nHjstXagkwsXwTNppa0JdPSPdUbtL+ X-Received: by 2002:a17:902:9a07:: with SMTP id v7mr15708580plp.247.1547240268432; Fri, 11 Jan 2019 12:57:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547240268; cv=none; d=google.com; s=arc-20160816; b=oWdg73b1/iyS+NZBIQN+73EeGqT2Px/6+jFwiKwIOR2xlcVeN1MW0eyQl3icUxegKf f5AOGw6cMJMwVJw4UT8o0CcEu0HiOvf9N95SZM9LIHX8OtYerXRjU/eKUvpl2X0z0Jxs NY7cganleLBYs//KHW9kEtoah2O6baT9M/fJBr8SgnMS+uUF/B2lPsAaK7fkyAf0LLwf GqoGvzScD/h8Z+ZcFJoY3nqqexEgGW7dck8i0emwNIKs7+ZYsT0s25xVMyV2wcrsvuvD yT0UEFmmTxsRt9jGritFUWK6U+QO6qeev9KvGNPGedEM6Ji1Ay5ee9VDOG/dWvBd8HuU zGzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=PlXu3O61pUFPLleZ5AMTVxcoWeFNM1mKAK5t7dNAM0o=; b=dqhoJTI9SMq13vN3P9PFEg3MBlwy8XtVO4YhjTR38Vn3bOpkkgCMkbLZiHxHwW+eQz 0j1KAGVaDrrgzBqccyrdWtn/EF8JqXQDOY9Li1xXz0y2tMZXCaca/F9Hp3xZ0+0Gf/qJ EU13XqJDbUCLckB08rB9DcA4/Mq3degCiHHoig+FsqJLeqd8AWw/pYRTwDGCUIMNhQFj NNFNleqA4767DS1BbZ0AKWj25P94gFZ3qxMzRkS2qnhCWiROXiQs3qUWDpqsrwjFJ+v5 5q1/dcw5XQqIqh9eHdanqx5RG/2kJLWTVsBKOO921y0hfIKw4EAdTftHI6elloyzBX6c zn+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7si847810plp.147.2019.01.11.12.57.33; Fri, 11 Jan 2019 12:57:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388933AbfAKRd0 (ORCPT + 99 others); Fri, 11 Jan 2019 12:33:26 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:40580 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730574AbfAKRdY (ORCPT ); Fri, 11 Jan 2019 12:33:24 -0500 Received: by mail-qt1-f193.google.com with SMTP id k12so19669663qtf.7; Fri, 11 Jan 2019 09:33:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlXu3O61pUFPLleZ5AMTVxcoWeFNM1mKAK5t7dNAM0o=; b=TP6DXAT3p1j+5A4u4m4BFvUWImSq5n0+2KSpQfsyhkr4kzNAR0Hc/VviiTXMFXtGMX ncYTHe5C53FZ3ATUHerV/9xB4taaYdLvbYfh6QFfS0V15aCXvZ1whAz4Lgk5UdQVZYgX pT7hiCbeRq/SmxjhCvJst8noet5IY6sEC3J86P8YQB2UvoZPo6mGMioKsNYGocdS89xY lnnmssGTiGTglHiIS9nFsPGkx3QskIMkc/kCNP+wcCoHcVd60YuYfv+5TM/qqogRJGxR C2xSeo4AuVNzeljmhVa9RGLSL18Ao7ExyUfgm4bdTAVI6F/XPYE2Kfm09IHOM9Mitbdp avtw== X-Gm-Message-State: AJcUukdxwi0KkcGe0N5/5c/JvYJ2QRtML6xS9Q7mlHTMkc5i9pWE59WI Dp66nzV7PKgISL6QqEYhF8Ns0mShDHfZMQICuw4= X-Received: by 2002:ac8:1d12:: with SMTP id d18mr14381544qtl.343.1547228002113; Fri, 11 Jan 2019 09:33:22 -0800 (PST) MIME-Version: 1.0 References: <20190110162435.309262-1-arnd@arndb.de> <20190110162435.309262-15-arnd@arndb.de> <20190110203253.GA3676@osiris> In-Reply-To: <20190110203253.GA3676@osiris> From: Arnd Bergmann Date: Fri, 11 Jan 2019 18:33:05 +0100 Message-ID: Subject: Re: [PATCH 14/15] arch: add split IPC system calls where needed To: Heiko Carstens Cc: y2038 Mailman List , Linux API , Linux Kernel Mailing List , Ivan Kokshaysky , Matt Turner , Russell King - ARM Linux , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Michal Simek , Paul Burton , Helge Deller , Michael Ellerman , Martin Schwidefsky , Rich Felker , David Miller , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "the arch/x86 maintainers" , Max Filippov , Firoz Khan , "Eric W . Biederman" , Deepa Dinamani , Dominik Brodowski , Andrew Morton , Davidlohr Bueso , alpha , Linux ARM , linux-ia64@vger.kernel.org, linux-m68k , linux-mips@vger.kernel.org, Parisc List , linuxppc-dev , linux-s390 , Linux-sh list , sparclinux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 10, 2019 at 9:33 PM Heiko Carstens wrote: > On Thu, Jan 10, 2019 at 05:24:34PM +0100, Arnd Bergmann wrote: > > diff --git a/arch/s390/kernel/syscalls/syscall.tbl b/arch/s390/kernel/syscalls/syscall.tbl > > index 022fc099b628..428cf512a757 100644 > > --- a/arch/s390/kernel/syscalls/syscall.tbl > > +++ b/arch/s390/kernel/syscalls/syscall.tbl > > @@ -391,3 +391,15 @@ > > 381 common kexec_file_load sys_kexec_file_load compat_sys_kexec_file_load > > 382 common io_pgetevents sys_io_pgetevents compat_sys_io_pgetevents > > 383 common rseq sys_rseq compat_sys_rseq > > +# room for arch specific syscalls > > +392 64 semtimedop sys_semtimedop - > > +393 common semget sys_semget sys_semget > ... > > +395 common shmget sys_shmget sys_shmget > ... > > +398 common shmdt sys_shmdt sys_shmdt > > +399 common msgget sys_msgget sys_msgget > > These four need compat system call wrappers, unfortunately... (well, > actually only shmget and shmdt require them, but let's add them for > all four). See arch/s390/kernel/compat_wrapper.c > > I'm afraid this compat special handling will be even more annoying in > the future, since s390 will be the only architecture which requires > this special handling. > > _Maybe_ it would make sense to automatically generate a weak compat > system call wrapper for s390 with the SYSCALL_DEFINE macros, but that > probably won't work in all cases. For some reason I was under the impression that s390 already did that. However, it seems that x86 does, so I'll try to convert the x86 version for s390, and see if I can get rid of all the wrappers that way. It would certainly be safer to have the wrappers always present, especially if we expect future system calls to be added to the s390 table by whoever implements the syscall itself. Arnd