Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp996867imu; Fri, 11 Jan 2019 12:59:16 -0800 (PST) X-Google-Smtp-Source: ALg8bN7jFna0niKxn6FwCTahK40lVdixy56QYdd53b3uIOplgEb/IH4becWVmZVbtP8iqtwQIpBG X-Received: by 2002:a17:902:7005:: with SMTP id y5mr16255101plk.7.1547240356717; Fri, 11 Jan 2019 12:59:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547240356; cv=none; d=google.com; s=arc-20160816; b=qKA4w7PyphVrl9D+lfBcLJtlLND9FgbMEkURCOlQjwD9HDCL3hG+NEUhQyhYDDkv4h 12wJvkVVqAX5mv2pnLOLAQ+hmTMOth2arcuvvq+x1U6FMLMiX+eDZnxxTqYca1bQ5ued vssO47yl/GjGCy49iG6huzaRsx8KJ+rWBFfN5lXKDU5tES8t5kL0VY0nDETvRJM5lD18 eWfqMZfjzCivqV7TOoE8xSky+lkWnrTn3MGn16EIndS+tumqWsd1eiOvcXM1qz2PoQJo DM2OCg4NiTGvl+FtfskrFb8GXrv0GB8k2lprcnv3RCZTVL0DQ/rJxBdQTJD5cykpL5qR DsFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=/faNOUmzdO023/qiPPvya8217BgcMHSLrRb/VXt8ZY4=; b=f7zh+3V1iNDjfQHEKpKJGTchItJjtrWcWX10RqvUR7b7wahVfaZwetfsIL4Rzic+Q0 hfQZt/p+Z5ObHJCuPYMLdm7DJxc40ZJVixG43AQQjNJ/BS0/XMimkAkKS1PC0/XWofpf aHn2hZsXrjpCurqj3dCUVG2epYOvyg0h7ZZjlHH6DxP9m06lporBb5IwcVjBJqG5LwyQ 3QPpcsm6pHDVnzgwrDTUMS+0M+9aN8iYHizMEuCvnm6HbgH++j/8vOvY0hbqR6BL/RCb xSfaodI+vK1aKfOFRP4z29KzYWBp52/2qU5ObSDe9JoXYFB6/dHXBvdMACYhti5/8Med 3Kjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=gdPVx15h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si30040025plo.435.2019.01.11.12.59.01; Fri, 11 Jan 2019 12:59:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=gdPVx15h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387848AbfAKSMk (ORCPT + 99 others); Fri, 11 Jan 2019 13:12:40 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:46420 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727745AbfAKSMk (ORCPT ); Fri, 11 Jan 2019 13:12:40 -0500 Received: by mail-qt1-f196.google.com with SMTP id y20so19781753qtm.13 for ; Fri, 11 Jan 2019 10:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=/faNOUmzdO023/qiPPvya8217BgcMHSLrRb/VXt8ZY4=; b=gdPVx15hHseBGGCZOUdjz0yeoaTlruoMNKfOAXWY+xRYvGd7sRhEtmR7NS9tSXFIkj qf3QC6D3nDGGG2IrhJ6aZ3noFrzA0/Svo5blkzb1wp6ll6CEhfYFrkDwibLKmaIPuSid LMoTLg9abUVZpSPA/6aGZHe+RovRlwueS0WT2cytsnIqjsbyG/j1ZIF46qiOs3UbbxJl 3W27aMYcQ0z+X1ZchE5F5M5c9D0DQUnt37Lq9Q5RUPjcbBdQDiatVqfLmvs0vnwr6puL sKDfG2LTl3NWbJW+f4ifsBf8sKNLw1kHHeSA2fPNUA/BoU/eVwzedJ1vKWHB0pmp+K5G M4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=/faNOUmzdO023/qiPPvya8217BgcMHSLrRb/VXt8ZY4=; b=sYiI5A7A3jl+/3Yf8SENVYVURKVD/VdvTkm8/vGv9tGI6D6u1bcyda4U7hK/VObqD8 4Di9fR6wULq2CeNrJlYdJUvtTgClbmd7F1LoSlKeXUxBVK4ElPavyJgNu76yUgg4aODj q9GwZXpjRdJ15FyZF9nFtbhyI3asGGoJLmV+Xsk+Ecgng3UG9w4OE9PzvXP6URpRaClD NHguv8uL6IRFQyL7bOasMcs4cAlivJ7rhd0GjHmYR/6QcrwLhogJYOWMo5LHfyXogMwV b2+lamGEcVK4YnzIw/8K4g0z1Q3hc9UlDQqoiAnpQl14wn8AZIis65WgZdjvrw1NZLmv nt5w== X-Gm-Message-State: AJcUukeb8oYBQ7r7WnVorRqwhFI6iZBV/CnvjEVvQwbjo0+dCf1JvgXa JcTCm8/lH5UYA4lSq6hYWLZRoQ== X-Received: by 2002:aed:26e1:: with SMTP id q88mr14659000qtd.148.1547230358612; Fri, 11 Jan 2019 10:12:38 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id w52sm47628307qtc.51.2019.01.11.10.12.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Jan 2019 10:12:38 -0800 (PST) Message-ID: <1547230356.6911.23.camel@lca.pw> Subject: Re: [PATCH] rbtree: fix the red root From: Qian Cai To: Matthew Wilcox Cc: akpm@linux-foundation.org, esploit@protonmail.ch, jejb@linux.ibm.com, dgilbert@interlog.com, martin.petersen@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, walken@google.com, David.Woodhouse@intel.com Date: Fri, 11 Jan 2019 13:12:36 -0500 In-Reply-To: <20190111173132.GH6310@bombadil.infradead.org> References: <20190111165145.23628-1-cai@lca.pw> <20190111173132.GH6310@bombadil.infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-01-11 at 09:31 -0800, Matthew Wilcox wrote: > On Fri, Jan 11, 2019 at 11:51:45AM -0500, Qian Cai wrote: > > Reported-by: Esme > > Signed-off-by: Qian Cai > > What change introduced this bug?  We need a Fixes: line so the stable > people know how far to backport this fix. It looks like, Fixes: 6d58452dc06 (rbtree: adjust root color in rb_insert_color() only when necessary) where it no longer always paint the root as black. Also, copying this fix for the original author and reviewer. https://lore.kernel.org/lkml/20190111165145.23628-1-cai@lca.pw/