Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1003764imu; Fri, 11 Jan 2019 13:06:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN7VuJkF8j9Vi3iJczBoHEBNEsy3gETUZKdPb5dUDG2o8c0xxVLUREql2sFA2OAE/j+iqrHP X-Received: by 2002:a63:dd15:: with SMTP id t21mr12104874pgg.347.1547240785161; Fri, 11 Jan 2019 13:06:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547240785; cv=none; d=google.com; s=arc-20160816; b=SICb1ZoYLAKsyAMzBkuxu+d4MW8tCxzK2OGqUBSXr0sGQ9pr0Py0iJI62trshF56Ge RD4kPx+0tNzAf5Xe0Uzd5Ym+74dKjrkJG0tUnok6eGCGkmU37R9GJ94Zzs1S/ZBsM4Ny AwsP2d2cZoP8Ml9GyjsbWW/wN0pYKIOD9IWm7GVtB0SEomxJddJUTK5ITvbYGAfTvdsz +804gtyctAziFdAouXPA853/qbRlLYB7CakPkC5NQopZ/Jn0sIHa8wXtneSD9Qq95hQR ej7Zi7oMgf7wgR6PtsfalTjUO49Y7cM3eKZONNN5XnnhMaMst04MaWQ06K7EJY95CQGf pmqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=vJobNwacwqELFSn9sezgDxi723fb3GrAhFS+Ypv4NN0=; b=OuDZrZ6fvbKOwYaOOOQtDsaKMyFeHe6bFr7zkoSgTrW/5y7Sfl/jMlmWv6CXKPOtBa Gx42uRLoA0Qocern/J3gnbGBxvJ7M7OK+zuo/vgsN1V2uYnejpCJp9V/YUZu8BF/ddgW Q1A+kQ3r5BDCwEHW+gvyywB/ZY7t1dNwRpaEm4ioouDSXgMWaygDXsPBP3+4QWFZfleS WVxlkjkpDdJmXXDQwlInO++/W34NGiJUAb3xYlmOzwePk1IiyGyTLmmE0jlb6TltVxg5 kYG4HyWOLnYRThTk7P4dmXENY2xvOBo0d7VZR9nsaZTZEEdAfolcc/DdUJYRy59KtckL 8LTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="Ba0/9Wyt"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h10si5094806pgi.562.2019.01.11.13.06.09; Fri, 11 Jan 2019 13:06:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="Ba0/9Wyt"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388318AbfAKTeb (ORCPT + 99 others); Fri, 11 Jan 2019 14:34:31 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33653 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730371AbfAKTeb (ORCPT ); Fri, 11 Jan 2019 14:34:31 -0500 Received: by mail-pf1-f193.google.com with SMTP id c123so7417543pfb.0 for ; Fri, 11 Jan 2019 11:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=vJobNwacwqELFSn9sezgDxi723fb3GrAhFS+Ypv4NN0=; b=Ba0/9WytPW7bVkcWE8ZByDPjWX+8iuvKJ8Ll6FzmDBgj6GlssfqK8Rtn5Ib6+2Vjh8 1dwseXgEvshMmw0Vz6Yg0ijhEObsrEdFKFdL7yPDKxhXEjhiM8kUQ+DVpa1WYRrHx0tC 4tiB8cYT2JP5R50Y5k4GZ2QBNI/zQWk0ZgpazKIeyMBVk4QcIT6Q+b3BcapojBQaAi9i PerxhLbcjH2kYCSqKozP3CwRH1yknwqi4xbopth9XBH8hUWDux811FPFfBH2vSAOTi1a dtMwU/nx0bIz7N0duoK53NId5Ib7KkV60MUv8kwnMMyN0LLmeyY1db0uQbMMjvM5vB3q wnLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=vJobNwacwqELFSn9sezgDxi723fb3GrAhFS+Ypv4NN0=; b=rslIxFLTugljbis6AbDuxwv+2Pu7TFNEZ6D4/OCsvUZAWfM+o45AUs0jsKXg0PUg/s WyIvO8mONJ0zON8F7VAx4xDogNaFXgWe/06AMPa3CjDKcEu09V1GxZJa8lQuD930AiH0 W7VXHlKYS6DScBne2/s4B/XJbZDC+875f4twrLjra4sbSzOUulmBPFHfvL0jF2xCB3nj Cc+CkPsLkbVz1KCklOeeoQs/WdITGQhOa84RwrRPBcFi27xxGobmpW89QjnGqc9TqK0z WG++EW5dXRTNWGlBqLXCaSjvxQGVmrfTFWWKMJOv0VlLJIBlYWzWg06p2CRbipKVx7Kh nlhw== X-Gm-Message-State: AJcUukfB3CsrBxijXHUVm7HBVlAsvgQN4c5pkL/iwGNOrIkO/8eg9F44 PzFhk5euB5/CGP/hh6vSqjFZGw== X-Received: by 2002:a62:220d:: with SMTP id i13mr15707191pfi.162.1547235270148; Fri, 11 Jan 2019 11:34:30 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.googlemail.com with ESMTPSA id 125sm102764027pfg.39.2019.01.11.11.34.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 11:34:29 -0800 (PST) From: Kevin Hilman To: Dmitry Vyukov , Sergey Senozhatsky , Tetsuo Handa Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Andrew Morton , LKML , syzkaller , Fengguang Wu Subject: Re: [PATCH] printk: Add caller information to printk() output. In-Reply-To: References: <20181204152724.ypk44mi4a56nrud4@pathway.suse.cz> <459018db-763b-9520-ead2-2c0d5975fbf3@i-love.sakura.ne.jp> <20181210130930.bas4fozjhe3dc5nu@pathway.suse.cz> <20181213121847.mwlr2vyv6qzclhk6@pathway.suse.cz> <20181213124255.GB3053@tigerII.localdomain> <20181217145452.3kev4rmo2l5lt2qy@pathway.suse.cz> <93f19e57-5051-c67d-9af4-b17624062d44@i-love.sakura.ne.jp> <20181218083911.qxvlqlwlb4eye72x@pathway.suse.cz> <20181218085833.GA460@jagdpanzerIV> Date: Fri, 11 Jan 2019 11:34:28 -0800 Message-ID: <7h4lafng3f.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitry Vyukov writes: > On Wed, Jan 2, 2019 at 5:09 PM Dmitry Vyukov wrote: >> >> On Tue, Dec 18, 2018 at 9:58 AM Sergey Senozhatsky >> wrote: >> > >> > On (12/18/18 09:39), Petr Mladek wrote: >> > > >> > > Sergey, are you okay with this squashed patch, please? >> > > >> > >> > Yeah. There are several minor nitpicks, but here is my >> > Acked-by: Sergey Senozhatsky >> > >> > >> > One final question - can syzbot folks confirm that the patch >> > helps? Just curious. >> >> This slip through the cracks. Tetsuo pinged me and I am testing now. >> Need to create a set of tests and update parsing code to handle this. > > I've pushed support for CONFIG_PRINTK_CALLER to syzkaller/syzbot: > https://github.com/google/syzkaller/commit/7da2392541a49c3f17b2e7d24e04b84d72b965fb > Let's see what happens. Limited local testing shows that it's working > as intended and significatly improves quality of reports and ability > to make sense out of kernel output. > > Tetsuo, thanks for your great persistence with this change! > Sergey, Petr, thanks for reviews! > > +Fengguang, Kevin, maybe you will find this useful for 0-day/kernel-ci. Yes, will definitely give it a try. Kevin