Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1031934imu; Fri, 11 Jan 2019 13:42:10 -0800 (PST) X-Google-Smtp-Source: ALg8bN5/IQ9d7SpI08U3S12kGHDLkqNTESn7hZForO0wtGUnVKmfpA74F5uu3SQxKbhIvlmO6jO/ X-Received: by 2002:a63:b30f:: with SMTP id i15mr14932508pgf.240.1547242930779; Fri, 11 Jan 2019 13:42:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547242930; cv=none; d=google.com; s=arc-20160816; b=nGiaJIhdWmV/IpWBnxUDwkmm2hx22mm8K9xjn9uuoI9CrAS16ijQli/MsIP+/0nyHO kkdGK6z3HwY8fX1+DvCrng/gAFlwQbGqovIpSp4awO+OinWU3H5OOsMo7BTrwgxkuaXn Jprsb9fxuIG4pUssiLEQMJgMFnZ/lLi7cuDuPeO/HyruezqRredX0TLAA3kK8r8HpMMV eGIh5OwOEWNQRsk1VwhdGPUB6r3kc9PhofyUEFu9XVVQz/g3i2bWQ5L+kSV+qwamIX3k Zu26lHTIPkVvtEBGpZsPH7FsKIk8ErAOsibqahq7WGpYswcRpR1z9J0gPnclB5ETh0gP /Jxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=q1Z1C8lxlNci4ePMWZvCZ09GNOuH4Pdgo3/N2N4HRFY=; b=Lcy4NKQK2UgJTyn8vRuQVSmkt76vD/C6JPog9rrPwlYearLzyf1kUu1hU3EoRsy0T5 3/JtPBnNccQXRKZg/oGef67DpV55P8Wk5Wl3DaHxOJ0eeAELBQ+7auEPynupR3naHZJu +gswOEo56Dp17OlpQ/G1bEAZUVnEIDcbagAnRmkzLxlOo19CRJAkNrUfjRc9xSPUf/3X +2IC57X8Ojl62HFFMOj2n8gcQ5OGnCLNoZGnH2jLyqRUswBhAvz4BCnQcxgg/mvFC3su 9ig5pTxMvGXCaMqOOOcJ4cneOoTcicjB5qcN7zUqwHciea7O4GwSOvMyZari8ZvDV0cw XiVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c17si2143054pgl.385.2019.01.11.13.41.55; Fri, 11 Jan 2019 13:42:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388332AbfAKQ7j convert rfc822-to-8bit (ORCPT + 99 others); Fri, 11 Jan 2019 11:59:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56696 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730633AbfAKQ7i (ORCPT ); Fri, 11 Jan 2019 11:59:38 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A7BF7FDE9; Fri, 11 Jan 2019 16:59:38 +0000 (UTC) Received: from llong.remote.csb (ovpn-124-242.rdu2.redhat.com [10.10.124.242]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D935411B; Fri, 11 Jan 2019 16:59:36 +0000 (UTC) Subject: Re: Question about qspinlock nest To: Zhenzhong Duan , LKML Cc: Peter Zijlstra , SRINIVAS References: <910e9fb6-d0df-4711-fe2b-244b3c20eb82@redhat.com> <2eca6f60-3e8b-a389-27cb-8adbd9676607@oracle.com> From: Waiman Long Openpgp: preference=signencrypt Autocrypt: addr=longman@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFgsZGsBEAC3l/RVYISY3M0SznCZOv8aWc/bsAgif1H8h0WPDrHnwt1jfFTB26EzhRea XQKAJiZbjnTotxXq1JVaWxJcNJL7crruYeFdv7WUJqJzFgHnNM/upZuGsDIJHyqBHWK5X9ZO jRyfqV/i3Ll7VIZobcRLbTfEJgyLTAHn2Ipcpt8mRg2cck2sC9+RMi45Epweu7pKjfrF8JUY r71uif2ThpN8vGpn+FKbERFt4hW2dV/3awVckxxHXNrQYIB3I/G6mUdEZ9yrVrAfLw5M3fVU CRnC6fbroC6/ztD40lyTQWbCqGERVEwHFYYoxrcGa8AzMXN9CN7bleHmKZrGxDFWbg4877zX 0YaLRypme4K0ULbnNVRQcSZ9UalTvAzjpyWnlnXCLnFjzhV7qsjozloLTkZjyHimSc3yllH7 VvP/lGHnqUk7xDymgRHNNn0wWPuOpR97J/r7V1mSMZlni/FVTQTRu87aQRYu3nKhcNJ47TGY evz/U0ltaZEU41t7WGBnC7RlxYtdXziEn5fC8b1JfqiP0OJVQfdIMVIbEw1turVouTovUA39 Qqa6Pd1oYTw+Bdm1tkx7di73qB3x4pJoC8ZRfEmPqSpmu42sijWSBUgYJwsziTW2SBi4hRjU h/Tm0NuU1/R1bgv/EzoXjgOM4ZlSu6Pv7ICpELdWSrvkXJIuIwARAQABzR9Mb25nbWFuIExv bmcgPGxsb25nQHJlZGhhdC5jb20+wsF/BBMBAgApBQJYLGRrAhsjBQkJZgGABwsJCAcDAgEG FQgCCQoLBBYCAwECHgECF4AACgkQbjBXZE7vHeYwBA//ZYxi4I/4KVrqc6oodVfwPnOVxvyY oKZGPXZXAa3swtPGmRFc8kGyIMZpVTqGJYGD9ZDezxpWIkVQDnKM9zw/qGarUVKzElGHcuFN ddtwX64yxDhA+3Og8MTy8+8ZucM4oNsbM9Dx171bFnHjWSka8o6qhK5siBAf9WXcPNogUk4S fMNYKxexcUayv750GK5E8RouG0DrjtIMYVJwu+p3X1bRHHDoieVfE1i380YydPd7mXa7FrRl 7unTlrxUyJSiBc83HgKCdFC8+ggmRVisbs+1clMsK++ehz08dmGlbQD8Fv2VK5KR2+QXYLU0 rRQjXk/gJ8wcMasuUcywnj8dqqO3kIS1EfshrfR/xCNSREcv2fwHvfJjprpoE9tiL1qP7Jrq 4tUYazErOEQJcE8Qm3fioh40w8YrGGYEGNA4do/jaHXm1iB9rShXE2jnmy3ttdAh3M8W2OMK 4B/Rlr+Awr2NlVdvEF7iL70kO+aZeOu20Lq6mx4Kvq/WyjZg8g+vYGCExZ7sd8xpncBSl7b3 99AIyT55HaJjrs5F3Rl8dAklaDyzXviwcxs+gSYvRCr6AMzevmfWbAILN9i1ZkfbnqVdpaag QmWlmPuKzqKhJP+OMYSgYnpd/vu5FBbc+eXpuhydKqtUVOWjtp5hAERNnSpD87i1TilshFQm TFxHDzbOwU0EWCxkawEQALAcdzzKsZbcdSi1kgjfce9AMjyxkkZxcGc6Rhwvt78d66qIFK9D Y9wfcZBpuFY/AcKEqjTo4FZ5LCa7/dXNwOXOdB1Jfp54OFUqiYUJFymFKInHQYlmoES9EJEU yy+2ipzy5yGbLh3ZqAXyZCTmUKBU7oz/waN7ynEP0S0DqdWgJnpEiFjFN4/ovf9uveUnjzB6 lzd0BDckLU4dL7aqe2ROIHyG3zaBMuPo66pN3njEr7IcyAL6aK/IyRrwLXoxLMQW7YQmFPSw drATP3WO0x8UGaXlGMVcaeUBMJlqTyN4Swr2BbqBcEGAMPjFCm6MjAPv68h5hEoB9zvIg+fq M1/Gs4D8H8kUjOEOYtmVQ5RZQschPJle95BzNwE3Y48ZH5zewgU7ByVJKSgJ9HDhwX8Ryuia 79r86qZeFjXOUXZjjWdFDKl5vaiRbNWCpuSG1R1Tm8o/rd2NZ6l8LgcK9UcpWorrPknbE/pm MUeZ2d3ss5G5Vbb0bYVFRtYQiCCfHAQHO6uNtA9IztkuMpMRQDUiDoApHwYUY5Dqasu4ZDJk bZ8lC6qc2NXauOWMDw43z9He7k6LnYm/evcD+0+YebxNsorEiWDgIW8Q/E+h6RMS9kW3Rv1N qd2nFfiC8+p9I/KLcbV33tMhF1+dOgyiL4bcYeR351pnyXBPA66ldNWvABEBAAHCwWUEGAEC AA8FAlgsZGsCGwwFCQlmAYAACgkQbjBXZE7vHeYxSQ/+PnnPrOkKHDHQew8Pq9w2RAOO8gMg 9Ty4L54CsTf21Mqc6GXj6LN3WbQta7CVA0bKeq0+WnmsZ9jkTNh8lJp0/RnZkSUsDT9Tza9r GB0svZnBJMFJgSMfmwa3cBttCh+vqDV3ZIVSG54nPmGfUQMFPlDHccjWIvTvyY3a9SLeamaR jOGye8MQAlAD40fTWK2no6L1b8abGtziTkNh68zfu3wjQkXk4kA4zHroE61PpS3oMD4AyI9L 7A4Zv0Cvs2MhYQ4Qbbmafr+NOhzuunm5CoaRi+762+c508TqgRqH8W1htZCzab0pXHRfywtv 0P+BMT7vN2uMBdhr8c0b/hoGqBTenOmFt71tAyyGcPgI3f7DUxy+cv3GzenWjrvf3uFpxYx4 yFQkUcu06wa61nCdxXU/BWFItryAGGdh2fFXnIYP8NZfdA+zmpymJXDQeMsAEHS0BLTVQ3+M 7W5Ak8p9V+bFMtteBgoM23bskH6mgOAw6Cj/USW4cAJ8b++9zE0/4Bv4iaY5bcsL+h7TqQBH Lk1eByJeVooUa/mqa2UdVJalc8B9NrAnLiyRsg72Nurwzvknv7anSgIkL+doXDaG21DgCYTD wGA5uquIgb8p3/ENgYpDPrsZ72CxVC2NEJjJwwnRBStjJOGQX4lV1uhN1XsZjBbRHdKF2W9g weim8xU= Organization: Red Hat Message-ID: <4b43a3d1-a8f6-3ea7-7c32-b230d9fd0782@redhat.com> Date: Fri, 11 Jan 2019 08:59:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2eca6f60-3e8b-a389-27cb-8adbd9676607@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 11 Jan 2019 16:59:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2019 12:06 AM, Zhenzhong Duan wrote: > > > On 2019/1/10 22:43, Waiman Long wrote: >> On 01/10/2019 03:02 AM, Zhenzhong Duan wrote: >>> Hi Maintainer, >>> >>> >>> There is a question confused me for days. Appreciate an answer. >>> >>> In below code, the comment says we never have more than 4 nested >>> contexts. >>> >>> What happen if debug and mce exceptions nest with the four, or we >>> ensure it never happen? >>> >>> >>> /* >>>  * Per-CPU queue node structures; we can never have more than 4 nested >>>  * contexts: task, softirq, hardirq, nmi. >>>  * >>>  * Exactly fits one 64-byte cacheline on a 64-bit architecture. >>>  * >>>  * PV doubles the storage and uses the second cacheline for PV state. >>>  */ >>> static DEFINE_PER_CPU_ALIGNED(struct qnode, qnodes[MAX_NODES]); >>> >> Yes, both debug and mce exceptions are some kind of NMIs. So >> theoretically, it is possible to have more than four. Are you aware of >> any debug and MCE exception handlers that need to take a spinlock for >> synchronization? > Not for debug exception, for MCE exception handler I found below two: > > do_machine_check->mce_report_event->schedule_work > do_machine_check->force_sig->force_sig_info > > schedule_work() and force_sig_info() take spinlocks. > -- > Thanks > Zhenzhong The comment for do_machine_scheck() has already state that:  * This is executed in NMI context not subject to normal locking rules. This  * implies that most kernel services cannot be safely used. Don't even  * think about putting a printk in there! So even if it doesn't exceed the MAX_NODES limit, it could hit deadlock and other kind of locking hazards. So supporting MCE is not a reason strong enough to extend MAX_NODES. In hindsight, we should have added a "BUG_ON(idx >= MAX_NODES);" check to avoid silent corruption because of that issue. Thanks, Longman