Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1032643imu; Fri, 11 Jan 2019 13:43:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN6+Ajg6NxCOZ/mUON9jZJEkxN6WF3IMs9h65V0ZFqdI01loUnAS+BAHQl4DRw6YAmcI6hIG X-Received: by 2002:a62:2b8b:: with SMTP id r133mr16171292pfr.246.1547242995009; Fri, 11 Jan 2019 13:43:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547242994; cv=none; d=google.com; s=arc-20160816; b=k5C3ejwwooTX74txHLwQtFEZyLkhovjwPGva01ilTwH9d3IyJCwfFnxL/0kvDuzzOH cU5eKI4u22e5mFXAJe+UYjUpGhQQhmWr0dK1kOHhm27havrM1PVu5h0qhp+Y8aBDVn4m PSr1UCM7lkspLkH461MGwWogX3CkMvVxTIsPGdfw5w5+aRgcYIFXDRC//FdAcBg9aRDm 5MrMjJOHMUmjLJwmwouxi1fRAX02ekekP4yhCWCJli4pAgOx2tq/TttBdDjLsUkwJC76 9WgRdzqUtiNHT7hrc4rfFIqNMPx8hhVsLfP3XonX2g5e/sOOobN3dB4pjjXnzRjhBsKQ U3Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=6QG1xakbsxzM6o4tWXlcEuPeHACoyQTbTqTdukqt2pg=; b=BSlf2kX9cao6FHJ5uUZEaU/Fk7nlkXZEit3fkUmM39fOL8YtlZF3Yo48urCgqtdpqf slpZKRBjzs9kxIwTa6qQ4ZVza7nQ1BbHybIczB4+Ah/IlqdRyCkKQ99KNLZM00R223YK UbH85CN9MKAry8YK1NquvNfVnGBwEDC2U9KtZgRBFzvdCz4j+iDHJ4uwhHXnhTzm+E93 S8sQTlsqAVSagkjwGdWRhjW465w58DY9lglhMRDP3oSALatx3W4vc2Sl3UWi703KS1bR OdXXL6UjT66UeykRE1DOqm/rbqFm3zaM3iX6rpuhSOFsK7vuhSkQFSSC7V94yBQAGexy 58rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si12714374pgm.212.2019.01.11.13.42.59; Fri, 11 Jan 2019 13:43:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390184AbfAKSqd (ORCPT + 99 others); Fri, 11 Jan 2019 13:46:33 -0500 Received: from relay.sw.ru ([185.231.240.75]:41754 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728927AbfAKSqd (ORCPT ); Fri, 11 Jan 2019 13:46:33 -0500 Received: from [172.16.25.12] by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gi1p6-0006fL-JJ; Fri, 11 Jan 2019 21:46:28 +0300 Subject: Re: [PATCH] kasan: fix kasan_check_read/write definitions To: Arnd Bergmann , Andrew Morton Cc: Anders Roxell , Ard Biesheuvel , Will Deacon , Mark Rutland , Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , Stephen Rothwell , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20181211133453.2835077-1-arnd@arndb.de> From: Andrey Ryabinin Message-ID: <478333ec-1866-2908-1111-8b3dda135278@virtuozzo.com> Date: Fri, 11 Jan 2019 21:46:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20181211133453.2835077-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/18 4:34 PM, Arnd Bergmann wrote: > Building little-endian allmodconfig kernels on arm64 started failing > with the generated atomic.h implementation, since we now try to call > kasan helpers from the EFI stub: > > aarch64-linux-gnu-ld: drivers/firmware/efi/libstub/arm-stub.stub.o: in function `atomic_set': > include/generated/atomic-instrumented.h:44: undefined reference to `__efistub_kasan_check_write' > > I suspect that we get similar problems in other files that explicitly > disable KASAN for some reason but call atomic_t based helper functions. > > We can fix this by checking the predefined __SANITIZE_ADDRESS__ macro > that the compiler sets instead of checking CONFIG_KASAN, but this in turn > requires a small hack in mm/kasan/common.c so we do see the extern > declaration there instead of the inline function. > > Fixes: b1864b828644 ("locking/atomics: build atomic headers as required") > Reported-by: Anders Roxell > Signed-off-by: Arnd Bergmann > --- Acked-by: Andrey Ryabinin