Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1221976imu; Fri, 11 Jan 2019 17:59:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN6+KGXXgVyyNRaK67KuhpbfImYMmmudHtpofl/Ht5iOeYFxO+Y2MRRMF0Bm//JqsFWfe0oe X-Received: by 2002:a63:d547:: with SMTP id v7mr5286833pgi.339.1547258369768; Fri, 11 Jan 2019 17:59:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547258369; cv=none; d=google.com; s=arc-20160816; b=F22srQO4Xx5xtDTh74/q93BfZeompVuZwatC3KJ8xcibQWhLyr1ZK8jSSOv/8d+PwI wpovH7o5teLfIDHahee6FR+4gVk2Q3YhFF+wrcRIKdilT0/D4Y9W2YRdutr47VMyjJsK +EKeYdEgZ1bdWVPBr/IYFn5ISqvy77oPD0vSOBMXqFWclIw8vkGuQOCkrPDdSVmGj27T B9svI0MMzZC9nNcYrHgTUuROe9mbwNcDb9qMJe8M3vwlCjLG3FRweNqp0PhnKwugJhWL Y5JDAafx1pNSFsD+4LddBqNzwfPPXUw6Lrh2Zgu2Wq5tTS5AvJuGFfgfI+fzsM7k59q9 QmjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=t6BosrICfO12f5oORCf74RxtwlRVDRlydkhPsnXGex4=; b=GIV9mFilI0hD0r9S15lxmH9B67v2z409H7J/P4Qvqw1Advyr9S2GakXm/3C/Sjuvl/ 1HtMF3G6k8bpXpbPBv8qZX8yfisjHB14/LiK4gg2TggrWGmzTGuz5o4OIkTQrGf+6meA VLDkhkcRtxlOgqGNPFE8OaMWw6LN5R/7MEoG2mPnOBF5U1eIFvtUjeEMZ4gzhlc7NG1i mLaRLUzn7doNmgQCHXAZmK0GacxuwF+Oej6gdBiUDEkUXErEsVxHgtVcBCpEODxEO6YI FkkDRIF1y+bTHFWws6BQwITOK2HTzniAyZVGbyIkkZqGXs21sSvNooZGpUgx0J+zwP2R lHqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si78783818pfg.78.2019.01.11.17.59.13; Fri, 11 Jan 2019 17:59:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbfALB5N (ORCPT + 99 others); Fri, 11 Jan 2019 20:57:13 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:39538 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfALB5N (ORCPT ); Fri, 11 Jan 2019 20:57:13 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 324FF14CCB476; Fri, 11 Jan 2019 17:57:12 -0800 (PST) Date: Fri, 11 Jan 2019 17:57:11 -0800 (PST) Message-Id: <20190111.175711.1689272658462652060.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: isdn@linux-pingi.de, viro@zeniv.linux.org.uk, linux@roeck-us.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] isdn: i4l: isdn_tty: Fix some concurrency double-free bugs From: David Miller In-Reply-To: <20190108130448.22102-1-baijiaju1990@gmail.com> References: <20190108130448.22102-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 11 Jan 2019 17:57:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Tue, 8 Jan 2019 21:04:48 +0800 > The functions isdn_tty_tiocmset() and isdn_tty_set_termios() may be > concurrently executed. ... > These possible bugs are found by a static tool written by myself and > my manual code review. > > To fix these possible bugs, the mutex lock "modem_info_mutex" used in > isdn_tty_tiocmset() is added in isdn_tty_set_termios(). > > Signed-off-by: Jia-Ju Bai Applied.