Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190104192410.GA11084@jordon-HP-15-Notebook-PC>
In-Reply-To: <20190104192410.GA11084@jordon-HP-15-Notebook-PC>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Mon, 14 Jan 2019 09:58:45 +0530
Message-ID: <CAFqt6zYC+cNLCPCjuQaodOBkdJH3GzKOtpnkV2YfSvXwGVZ9GA@mail.gmail.com>
Subject: Re: [PATCH] fs/dax: Convert to use vmf_error()
To:     Matthew Wilcox <willy@infradead.org>, zwisler@kernel.org,
        Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>
Cc:     linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jan 5, 2019 at 12:50 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> This code is converted to use vmf_error().
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Any comment on this patch ?
> ---
>  fs/dax.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 48132ec..ed39161 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
>  {
>         if (error == 0)
>                 return VM_FAULT_NOPAGE;
> -       if (error == -ENOMEM)
> -               return VM_FAULT_OOM;
> -       return VM_FAULT_SIGBUS;
> +       return vmf_error(error);
>  }
>
>  /*
> --
> 1.9.1
>