Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in
 scsi_host_template
To:     Nathan Chancellor <natechancellor@gmail.com>,
        Jens Axboe <axboe@kernel.dk>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
        "Manoj N. Kumar" <manoj@linux.ibm.com>,
        "Matthew R. Ochs" <mrochs@linux.ibm.com>,
        Uma Krishnan <ukrishn@linux.ibm.com>,
        Bradley Grove <linuxdrivers@attotech.com>,
        Don Brace <don.brace@microsemi.com>,
        Brian King <brking@us.ibm.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        esc.storagedev@microsemi.com,
        Nick Desaulniers <ndesaulniers@google.com>,
        Joel Stanley <joel@jms.id.au>
References: <20181020050143.589-1-natechancellor@gmail.com>
 <20190114044206.6351-1-natechancellor@gmail.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <c1f7f039-04b2-a660-2408-8d4ac0ea63c4@acm.org>
Date:   Sun, 13 Jan 2019 20:54:35 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <20190114044206.6351-1-natechancellor@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/13/19 8:42 PM, Nathan Chancellor wrote:
> @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg)
>   	ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl));
>   	if (IS_ERR(ioctl)) {
>   		esas2r_log(ESAS2R_LOG_WARN,
> -			   "ioctl_handler access_ok failed for cmd %d, "
> +			   "ioctl_handler access_ok failed for cmd %u, "
>   			   "address %p", cmd,
>   			   arg);
>   		return PTR_ERR(ioctl);

If you have to repost this patch, please use that opportunity to join 
the above split strings. Additionally, since this patch touches much 
more SCSI code than ATA code I think it should have been sent to Martin 
instead of to Jens. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>