Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190113183210.56154-1-olof@lixom.net>
In-Reply-To: <20190113183210.56154-1-olof@lixom.net>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Mon, 14 Jan 2019 07:47:28 +0100
Message-ID: <CACT4Y+baa--beaomge9yYhtxEfhAEtoCijSf17giZN+0ECbf+w@mail.gmail.com>
Subject: Re: [PATCH] lib: test_ubsan: VLA no longer used in kernel
To:     Olof Johansson <olof@lixom.net>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jinbum Park <jinb.park7@gmail.com>,
        Colin King <colin.king@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jan 13, 2019 at 7:32 PM Olof Johansson <olof@lixom.net> wrote:
>
> Since we now build with -Wvla, any use of VLA throws a warning.
> Including this test, so... maybe we should just remove the test?
>
> lib/test_ubsan.c: In function 'test_ubsan_vla_bound_not_positive':
> lib/test_ubsan.c:48:2: warning: ISO C90 forbids variable length array 'buf' [-Wvla]
>
> For the out-of-bounds test, switch to non-VLA setup.
>
> lib/test_ubsan.c: In function 'test_ubsan_out_of_bounds':
> lib/test_ubsan.c:64:2: warning: ISO C90 forbids variable length array 'arr' [-Wvla]
>
> Cc: Colin Ian King <colin.king@canonical.com>
> Cc: Jinbum Park <jinb.park7@gmail.com>
> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Olof Johansson <olof@lixom.net>

Acked-by: Dmitry Vyukov <dvyukov@google.com>

> ---
>  lib/test_ubsan.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/lib/test_ubsan.c b/lib/test_ubsan.c
> index 280f4979d00ed..9ea10adf7a66f 100644
> --- a/lib/test_ubsan.c
> +++ b/lib/test_ubsan.c
> @@ -42,14 +42,6 @@ static void test_ubsan_divrem_overflow(void)
>         val /= val2;
>  }
>
> -static void test_ubsan_vla_bound_not_positive(void)
> -{
> -       volatile int size = -1;
> -       char buf[size];
> -
> -       (void)buf;
> -}
> -
>  static void test_ubsan_shift_out_of_bounds(void)
>  {
>         volatile int val = -1;
> @@ -61,7 +53,7 @@ static void test_ubsan_shift_out_of_bounds(void)
>  static void test_ubsan_out_of_bounds(void)
>  {
>         volatile int i = 4, j = 5;
> -       volatile int arr[i];
> +       volatile int arr[4];
>
>         arr[j] = i;
>  }
> @@ -113,7 +105,6 @@ static const test_ubsan_fp test_ubsan_array[] = {
>         test_ubsan_mul_overflow,
>         test_ubsan_negate_overflow,
>         test_ubsan_divrem_overflow,
> -       test_ubsan_vla_bound_not_positive,
>         test_ubsan_shift_out_of_bounds,
>         test_ubsan_out_of_bounds,
>         test_ubsan_load_invalid_value,
> --
> 2.11.0
>