Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3289088imu; Sun, 13 Jan 2019 23:40:32 -0800 (PST) X-Google-Smtp-Source: ALg8bN4bVvDA7ti12eKlHdmBqW9HKPnykN6QDuRMisIeAFIDQ1PxBGWD6Zk7N/ZnS7P4x9Mi4RJL X-Received: by 2002:a62:8096:: with SMTP id j144mr24610457pfd.140.1547451632667; Sun, 13 Jan 2019 23:40:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547451632; cv=none; d=google.com; s=arc-20160816; b=v53WnYt5FlYSfndms10TzSIKZMoa85dKa/d2jKoBtEZqhv9Ik+Thr25taRQ5ayOsio YISeh9WG80rpZU0pwDvimikRwJn8sdl6kTCzNrXBnMv4vtcolKPbReFsTYlCOTEHjI60 XbVUTpgEisbqprOikQEr4Mtmov6nQcjLlECEd4aV9I/q+PztX3wj1rhbUpfr/LB+uLLe oPFhWOjSrVUoAj5QARdBopGQabPbiVGAYQLBRHrUMHuBGcfKuh4mtCLymODhdz6x30O0 qjLMFnIPRWZhHFjRcoFJ82if83a0p8bJ/p2tu/JUeAXFWTF8wrz57Q6MC7lzGa7sNeOy lHCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date; bh=R+kHcQESaElgSb5meqjD/8csbYDgJFpbfQVKueLq/RA=; b=EPgRqFM+zshBjvkR6YD7v9tHNbDfYDsQ+F11j+xmFefxqa3JLu0Qc+kWKh132pL0lo A3AgDgYTYV2AVolq4aVLyiZJQp4xGLtCILQAyPhL0uCZJByzLTqUX6dWCX4IGsToC4Q0 I9afxXHkewVN1r/vdwY4wFQEjdfTG+HgA4UwLPRPzVkAFi/1ng8k9j8TVvTnKv/qghXI h4gP77ox0bgb8v/pEltbnmLxD28DmOiNwA2qdi58hRF3Z0+YTc+IOT1QhYjqDoDpQHk0 4FPAgGIo0nl2obhCvSW8W87bFltIOpxpBA9dTNb3CBc5bQRbYO/ti6weCzsm90xim7bY ZZyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m78si48149479pfj.48.2019.01.13.23.40.05; Sun, 13 Jan 2019 23:40:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbfANHiY (ORCPT + 99 others); Mon, 14 Jan 2019 02:38:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41372 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbfANHiY (ORCPT ); Mon, 14 Jan 2019 02:38:24 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D3383A267; Mon, 14 Jan 2019 07:38:24 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-117-186.ams2.redhat.com [10.36.117.186]) by smtp.corp.redhat.com (Postfix) with ESMTP id D507C194A8; Mon, 14 Jan 2019 07:38:23 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DF22416E03; Mon, 14 Jan 2019 08:38:22 +0100 (CET) Date: Mon, 14 Jan 2019 08:38:22 +0100 From: Gerd Hoffmann To: Rob Clark , dri-devel@lists.freedesktop.org, Rob Clark , Daniel Stone , David Airlie , YueHaibing , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Thomas Zimmermann , Dave Airlie , Thierry Reding Subject: Re: [PATCH] drm/cirrus: fix connector leak at unload Message-ID: <20190114073822.3jzujq47cwfoizgh@sirius.home.kraxel.org> References: <20190111140242.29002-1-robdclark@gmail.com> <20190111220620.GF21184@phenom.ffwll.local> <20190111221638.GG21184@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190111221638.GG21184@phenom.ffwll.local> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 14 Jan 2019 07:38:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 11, 2019 at 11:16:38PM +0100, Daniel Vetter wrote: > On Fri, Jan 11, 2019 at 11:06:20PM +0100, Daniel Vetter wrote: > > On Fri, Jan 11, 2019 at 09:02:34AM -0500, Rob Clark wrote: > > > This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload. > > > > > > Signed-off-by: Rob Clark > > > --- > > > Similar case to the issue that was fixed recently in drm/ast > > > > Reviewed-by: Daniel Vetter > > Actually I just pushed a patch to drm-misc-next to rename this function to > drm_helper_force_disable_all(), so you need to respin ... My r-b still > holds. Fixed and queued up. thanks, Gerd