Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3312338imu; Mon, 14 Jan 2019 00:15:10 -0800 (PST) X-Google-Smtp-Source: ALg8bN76vUD5gF6Kq9nDlFVxppZruxpHbeS6FvKwmHQ2OwlFA6WHiQtjtbESsP5f+tQoO8NHqG5+ X-Received: by 2002:a63:b649:: with SMTP id v9mr21959805pgt.436.1547453710395; Mon, 14 Jan 2019 00:15:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547453710; cv=none; d=google.com; s=arc-20160816; b=jLMChquH/tzYxXMcrY36mQBuhx73ObYLWslEpjZ08b6JqjMA7lVWejDMyUBmp2bdmH 6JznaNreCy4Bto6ieRsFA5F2u+9unXJN+W2vQl6+2NYRFKgxwUAAicyC79hWGXL47XEq vo7mUCHQjrCOeFjw7TeTe2AaMOXD93BPkMsYiQ07yMJDSrN9Oacem5Oj4HI6S2O9BEKV /Cxd97sw/PSjxvZrBJJuJLv7yXXw7go9sls137/ytwxJcant03anOG8K3KQ7aQGx37vs 6V97q1vxckdzo2NOytGgy3N7/YTDzn4BGysnFuHkJj+NLHXXh8SIfEvvYKshdAeOdpX5 oBPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=AdIwpGUdfgrBZuf7v7eJ9Plo+cz2JHhPkJYXfCtyu8s=; b=ua2RmEVd5J6MKVnLFUKzXwMVgiIzn5TWW49qZ5ilI41h3Q9f3ug23J/AjoiorkD2O6 RXRSyMBADu0xWtWMgQkUhbZY9h426W2Vgmd04MaeURtD48ehZxqxPZ6gh2r99M+vaRb0 3zZ+nFZei63h2Lh/zx9a+Pzmaocp0eI320jEWP4VDN/uPSiTvnqYlSel13n3kMJX2Ks8 kFz1jADGl98Kn7y0Kb0YgC4JsQ+1L3dAB2ApZiitKknTg5s5eU5AcPbDmKDECEgqG0Pk hbiXuA+j83irUiip5I2s+DoieuHf7fqq0xCxNDaRkOSJbogoCvUkwoKsZ8kvRpASXJ3W THUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19si8192495pgj.358.2019.01.14.00.14.54; Mon, 14 Jan 2019 00:15:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfANIND (ORCPT + 99 others); Mon, 14 Jan 2019 03:13:03 -0500 Received: from mga11.intel.com ([192.55.52.93]:34159 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbfANIND (ORCPT ); Mon, 14 Jan 2019 03:13:03 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 00:13:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,476,1539673200"; d="asc'?scan'208";a="138022732" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.72.175]) by fmsmga001.fm.intel.com with ESMTP; 14 Jan 2019 00:13:00 -0800 From: Felipe Balbi To: Zeng Tao Cc: Zeng Tao , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: gadget: don't remove the request if bus-expired In-Reply-To: <1545339230-10520-1-git-send-email-prime.zeng@hisilicon.com> References: <1545339230-10520-1-git-send-email-prime.zeng@hisilicon.com> Date: Mon, 14 Jan 2019 10:12:56 +0200 Message-ID: <87won7mzcn.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Zeng Tao writes: > We have already returned EAGAIN for bus-expiry, and it's designed to > start with a future Frame number and start the transfer again. So we > should not remove the request for that case. > > Signed-off-by: Zeng Tao Do we need a Fixes tag here? How about Cc stable? Can you share tracepoints exposing the problem? thanks =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlw8RIgACgkQzL64meEa mQZWLxAAwgXG4dgFq4QKTlmWqvSQql6to9JscaTsA3U1NBplSLhRJlXcUEDjglQ4 f2s2Ljon6Tu97P0X1Flkqp3xv801CxrXKNv/NZFvJRq8/oZf0sOBOC5TKxGZU6QZ RGyIbr6900u9929qMtUPZZ8roKxemCbF2wenuh+X9pu8u5RYWXkt4XBdTDOh+k8j Oz30gvjKeqITJfZK1z3PPCD3TmcWy/fBQ7Pjzz38vf8hTkoL29PW6LgIeNrY+KeF us8epOxC2lyheI6XX4maadGf5TZOJ5VbJ3sSnbDY/I3tskfBcme/e/57hApj48yM c7rgiu1T2/PZ2XoLH6Z84zguSsMoOMSMdif6iNhmKWQrs69O4hLxIJCCyGDNPmXy 7DWpgSwvbGniQecEiVpRElekhyQq37UrRNFUCmViQD5YEvCD1rAZrPKWg1vwp/mF Cn+zS8MUpih46lyHXX+ng4I1gRkEoKOPkKPIKmEUqT6P2RamPlSSb075+TbjvElO QvrUQe7UGY7n713jiTypWbqXn9pqE1sDe62kSBFW/KrTqPN1d5KHhnx3GdAXKd0D 6IbCuGbnxcCo0ciuu/7WxbfRrwPvuvlB+3FZ0eIGudE1tQusSIF8i6P8z4jlMwY+ v8I/kj8GNx5WlHe6AI3YFxwXMpSlUV3KEb3EjqVsTCtl55X/sUU= =aDw7 -----END PGP SIGNATURE----- --=-=-=--