Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3320341imu; Mon, 14 Jan 2019 00:27:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN4jRCU3NnPzk2Wwnm2VKK9wCjT0XVODXLtwL+cIunT4IDuJvVdKlxipzxKbpLM8RFkaIY8E X-Received: by 2002:a17:902:201:: with SMTP id 1mr24182006plc.62.1547454424343; Mon, 14 Jan 2019 00:27:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547454424; cv=none; d=google.com; s=arc-20160816; b=CUc9LelQ7CZdmfZCDVm2tc4qoiSV1AsH/e2H0hZtr3H/4fUwRT7OL+Dd3xtuS7yInk hZJPWP7+QqGU+7awjUndQtAi1ngcSlrl2HDsanCxP/nKdK2A9/NEBJVlTEp2MMKbJdap Ivxevofa1ut2hVdPf8Z4SwuIuEj3IfN6EP8ddF5BnAlwEabE9rw98fGKQbds4twigflx JZvdETJi4IA8bD5ksyBFcFKQ2fY5iWXKeRY7nhc5+LtLZo6KK7ghrpUfXjtvl3opfUFb bErvh88tTuFDqCLE+v51jdYgXgRlVugot9mOkCAkhwQtN3nIRbCr3hJSsSPbi+RQXabb JEmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=YkPn1xL2oiOArne/N0Ongdrcw7L7vib32IvSe9FF2Fc=; b=l5TQfgXBbVLVFmKQHRUDq905Qmeqmlxc0kbBM9hjjcjdi8Af8b8Lk96TNStPLMnbOD jBtWDJsC6pFXZfePM1Nqd/LvYDYvnGJ1SqIYQyYIfkyieH3oWU36WlNYSS6WMoeBCBGd gexhBPggELHxMAESiSjN0SVI6l+k8+TzzEYOabkgATGQvWPNEFMEvc8u7vLcufWK3Gpa Tdvg1wtpblofmei3HwywGoy1VHfW/YL+FayPMkpYuUePx9PeNzQAXUtjwPhyj/GDIHac RIAYqyWRlff27ACPibmTgiA71FgI++kHU8hAr/mpVUZ7vgALd9mKDX4OmzWWeES92O/y 3vlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XUtYRSZy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si38738166pll.112.2019.01.14.00.26.48; Mon, 14 Jan 2019 00:27:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XUtYRSZy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbfANIYk (ORCPT + 99 others); Mon, 14 Jan 2019 03:24:40 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53585 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbfANIYj (ORCPT ); Mon, 14 Jan 2019 03:24:39 -0500 Received: by mail-wm1-f67.google.com with SMTP id d15so7901609wmb.3 for ; Mon, 14 Jan 2019 00:24:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=YkPn1xL2oiOArne/N0Ongdrcw7L7vib32IvSe9FF2Fc=; b=XUtYRSZy6SQeX2YpwgO/tK6iru2s/vfHaxM8c9QHOhdzWcpDi2pGL3qW8aBP7ah9Un MuC4eVNPZNmZw9euyORY+vlCZh713DQEIloLteThOJHFozL0eUMb25yE7OCAaw1oghqg zpLXVaWmeilM+jNaH9Zq8YsXk/KmFaABuUWDM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YkPn1xL2oiOArne/N0Ongdrcw7L7vib32IvSe9FF2Fc=; b=QXldkYFjRVy8YZ7VxuvozVZTUUyP6i0o+zHf4fWjro5hw6px4PdWvrvFK/zYxrTkds KkLM2rgBaePzXfJJx6BCR6j85XTH2Bomlf9Hu174kl09KtCLwRX5otMCYsxuTUP26Wd6 pSw6c7jFDKpQ6AwCW8J5Z+6lnvTOfHjsmInbgYDkiV/xzFmBzpVO/YDQmwJqOdgWeNQi 4l1YKlxaYxUt6g2kL0EKhnmdxGskZXTKSWUqWPsjAWNRLovc70K/x/oye8chFbUSoUrU JT2Ah87kCvs+lHE8lzqOwL6owDF3v7kEGVBLcADWiU6N52Rjc6e5ZDtKjKboKx3E5JAC s3Dw== X-Gm-Message-State: AJcUukcSWwYT3OZhrK0YYSy+dRsviKHIUtTXYoEiCdywKFwk5dyPbtFv cwcb5wl8BHlyRJmDIfbKjwvTVADI6Yb79w== X-Received: by 2002:a1c:2382:: with SMTP id j124mr10685396wmj.14.1547454277799; Mon, 14 Jan 2019 00:24:37 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:39ec:3900:1e09:314e]) by smtp.gmail.com with ESMTPSA id i192sm28546146wmg.7.2019.01.14.00.24.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 00:24:37 -0800 (PST) From: Vincent Guittot To: xuwei5@hisilicon.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org Cc: Vincent Guittot Subject: [PATCH v2] arm64/hisilicon: fix SDcard detection Date: Mon, 14 Jan 2019 09:24:34 +0100 Message-Id: <1547454274-1674-1-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The SDcard detection of hikey960 is active low so cd-inverted is wrong. Instead of adding cd-inverted, we should better set correctly cd-gpios to use GPIO_ACTIVE_LOW. Signed-off-by: Vincent Guittot --- SD card detection was not working on v5.0-rc1 but patch https://marc.info/?l=linux-mmc&m=154637189021211&w=2 makes it work. Nevertheles, latest changes in of_mmc_detection makes possible to have a correct DT config. arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts index 71bfe41..dc314e7 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts @@ -665,8 +665,7 @@ sd-uhs-sdr50; sd-uhs-sdr104; disable-wp; - cd-inverted; - cd-gpios = <&gpio25 3 0>; + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; pinctrl-0 = <&sd_pmx_func &sd_clk_cfg_func -- 2.7.4