Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3323123imu; Mon, 14 Jan 2019 00:31:11 -0800 (PST) X-Google-Smtp-Source: ALg8bN5J5eovMM8q1XUiOGr7Kwyd1mW6NFz3gcVNQNeRqN57DgW6jACOCA2uFkYHrN3rgO3f8GDj X-Received: by 2002:a63:68c4:: with SMTP id d187mr19457512pgc.11.1547454671119; Mon, 14 Jan 2019 00:31:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547454671; cv=none; d=google.com; s=arc-20160816; b=g9HBSbujmpA89jxdUl4TvUC8bP/49flCGxEM8PTgIQjhh5ll0WGISkd0aExljqZtlz K43XUyo1bQMPVW3HyQDjA0wAxUg7e99efZAeEYwwZkgvvwc+zU6GEyymJGiFn0WmLImf yfJH+IfGi7spKbcEvT6Ve7jMNn6Fbw8aLgySHjKd47Lvl4LldKbZSg+/ddmlN1cTutrB TC9qsqSoGLl8aLhtdKj63L/CPIvtq9RnI6neYr5nQXNc5yXHvD6rI9hCf6Ohs9kich6+ yVqKg1HlQ0d+Xx9x4b5MQsRchVzf3jQyEH2W0BjQNSc4kKwzRg8DkNuUCEy0qe43cSma XCsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=PK+o5wSfNSAi8nHTgkusBFI+usEcOqlS3NIt5HaMg9A=; b=P9jxMZyAsGU7/N/FFOkbVVIHVkLE6m00CyrSXX+nEwNPvUWfbRPYPWONTyeVW9T9R2 ApsNzaay3giuLd1cklLaj6t3UzX2p3A+/d3ly5b04glJ73lUS2odtdSpACofuq4j84L2 gfUGv+6BcDrBDZlCaE9rewCV4fay6miPDS4LWxQNwHMEvV2btpFRIvz/e8F6rKK2DM/E 6evMwePsPiS/qcmRk5DH+/GUOEQy/r2e6EoTwP4qyN+gUUC6Xha+N441CyvwJrF0/2SV +fP4uRYtDh9coJh2z1gSbGnfwj6gY78ZfNy6Z0P38sec+KWF0kkZ2e3bb7gVAb832Orp 90mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e5qmJpOI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d16si9310410pfn.169.2019.01.14.00.30.55; Mon, 14 Jan 2019 00:31:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=e5qmJpOI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbfANI2f (ORCPT + 99 others); Mon, 14 Jan 2019 03:28:35 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:41040 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726138AbfANI2f (ORCPT ); Mon, 14 Jan 2019 03:28:35 -0500 Received: by mail-lj1-f194.google.com with SMTP id k15-v6so18157423ljc.8 for ; Mon, 14 Jan 2019 00:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PK+o5wSfNSAi8nHTgkusBFI+usEcOqlS3NIt5HaMg9A=; b=e5qmJpOIJCnTGIJsBcefQF4pczpWTlwUOulFSMHsESeMXkQShuduHIBQny5xjHEEGK 65rR+/isOJ6hG+1BJieFHbJLww9GMaPs8vHtIH1QelUN8f5efReeRt7CjZe5wRfVmE+Z LxbItZC5dXwJ3nwS0Pt1kohi2cX2V5TIP3UaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PK+o5wSfNSAi8nHTgkusBFI+usEcOqlS3NIt5HaMg9A=; b=USyXRClH2Eil+3nQZ1jltYbOZTnumX4G5QGc4kcbXXTP+WCGjOq1DyBBj9h3RR3rO9 n71KEjYcoh6sNnemC13HwFajUle1WRrziyiZXEkAA1r0hgTnGY/AQB0WYWeuqnNsjgsI DeXnf6vN9vg/uo5xg/nCAoN/SEo0dG6RsTgv1V3H4g7hhjV45BH45FJPUZS6uDqHYzD6 mR2PQL9hL3K3PG1Gkihe548fKaU85q/S8o10zQeyGcQwnbEARORXmTnm9mo6BFPZ/P1Q l6G/oHFDQ61ujshgo/yEIkCrbbkAw/dC6ugodwJ17I9WprXVTipxjsMdnQ0CpjCtCfx8 /EeQ== X-Gm-Message-State: AJcUukdYz8KQTQjhIQMhvHXN/2eaDzPpwnufm1gWhu2zFcLFM3JyA+Oe rIAgob71g2gJ5l4E514ggWIAkUqGOUKIlvPlSp9I3g== X-Received: by 2002:a2e:7e04:: with SMTP id z4-v6mr13711685ljc.97.1547454513248; Mon, 14 Jan 2019 00:28:33 -0800 (PST) MIME-Version: 1.0 References: <1547454274-1674-1-git-send-email-vincent.guittot@linaro.org> In-Reply-To: <1547454274-1674-1-git-send-email-vincent.guittot@linaro.org> From: Linus Walleij Date: Mon, 14 Jan 2019 09:28:21 +0100 Message-ID: Subject: Re: [PATCH v2] arm64/hisilicon: fix SDcard detection To: Vincent Guittot Cc: Xu Wei , Rob Herring , Mark Rutland , Linux ARM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 14, 2019 at 9:24 AM Vincent Guittot wrote: > The SDcard detection of hikey960 is active low so cd-inverted is wrong. > Instead of adding cd-inverted, we should better set correctly cd-gpios > to use GPIO_ACTIVE_LOW. > > Signed-off-by: Vincent Guittot Reviewed-by: Linus Walleij Yours, Linus Walleij