Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3349601imu; Mon, 14 Jan 2019 01:09:24 -0800 (PST) X-Google-Smtp-Source: ALg8bN7KRKv+fdPPBY1KRq+r3Q4EiqistI4azDLO06fSFVSnv2LwGQ+gmMmoUv7BZo1lGJNl6xep X-Received: by 2002:a63:170c:: with SMTP id x12mr21467601pgl.364.1547456964616; Mon, 14 Jan 2019 01:09:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547456964; cv=none; d=google.com; s=arc-20160816; b=gh3qnhqxtpWqZs2/PAPyS7hQiaw8nfz+AZaqzn1ZrDVS01Sb7i50op3gB8g8kDwSJG +xE8I8PCz3/AIjZwEB5WwHAqHTQBcN3OKkMTxJr0orj4m2DrVgc7ia5nszZ+OztBWCXn zISX+RzTUNm6ZnNouM++YEC39OH0cBiVmwiSUzw5aaXSJzvLYWd46S1YY2ozQsR3jG85 o+41nRfkdHAJVVKAc86kBdtw/NJWwSTke1RA0dESG0AuJVBI6cw2DbixC5SPDHOK61bq Y3xvU1Kzs78G2yY3sa4s2wdrOeqGfnOafFqqreNso+hDCvBLJtpiRo2xfSaSIrXowEUf BPrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=F3O9IqkNzwz/8Etq42lTyFj7inkLRyVqs29On1dc020=; b=Kslfm6JMQ36BQCpNkmj0vqVspBc1Cj1sXMbicmpgUNhvFZRSF9RZKEWipW66l7uXra uGk5cToojnetM6yr3BeLt+eq3MaKTj5CLr2RSfidBMMpTkgzAtsRYJCowJ/2eQrJfpMy VTjGvk/zYREIX2gSMEn6n/gJZeMl1QU/Zye50CKFJji06WY68GDh6PzeuIYNCt9QEdms PI1xtwrrp7LGeL3u+aNWpkhwTFimgRYjP7SUW3Gk/BcpfJsiAot7i82PvyJc2ig48z4e ftOrnT6CjcumZoeMM3c7yYdLobWlOlIPPzTVtBTdRDpWOlbpvff51wh2iHccoY+xi7l5 w7jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=grM8VzcD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x8si3618838pll.187.2019.01.14.01.09.08; Mon, 14 Jan 2019 01:09:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=grM8VzcD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbfANJIE (ORCPT + 99 others); Mon, 14 Jan 2019 04:08:04 -0500 Received: from mail.skyhub.de ([5.9.137.197]:41198 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfANJIE (ORCPT ); Mon, 14 Jan 2019 04:08:04 -0500 Received: from zn.tnic (p200300EC2BC4CA00116FEC2D9C4463FB.dip0.t-ipconnect.de [IPv6:2003:ec:2bc4:ca00:116f:ec2d:9c44:63fb]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 67AD51EC058B; Mon, 14 Jan 2019 10:08:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1547456882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=F3O9IqkNzwz/8Etq42lTyFj7inkLRyVqs29On1dc020=; b=grM8VzcDZx8VtVXsoLC5uDLMd267OC7Gn3SBVPV4I3m45NfbxRc8mxCZnym6ISyFE+Tpsz ffZjobKB8rHNd0RjcASLkJCY83PKGIBkeQ1HeRcL+UyXWAEizfPh0lYWd/OZzb6iMn0+7h 2p+uzmi4G24UKTop15rMqfb4rPB6/Qw= Date: Mon, 14 Jan 2019 10:07:56 +0100 From: Borislav Petkov To: Chao Fan Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, keescook@chromium.org, bhe@redhat.com, msys.mizuma@gmail.com, indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com Subject: Re: [PATCH v15 3/6] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table Message-ID: <20190114090756.GA2773@zn.tnic> References: <20190107032243.25324-1-fanc.fnst@cn.fujitsu.com> <20190107032243.25324-4-fanc.fnst@cn.fujitsu.com> <20190110211523.GG17621@zn.tnic> <20190111012353.GD2216@localhost.localdomain> <20190111103225.GA4729@zn.tnic> <20190113094704.GC13263@localhost.localdomain> <20190113110544.GA7398@zn.tnic> <20190114012641.GA30900@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190114012641.GA30900@localhost.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 14, 2019 at 09:26:42AM +0800, Chao Fan wrote: > According to the code, I saw: > #ifdef ACPI_ASL_COMPILER > #define ACPI_32BIT_PHYSICAL_ADDRESS > #endif > > and then > #ifdef ACPI_32BIT_PHYSICAL_ADDRESS > typedef u32 acpi_physical_address; > > As for ACPI_ASL_COMPILER, I saw iASL in documention, but can't find more > information in the code. If I miss something, please let me know. And, as a result, can acpi_physical_address ever be u32 in a kernel build? git annotate is also very helpful when doing git archeology like, for example, finding the patch which added the ifdeffery and looking at its commit message for more hints. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.