Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3388093imu; Mon, 14 Jan 2019 02:02:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN6Afpi8MA84uuQ+0xsRXnGLaSkx+BpsFEF+2KoW0wBg+PBlcZSjwWppALzYSGh/Td8tEjSC X-Received: by 2002:a17:902:be0e:: with SMTP id r14mr23203916pls.124.1547460124527; Mon, 14 Jan 2019 02:02:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547460124; cv=none; d=google.com; s=arc-20160816; b=Laxwv+8FRWhgser1bGtyNtPZrGQH+67/2/NHB8BTV5fCbD4EM5wM4u7uKzV5Mismd2 XhwRWNkwfPVFMss9QeNxNLjrvDJg/iZPHjxyYS0IuNM/QbDAvI5dzUg6GlRobPor+IrU SHIdZgfAftZHBDpiufzgCauMEKR9FfOPkojV0qb9nLtd7Nm1ZmzHFI/ny/LUouyGQEVB 8ZJVYKCNc0N7xgoOOSpIdIdi/nkQgD3PW3526Gh5PpnImcl7rloxe6U9WDwdFzujs+3y aQ3ilW09nt+s7WOb9Jwur0aWnWOKKclX10xzDOKSJGFzN61VL3RXXvKcqwapt5KUuUVF JDhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WZ9aJEBC7EdGRYOFoux4r/SaAviNsLiJM7mr7nUt+xw=; b=p+UnKLZ1vb+W77E1smcOjyqiQ2eDdQx+/i28rQe13No/QP2vGXnlJBgPXQHMQzJE+s 9mmOwQFfqzySFsXPqD2y3W0KifMHli6zV7euY4wHcL74GhRx2kxhbMixkEDxcyjT4hj0 3z02r1qv+CwVOARcQ/bdyTw3jIWqfRfHyomRyNPaca9ANNHhdbxPQjffPUyplhP2FWql kRNQUMVQpezAzOu9oWoOG09KTJwVmYH0HPEereb53if3YAinWPbSfzNvGev243PaIlFC LbXXFEoBOsVK/hV/t1+igN5ymA42eJtDG0LBKVJrdnZFjgE1b1Bt/L+DSXDPRMTa7ltn 9irg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=nvuGuEGr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si24498973pgh.469.2019.01.14.02.01.49; Mon, 14 Jan 2019 02:02:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=nvuGuEGr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfANJ7Z (ORCPT + 99 others); Mon, 14 Jan 2019 04:59:25 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:60210 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726857AbfANJ6v (ORCPT ); Mon, 14 Jan 2019 04:58:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WZ9aJEBC7EdGRYOFoux4r/SaAviNsLiJM7mr7nUt+xw=; b=nvuGuEGrA6lXHBJRocmbjOMDkC rjtYKqaMNZD89cnBBBEc9TaCCIY4SJmclUvcYTq6q0KxAVQo27rv6SZYzsw0cBdyntMggVaO/M/pO QMyTS+ZENRDdGQizbQv0uMijvWGGXw1FpdxaQlc4Jyqh9ppgLpo+lhFeM+C164s7T/TeaG9wPjRbG 9OcCwqD4tRdSb8x1zrSMGSjc5jyFtchgsYLpGFwr4xh65JFiOJ2IBwqh4Zt8eGOZEwAsYWz52B3GP JndHaGVbDdogHR+FpV5Eck9L4IGymJFtCzF4U2FIaaBr1cYPtYsQG4yeEkgUNzBWk6KNxvPmA4yrz UAfnTcwA==; Received: from 089144213167.atnat0022.highway.a1.net ([89.144.213.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1giz0k-000250-Ag; Mon, 14 Jan 2019 09:58:26 +0000 From: Christoph Hellwig To: Ulf Hansson Cc: Russell King , Nicolas Pitre , Aaro Koskinen , Ben Dooks , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] mmc: s3cmci: handle chained sglists Date: Mon, 14 Jan 2019 10:57:59 +0100 Message-Id: <20190114095804.27978-7-hch@lst.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114095804.27978-1-hch@lst.de> References: <20190114095804.27978-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the proper sg_next() helper to move to the next scatterlist element to support chained scatterlists. Signed-off-by: Christoph Hellwig --- drivers/mmc/host/s3cmci.c | 19 +++++++++---------- drivers/mmc/host/s3cmci.h | 2 +- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 1be84426c817..2660fb61d1d0 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -320,20 +320,19 @@ static void s3cmci_check_sdio_irq(struct s3cmci_host *host) static inline int get_data_buffer(struct s3cmci_host *host) { - if (host->pio_sgptr >= host->mrq->data->sg_len) { - dbg(host, dbg_debug, "no more buffers (%i/%i)\n", - host->pio_sgptr, host->mrq->data->sg_len); + if (!host->next_sg) { + dbg(host, dbg_debug, "no more buffers (%i)\n", + host->mrq->data->sg_len); return -EBUSY; } - host->cur_sg = &host->mrq->data->sg[host->pio_sgptr]; + host->cur_sg = host->next_sg; + host->next_sg = sg_next(host->next_sg); host->pio_bytes = host->cur_sg->length; host->pio_offset = host->cur_sg->offset; - host->pio_sgptr++; - - dbg(host, dbg_sg, "new buffer (%i/%i)\n", - host->pio_sgptr, host->mrq->data->sg_len); + dbg(host, dbg_sg, "new buffer (%i)\n", + host->mrq->data->sg_len); return 0; } @@ -1052,8 +1051,8 @@ static int s3cmci_prepare_pio(struct s3cmci_host *host, struct mmc_data *data) BUG_ON((data->flags & BOTH_DIR) == BOTH_DIR); - host->pio_sgptr = 0; - host->cur_sg = &host->mrq->data->sg[host->pio_sgptr]; + host->cur_sg = host->mrq->data->sg; + host->next_sg = sg_next(host->cur_sg); host->pio_bytes = 0; host->pio_count = 0; host->pio_active = rw ? XFER_WRITE : XFER_READ; diff --git a/drivers/mmc/host/s3cmci.h b/drivers/mmc/host/s3cmci.h index 4320f7d832dc..caf1078d07d1 100644 --- a/drivers/mmc/host/s3cmci.h +++ b/drivers/mmc/host/s3cmci.h @@ -51,7 +51,7 @@ struct s3cmci_host { int dma_complete; struct scatterlist *cur_sg; - u32 pio_sgptr; + struct scatterlist *next_sg; u32 pio_bytes; u32 pio_count; u32 pio_offset; -- 2.20.1