Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3406480imu; Mon, 14 Jan 2019 02:24:02 -0800 (PST) X-Google-Smtp-Source: ALg8bN5aHZohOzF/SfOSEaqXsMy12ByGTYcJgUUR+ujJRb/3JAgsQDuig6lkvfDo7pPNXRhJUsv7 X-Received: by 2002:a62:3241:: with SMTP id y62mr24608927pfy.178.1547461442779; Mon, 14 Jan 2019 02:24:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547461442; cv=none; d=google.com; s=arc-20160816; b=xjm2/SidCtcp2zIBNUsatXLXjg7jPkTy5ao9aqkP3pchy/ARKmrefmDeUDC0p0Aabx kG3xqkjGupex2Fo6STCsp1Wmy+j7jm/IahIIINCAPnsIBclAQU2+wpdg4hAoEaYslpJY KumMd2Nal8X/Y4XXXSbng9OVy+L/Hf7N1NI1HbkY2DVxhL1Gzochb7jt2uN4QyLBKyb6 VFrtCYKsDNVJiHZ++LmKG7xJc6jZBQ+qOtZvgtdugg78I1S47kCr5Ye3VjggxBy0Tqgg H91HBaR9kUKhiCyurDTEB9wKWVN4cgGWR1Wvddabv0YhvWIBGGxJzKJPlVuXBfIh5drD cfJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=Wu/tmpT7BDXo4oTQUwIjofVpVoXKP/NrUVRomzzYDk8=; b=Zsl1la7nciUw/N7W0frJruHJuMBtwiiLmRvJNtWCNfLcA1klAQGGhRx2OEr6UK21C5 NK47uYXcpsjmOuK1IfbXs/RNaOV1GUI8T9MKBPdJiSxYkD58GzRdfStM4kGLvKaCpoPa qOnJJri5g3/W9lywgQkupBlkNTJhzjfyaAc59tBmSLOVAD7QXgMTJzpng44Mz56EQ+kF 9m4GCYeY87Y2LF9Wca+7z80u/GKmSIzYc6YtvCLSUTcAj1V/pQE3Boqg2ZpTftpzBM+n +6OORc5p/cvmIh8LJQNmWQrTBOMmp6kQEbvWp9NHwlFMwTyzE+vOV0nyTa6ivYATeiow xouw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z1N08G6o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o9si28343pfe.63.2019.01.14.02.23.47; Mon, 14 Jan 2019 02:24:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z1N08G6o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726911AbfANKWR (ORCPT + 99 others); Mon, 14 Jan 2019 05:22:17 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40425 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726881AbfANKWO (ORCPT ); Mon, 14 Jan 2019 05:22:14 -0500 Received: by mail-wm1-f66.google.com with SMTP id f188so8212169wmf.5 for ; Mon, 14 Jan 2019 02:22:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=Wu/tmpT7BDXo4oTQUwIjofVpVoXKP/NrUVRomzzYDk8=; b=Z1N08G6opSL2YIWhjPthqe3mvAA4GZbBv2gowuWMVignQnnwPM4OtQrPGFKjt4ykXb E/LzT9mAttHZw2pS7F1UL4raKcuvwlI7KsrllyKU55Twem4025TdkuTL3C8P46o2jfNP hj8Jd88FQRY8AOg3H71Ro7UAKEaY73RUPWxaQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=Wu/tmpT7BDXo4oTQUwIjofVpVoXKP/NrUVRomzzYDk8=; b=XT26WkCNy7xZN4ZSEP4dVJ2Nd1kkL4KM+3A6Ete2L0+TzSzQg+iXNRxC1qhakDDtMY wJBhtvOkd5TpUu221EaZqavqMqvr2sSr0cLYE41wSQh0f1X+T0kz3AE46CIhs6sdWHM1 Mn0VxGEiFbHJXCgSdbwTbqlsOsbK87hDPpnfN4Qx/jtV5X/6Jh+rQMMi8BjWJHqOCtMg orR23YvMY0k3dwVd3gTsylj2V6cUnKwuMt/uoz40HnqKOwSiHmrKq4b7kMKkDtQjCcS1 WJVt1dkVOT8b84/cuKH04BxMeRjIy0BB+7QN1PNv7RW3QFr3YHKXgakc7v5EjIdvOhpR QdrA== X-Gm-Message-State: AJcUukfo9693l/eJWF3mh3eZSwQaJnOyQBXWBu/WTCNqeDg+St5D+MWT eeJ5c4SJxFyRoHjwkFBIrWis87SUd7Q= X-Received: by 2002:a7b:c34c:: with SMTP id l12mr11046788wmj.147.1547461332650; Mon, 14 Jan 2019 02:22:12 -0800 (PST) Received: from localhost ([49.248.81.155]) by smtp.gmail.com with ESMTPSA id k15sm105513691wru.8.2019.01.14.02.22.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 02:22:11 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, viresh.kumar@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, tdas@codeaurora.org, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org, Javi Merino , Zhang Rui , Daniel Lezcano , linux-pm@vger.kernel.org (open list:THERMAL/CPU_COOLING) Subject: [PATCH v2 9/9] thermal: cpu_cooling: Clarify error message Date: Mon, 14 Jan 2019 15:51:11 +0530 Message-Id: <2de2d178380525191d99d6c3619ad8c45efdbab4.1547458732.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make it clear that it is a failure if the cpufreq driver was unable to register as a cooling device. Makes it easier to find in logs and grepping for words like fail, err, warn. Signed-off-by: Amit Kucheria --- drivers/thermal/cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index dfd23245f778..6fff16113628 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -774,7 +774,7 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy) cdev = __cpufreq_cooling_register(np, policy, capacitance); if (IS_ERR(cdev)) { - pr_err("cpu_cooling: cpu%d is not running as cooling device: %ld\n", + pr_err("cpu_cooling: cpu%d failed to register as cooling device: %ld\n", policy->cpu, PTR_ERR(cdev)); cdev = NULL; } -- 2.17.1