Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3406962imu; Mon, 14 Jan 2019 02:24:45 -0800 (PST) X-Google-Smtp-Source: ALg8bN4ScNRfowCBeOzrfjwDNaDSsnOZWb9XCtTjvEMIf6nzMROj9uJOA9JkS5rpVXBixYWjTUXc X-Received: by 2002:a17:902:e28e:: with SMTP id cf14mr25165049plb.311.1547461485301; Mon, 14 Jan 2019 02:24:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547461485; cv=none; d=google.com; s=arc-20160816; b=vZJoZGJnppYyCqoMSUd6PZv1xKS195cgbsDy7kOfAXnA8tmTGzCDDFkFIXWFho8Pn6 TJhXJvhhI1jNpbG2AOA0JqM50/mAZRhzsWOhQl6ejDTMKAvaVsUuT9kXpGbDva/AQniL j9po6CUD0EKwNFH1vodFPbV8EcoD78dllCXjA8rRIVLJg+LkIfFL35TAEA9BboC+69Fz iqZZfs52Nv8DOOGSioz3GZXtIKpogwE5HN8xlmVfOeEfKhMsxm7zaR/LklRBNd2cHnAO Iwk1pmQFR2H6kdaJHLStZNpZ52vaXg5qsGE2luR2Dh7XNnrqiGSc/m6VY8CVJDeWWkkC EBeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dfMx+zVv2DboYpBiUYQHn+jyjfBt6orpT+WW7HsmiMw=; b=l22NAPZSuxC2/w6ywnn2swRkMtZ3lFiEEIO0Qz568n//ZWmIBIRjVYs7sCQVwhbMkd 7R1lR7QIksg2uWZxk3CrTg66J3BeYHVgXUHfiHNs00uiVguysrDouN5izPOWvqP+v/ZK gXKXnwwHuEpR74rcbGYSi4hZ/UO5oKe7VUMkHyj2SEI406Pw41MCKVJ30FJfbVgPEnJC fRpGHKs91/uZmW/rpDb1aKiuo8n+ERTbgybS+aB1MtL+8i/cBCM6q2EVY+Lt6lvmaRvm qUm1jFtv4Egnh10pp4TUjzNo4ZnMXYCaIzeJ2luQt7PDhmJ16EBnA+ETWQ5EFa6UzFs1 nn/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J5678N0Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si6561pla.156.2019.01.14.02.24.30; Mon, 14 Jan 2019 02:24:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J5678N0Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbfANKWw (ORCPT + 99 others); Mon, 14 Jan 2019 05:22:52 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:36214 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbfANKWw (ORCPT ); Mon, 14 Jan 2019 05:22:52 -0500 Received: by mail-yw1-f67.google.com with SMTP id i73so8403967ywg.3 for ; Mon, 14 Jan 2019 02:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dfMx+zVv2DboYpBiUYQHn+jyjfBt6orpT+WW7HsmiMw=; b=J5678N0QcxTSJuvXwmP3DT9UwNd/gs9ZuKuH/BAFqjxKxKcoZ1pRaDXb1hKF+Esw3s aILlBfw0w6I+Iu4OlAyZYK0xY1gd/1yPOELp2m5wbUJSDntot/tOBKa6/Z3xJh7FMgtw f8CbV5h+MywUF2dovFgCPdbEQh4t14hHilofU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dfMx+zVv2DboYpBiUYQHn+jyjfBt6orpT+WW7HsmiMw=; b=MCNJn9xFc/ohq2votM0n5uG0aiNHRVCYdx6r8rzU61YSmwVyLr6Z9UXDDV9ef1qMjL bMK5xCI+tQH8camtz1sW2TW1hRyo5uP5E0oUmldi3IoimkZnLClHjB8pVtFp6yGsCLZt exOfqNnoIXJ57nocKOCOnycs6yTR3tjNcCxaSPztDAcuUdCbqMmmW+eyHs4Q7ZVsfrkK B1BkpqoLr05kZxqKwumz35RGuTEMU0GtsHNfqfwVIEytVXiKivByya7n+V40D9/CkU56 dln+0tMRJ3g/KpaFq/tbAaMmMsS10yC+Z3fLh0ojCoihC+Ezqb2wTnyWrzhQMWLQfyxS kMXg== X-Gm-Message-State: AJcUukeNt3i7g86I2ASm0ELRt7GEqQy/ua0jJQ2vheHY7lBkOkBpKyls gmjXKgLLNUa3VLnqSFZzw6thn/TXmgRjlsazKAoKlQ== X-Received: by 2002:a81:3413:: with SMTP id b19mr23343365ywa.297.1547461371545; Mon, 14 Jan 2019 02:22:51 -0800 (PST) MIME-Version: 1.0 References: <20190114095659.23082-1-anders.roxell@linaro.org> In-Reply-To: <20190114095659.23082-1-anders.roxell@linaro.org> From: Anders Roxell Date: Mon, 14 Jan 2019 11:22:40 +0100 Message-ID: Subject: Re: [PATCH 2/3] pinctrl: freescale: fix link errors To: aisheng.dong@nxp.com, Fabio Estevam , shawnguo@kernel.org, stefan@agner.ch, Linus Walleij Cc: linux-gpio@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Jan 2019 at 10:57, Anders Roxell wrote: > > Fix link errors when PINCTRL_IMX_SCU or PINCTRL_IMXBQXP is enabled as a > module and the dependent module is built-in. > > ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': > pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' > ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' > ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': > pinctrl-scu.c:(.text+0xa0): undefined reference to `imx_scu_call_rpc' > ld: pinctrl-scu.c:(.text+0xa0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': > pinctrl-scu.c:(.text+0x1b4): undefined reference to `imx_scu_call_rpc' > ld: pinctrl-scu.c:(.text+0x1b4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > ld: drivers/pinctrl/freescale/pinctrl-imx8qxp.o: in function `imx8qxp_pinctrl_probe': > pinctrl-imx8qxp.c:(.text+0x28): undefined reference to `imx_pinctrl_probe' > ld: pinctrl-imx8qxp.c:(.text+0x28): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_pinctrl_probe' > > Rework so both depends on IMX_SCU=y. > > Suggested-by: Arnd Bergmann > Signed-off-by: Anders Roxell > --- > drivers/pinctrl/freescale/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig > index b318c24b61be..ac158309cfe9 100644 > --- a/drivers/pinctrl/freescale/Kconfig > +++ b/drivers/pinctrl/freescale/Kconfig > @@ -7,7 +7,7 @@ config PINCTRL_IMX > > config PINCTRL_IMX_SCU > bool > - depends on IMX_SCU > + depends on IMX_SCU=y > select PINCTRL_IMX > > config PINCTRL_IMX1_CORE > @@ -138,7 +138,7 @@ config PINCTRL_IMX8QM > > config PINCTRL_IMX8QXP > bool "IMX8QXP pinctrl driver" > - depends on ARCH_MXC && ARM64 > + depends on IMX_SCU=y && ARCH_MXC && ARM64 > select PINCTRL_IMX_SCU > help > Say Y here to enable the imx8qxp pinctrl driver > -- > 2.19.2 > This patch is incomplete, I will send out a new patch that adds 'depends on IMX_SCU=y &&' on all configs that selects PINCTRL_IMX_SCU. Cheers, Anders