Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3476406imu; Mon, 14 Jan 2019 03:48:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN52u7c7C1N6tkcPwU45z74Udc3BZInNrj2g/tGcA3GXofwSC1jkQf8yAmI7CW0m63EqEkVF X-Received: by 2002:a17:902:b118:: with SMTP id q24mr25342498plr.209.1547466494395; Mon, 14 Jan 2019 03:48:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547466494; cv=none; d=google.com; s=arc-20160816; b=oh7p6OMje2iQBbnmXJUZeJHTH6+MJm+Ssk0k43AoFu6eceKwFVWhtPnaxiUnT+xn4c 0AeOIRk+21bfEhzJRBRJoms5/iiyqKhE48sXQN5yoOEd9ngqCmrhaFzFCSWf+0DFQI0l ac6Vdv8SVg4QCNAplkZnsrrlJkWdCc/VJPq1+7v5+GDsaItYqxRQWplBzOXtFui3Vj8G Sbgv9/zBXvXJyyLX9tGTUjSjmpK0705ehfbtDDho0qj8BxqcYk0R8j4Li0+OfaTztpfJ 0qvKBa46s8YTiITQTvWylAIbnJRmVP+7DYcJx1VJnpzQe27GhiqFl+Xql8k0SdnuodS1 YpEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=YOv9Qrq6hri4qiRM2sCo62WGAz+kbMcRK+rOBxv/WjM=; b=sYYEWMtE+xWOCrJOf9+0rPcLsYTQx6ejwGptc55G/GM3W2hV5VFrQp8QbRxlgEbdof tOlXw85zLFWzKE+xfUjfze39rv7c/rLSmyP5kFodljrd92pJiA7h/Uf0cnV/DGOAwmVp Cm8QHD6AUKWX8xKfdnUanzctB0ovYmYQnUNP5BzJjyq5JavO33FmzI5ZFZAwoRtIwTrj 546CUpAUvfyb3xyLaJM6skM+W+f9kXm3OL8G/jNMOzwYM2xAEJ77qUPpNBNXiipqPc6Z f3OSUevGQ2uvR+t2XdlsGz2cgTr9p2ZYpfyFvSQFjToknx+kaJNToplQLMPM9nrZI/IY B9Vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SYpWQW+l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65si163014pgf.521.2019.01.14.03.47.59; Mon, 14 Jan 2019 03:48:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SYpWQW+l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726790AbfANLpj (ORCPT + 99 others); Mon, 14 Jan 2019 06:45:39 -0500 Received: from mail-vk1-f193.google.com ([209.85.221.193]:33220 "EHLO mail-vk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726723AbfANLp1 (ORCPT ); Mon, 14 Jan 2019 06:45:27 -0500 Received: by mail-vk1-f193.google.com with SMTP id d201so4790106vka.0 for ; Mon, 14 Jan 2019 03:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YOv9Qrq6hri4qiRM2sCo62WGAz+kbMcRK+rOBxv/WjM=; b=SYpWQW+lbgoIZyB962f2Q9e/fJW9TMloKZChuJdxQBFCsdF0CeyUyYErRY9LLnNJRe awAeMm6a8KbWUyXVckugLQRwIxViEWqgIYXN6JBKYcM2T9G7N7Sgl1Ur9dB9+qj39uGs his75ew4PuQqeRZYSX+pOVnCBz6uWLAaTQ1zw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YOv9Qrq6hri4qiRM2sCo62WGAz+kbMcRK+rOBxv/WjM=; b=RmsmjiqgyBVD0oxMf8yC0z6r4raaDmjLUk3g7NAYZvY+MdI8NiT62ElCAMT/fayz14 BTYXeO2GjSCV7iZWUxNgbL8SYh+w5RAQB/rc+NC87oh/KoSnYn8TcvChSN1NwKeMvXO/ S2NAaVAG+JMnIU+wtJfeMqa0SPir9q46cTXB5pAxkBCAsuGt4EcV/sw8NumcwWFbe5oA IEURZTquIGfLhDddw8YgftUScQw5uwuUfm/sXltu+WT+18XFAw5czvAgJwkYCzYMEE50 TfpwWPe8eitEnEI3vLuqpfR/y536yjx6+kM4fnozFkerA39/F26PPoNeX58F3Q464wVe /j9A== X-Gm-Message-State: AJcUukdAbJrhxjevvsW0Di2A4dNoXJoPDii90o9o8q0WlNeRBBfXZ5U7 CeTGuGK031juNMWJDGArxxlISMzMjHgRE+GYlpPM3Q== X-Received: by 2002:a1f:4982:: with SMTP id w124mr9160121vka.4.1547466325905; Mon, 14 Jan 2019 03:45:25 -0800 (PST) MIME-Version: 1.0 References: <1547035833-3924-1-git-send-email-wdjjwb@163.com> In-Reply-To: <1547035833-3924-1-git-send-email-wdjjwb@163.com> From: Ulf Hansson Date: Mon, 14 Jan 2019 12:44:50 +0100 Message-ID: Subject: Re: [PATCH] mmc:sdio: Remove unneeded variable ret To: wangbo Cc: Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , wang.bo116@zte.com.cn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Jan 2019 at 13:11, wangbo wrote: > > In sdio_bus_remove the variable is unneeded,remove it now. > > Signed-off-by: wangbo Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/core/sdio_bus.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c > index b6d8203..62b0f5e 100644 > --- a/drivers/mmc/core/sdio_bus.c > +++ b/drivers/mmc/core/sdio_bus.c > @@ -179,7 +179,6 @@ static int sdio_bus_remove(struct device *dev) > { > struct sdio_driver *drv = to_sdio_driver(dev->driver); > struct sdio_func *func = dev_to_sdio_func(dev); > - int ret = 0; > > /* Make sure card is powered before invoking ->remove() */ > if (func->card->host->caps & MMC_CAP_POWER_OFF_CARD) > @@ -205,7 +204,7 @@ static int sdio_bus_remove(struct device *dev) > > dev_pm_domain_detach(dev, false); > > - return ret; > + return 0; > } > > static const struct dev_pm_ops sdio_bus_pm_ops = { > -- > 2.7.4 > >