Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3711931imu; Mon, 14 Jan 2019 07:47:59 -0800 (PST) X-Google-Smtp-Source: ALg8bN4MkN9seFRAgMSNKDeYn29jRb/9bFax0e23XtOipIgetah/FVpYc3giQ27O2gu4gdwBunv0 X-Received: by 2002:a62:53c5:: with SMTP id h188mr25602945pfb.190.1547480879634; Mon, 14 Jan 2019 07:47:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547480879; cv=none; d=google.com; s=arc-20160816; b=SmOI7XVFKbATeOpyJ5FYWvTdQVt2yEZDJs9xS3FLzInSwgfqkZ5u4I4lhgJPv0TZje GiBMQFuvnpYV4SLpvSqwA3SM8EbFKWqPrrAXlEdfpgAmIWHmVp8962uLWTA988/ut/Oo PhBcljFPAVqTYuHZQfT1h1e2THMmSVMZjbPxyicDVxq0TEaBGraam2+UvubiyUpIUhBe KV9jgruPczrgSysuR8bZMlOiQNmlC4FtQ6bzAbA3P9I3cji1zhFUIAf/+aJu6vEMZoNF hNMVK3qOEHHFKqnaC3qy1CDGfp9lQ8V0VNfYjBm2RckYWK0Qn6vg9b9RbVX7jZDxU9NI PeFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=kiaQ2QabqQBjsVXUnVQX+7B/Z47M0O6A1TckQ7qMiEE=; b=QsniAc+O1dJOLftePunggtE1zyuD/aRMh7IRf7Z+hfClKGBvnxpN9dZxe93du/ZhRZ UYDXWkomJxciwl8KIM5s6W22S+rGM74kjHFvxbfVU5uYqztox9Qf2EmwMVdPamqWNUw2 Ia9gm3Yc6dniigJ981mTP8JJqOI3ecvm0Avlfbm8X7q6GBnm88yaoIQygQYinKpSwlDj c0K2EOits01J66RC4MVoHM4zUD72f0D9UuzlJpO5PWrO7j376Nke0jOufH+KgAxnxz8o B5tCTsUNr0V4JX7h0N1/+PVWUnjGjlMWdq98Gdy3s3773+d7pQZobTUrKOgKDahbUpU6 tl6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=VAnh9Vx9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si572260pgk.169.2019.01.14.07.47.44; Mon, 14 Jan 2019 07:47:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=VAnh9Vx9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfANPpq (ORCPT + 99 others); Mon, 14 Jan 2019 10:45:46 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:46794 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbfANPpp (ORCPT ); Mon, 14 Jan 2019 10:45:45 -0500 Received: by mail-qt1-f196.google.com with SMTP id y20so26934764qtm.13 for ; Mon, 14 Jan 2019 07:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kiaQ2QabqQBjsVXUnVQX+7B/Z47M0O6A1TckQ7qMiEE=; b=VAnh9Vx9ddzHtSCZiQdxTZlSaaQjZU03B2QGjeJlWGqMWOLJoIEkOxFTGoyMO0mFwC dq8wlpT9dnheEVCpdbIMDrNhrKawK529G6FcgCQxWYCqVeqzPa2xPFGXUXg8dmcLUUfX xoTbY66KR532jmIc4w0C0S654un1i6Q84yBfBbKbVv4/cj1JA1BuNzBfbcTwyuuhtWmL na3DpAfvY8c9RlwaEXzaYwrYIl4mZNJgeH9I9eY/6WJ6owEuUr2Nv95U9tBJ2CkuonZu oLNwXCU6yyh51txEEb17NZnF9x8MHnwH0EKg9pnSDWUSLGt3EIsMI2NtYqMDFopDmxHU 27mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kiaQ2QabqQBjsVXUnVQX+7B/Z47M0O6A1TckQ7qMiEE=; b=hOtIN8F/36+6Cd1Wm4cApmuTjW55jU327sIhdI/0gOj5SBEKFmYg6U1jGes3XKAqQE blCN4ujrpt+PnTgoRQwA2n0m3ED+5JEDzlOdjxlDvDZ9WKsgWi9qDR546OFICQ5GCLFV fsoYkMePV4QCSqEOMwkoLLVf5aLi73o+MSQPy/PRF5UoVxFA/hsMe5jq3+kk3HdKHvLR IKUhnX72erEowCcBYvue8gqXaqWhHUmkjKY0DFi5x+ZXXRGaEHzR9QkfeF4MZ8UYH9NN ZtoFsBDaNd/PCjSSlWKNJxSitER61p3EyIm0OLlLyFjkjFBcgGH6yHbsXkHzRGQofqAP jrsw== X-Gm-Message-State: AJcUukeY+OMz1P6Q/1I692VMrTXAts3/WGC1ZVQHcpkscS+iPIt35ZhS PuyWeQPypqmmI0+P4z6ww3uASSAezfqHnQ== X-Received: by 2002:ac8:5344:: with SMTP id d4mr24014029qto.372.1547480744014; Mon, 14 Jan 2019 07:45:44 -0800 (PST) Received: from ovpn-120-55.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id f143sm2513536qka.73.2019.01.14.07.45.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Jan 2019 07:45:43 -0800 (PST) Subject: Re: [PATCH v2] rbtree: fix the red root To: Esme , "dgilbert@interlog.com" Cc: David Lechner , Michel Lespinasse , Andrew Morton , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "joeypabalinas@gmail.com" , linux-mm , LKML References: <20190111181600.GJ6310@bombadil.infradead.org> <20190111205843.25761-1-cai@lca.pw> <864d6b85-3336-4040-7c95-7d9615873777@lechnology.com> <8v11ZOLyufY7NLAHDFApGwXOO_wGjVHtsbw1eiZ__YvI9EZCDe_4FNmlp0E-39lnzGQHhHAczQ6Q6lQPzVU2V6krtkblM8IFwIXPHZCuqGE=@protonmail.ch> From: Qian Cai Message-ID: <5298bfcc-0cbc-01e8-85b2-087a380fd3fe@lca.pw> Date: Mon, 14 Jan 2019 10:45:42 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/19 1:23 AM, Esme wrote: > I did not yet verify the previous branches but did tune out kmemleak (CONFIG_DEBUG_MEMLEAK no longer set) as it seemed a bit obtrusive in this matter, this is what I see now (note redzone?). > /Esme > > 114.826116] ============================================================================= > [ 114.828121] BUG kmalloc-64 (Tainted: G W ): Padding overwritten. 0x000000006913c65d-0x000000006e410492 > [ 114.830551] ----------------------------------------------------------------------------- > [ 114.830551] > [ 114.832755] INFO: Slab 0x0000000054f47c55 objects=19 used=19 fp=0x (null) flags=0x1fffc0000010200 > [ 114.835063] CPU: 0 PID: 6310 Comm: x Tainted: G B W 5.0.0-rc2 #15 > [ 114.836829] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.1-1ubuntu1 04/01/2014 > [ 114.838847] Call Trace: > [ 114.839497] dump_stack+0x1d8/0x2c6 > [ 114.840274] ? dump_stack_print_info.cold.1+0x20/0x20 > [ 114.841402] slab_err+0xab/0xcf > [ 114.842103] ? __asan_report_load1_noabort+0x14/0x20 > [ 114.843244] ? memchr_inv+0x2c1/0x330 > [ 114.844059] slab_pad_check.part.50.cold.87+0x27/0x81 Confused again. Those slab_pad_check() looks like only with SLUB, but you said you used SLAB. What else did you change?