From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Tim Hockin <thockin@sun.com>
Cc: Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
       akpm@osld.org.sun.com
Subject: Re: PATCH - NGROUPS 2.6.2rc2 + fixups 
In-reply-to: Your message of "Thu, 29 Jan 2004 11:41:31 -0800."
             <Pine.LNX.4.58.0401291138390.689@home.osdl.org> 
Date: Fri, 30 Jan 2004 13:09:28 +1100
Message-Id: <20040130021802.AA5BC2C0BF@lists.samba.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 961
Lines: 28

In message <Pine.LNX.4.58.0401291138390.689@home.osdl.org> you write:
> 
> 
> On Thu, 29 Jan 2004, Tim Hockin wrote:
> > 
> > What think?
> 
> I still don't understand the complexity.
> 
> Why the list of pages? Is there really any valid use for this that could 
> overflow a simple "kmalloc()"? How many groups do people really really 
> need? 

I was happy with kmalloc, and no sorting.  Simple patch.  Tim
complained that he had some wierd-ass users who hit kmalloc limits w/
fragmentation.  I added about 10 lines of code to fall back to vmalloc
for that very rare case, and you scotched that.

ie. Don't blame Tim: you led us here 8(

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/