Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3986632imu; Mon, 14 Jan 2019 12:42:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN7KpvjhWYGAsfY5bB/4UEpUe4in9naCo7zbZajfGwnetQFXH1w+/IgU7mVzA34TmPDEolja X-Received: by 2002:a63:f34b:: with SMTP id t11mr323699pgj.341.1547498554899; Mon, 14 Jan 2019 12:42:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547498554; cv=none; d=google.com; s=arc-20160816; b=B9d6y5yvp/B+qJZQNJ13EM945hPjDm+d2dUwgfpQVmoow71QQmbkcidO96Sh4VW6u3 wgyHB+YrDsGlpr85/9PiCcO3qmj6HGqHuNgTWdhj6zsgLyJzwRa+7pgoFkmNvSqZqTmj 5WywJv3BeGMjPlYfyy7pxM3x0hBU6nrh4csgNDK+Q5aD1uMtAAsV12lJHLBV0dwGNz5Z iDYhD4tPLlAmwidLSI8SDvPpTgthOAsQf3ToitM2OCMU4iEb7XLfXvj7GA6gCwniOBb4 26761QxToEPKTW+P1X48ukjF3IdUoWCm3+B4UvEAe9kRfnayWoLVW3g7zz0dd8jsivSv H0rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yiTzvOsBbU68HbKrMMBK2Tr5Tf5KHxDi+fruJqdMvPQ=; b=C4Y/U2pkNCkk1WEUpSMV+4+n5M4E+C9ANcjkxUxxQGtRnXbLc+Z8gMqapxpcFJnt0I bpZs1ToRS/Zgg6pfqlngM245BXXc3KpSEh0Wg/QXiIXWXECBFzNmlT4q5PxZVxm1Oafj mSBx1e+bzLlsaV6Gk0oRQ/x/PqF+Lfuu/T27tjp29+xow9mWQ0hEe5/PzTCwyoDZvbS6 Edof5sZyxMuKO1DNlqIP48LsDOf6Jjl+QBpsXfP5LEMNnwBgY3xmaBQ3F3zHL84kFsdA 4DezD3mYwxCtN8wjKE28fFlITFfarZYLDoGPGuyl5k7xEh8hMZk+jbsorJYCW1q05PZK WLgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Cx6/bCSP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n34si1195289pld.381.2019.01.14.12.42.19; Mon, 14 Jan 2019 12:42:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Cx6/bCSP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727058AbfANUkv (ORCPT + 99 others); Mon, 14 Jan 2019 15:40:51 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43085 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbfANUkv (ORCPT ); Mon, 14 Jan 2019 15:40:51 -0500 Received: by mail-wr1-f67.google.com with SMTP id r10so424476wrs.10; Mon, 14 Jan 2019 12:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yiTzvOsBbU68HbKrMMBK2Tr5Tf5KHxDi+fruJqdMvPQ=; b=Cx6/bCSPuhYVbWZESsxZV8kFEinXq7if+votofKKWwX4b1qDQP1TpUResFvKXXLPJh Vr4HeOEI2gwxvcG7EsNn/OIRjiH4d4goIsdeQd2YKcJiqwlDfhtbBZIlFpeSmQw6+d3U xn3Cba6RNo0D5Ko4DzwL4kDlHvLwLrZQmH+W9yjgL3zSZnK7tkyygljy4JZR3nv4QHuI PV3RtydyNNoMsTIOpMoLOsCxaGUscXNz5wIbf9GXnPiWrJUfzwP90JZqB1mZxqwINmra 0HSwuA9nNgEECiiCQx72SL4y4V1fpcvkdI7OjRU4hvt0DDIVR6OPnHCyJP3LS9jueYDm K/Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=yiTzvOsBbU68HbKrMMBK2Tr5Tf5KHxDi+fruJqdMvPQ=; b=ghz7RoBYfMPrttMSKHCFrsErqLpfL4EXygLBu/qPdyuBFuNDyq28A2xpM0VefUcxnA i2n/uQJg0VaSBc+FqLdiDyqn5opUel3H/pVDJufgRWUKCKohvzrdtrCSRph8FiFVxEso 4FTCzZbKfN0h8Jc3TBwqLIpUQ5C3MSAjFH1VpTTHyMlyp+1XMETVEc43ZftJ2lZ07chM 1uIHLgsIVHdHfKLmquzKYhUDjI0vZ14sFEvgDNOBEP/Wbqz33nHC3rvxPjvC6qv8BZSZ htJWotghJFn4HjNm4uNgYjzQtrRB4jZJmI6ph3b9/oiIjLKfhX8TJzM2M0tKYKXK7XWm Aemg== X-Gm-Message-State: AJcUukc6lkeomShmeWurIrEKP/ZhTFKhYix0/xzOH1tam8JwrjusXxMC /We1UzWiamgAGUNa3HW4VvA= X-Received: by 2002:adf:f8cf:: with SMTP id f15mr202335wrq.265.1547498449523; Mon, 14 Jan 2019 12:40:49 -0800 (PST) Received: from macbookpro.malat.net ([2a01:e34:ee1e:860:6f23:82e6:aa2d:bbd1]) by smtp.gmail.com with ESMTPSA id c202sm37000661wmd.40.2019.01.14.12.40.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 12:40:48 -0800 (PST) Received: by macbookpro.malat.net (Postfix, from userid 1000) id CBAEB11422AD; Mon, 14 Jan 2019 21:40:47 +0100 (CET) From: Mathieu Malaterre To: Bartlomiej Zolnierkiewicz Cc: Mathieu Malaterre , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: offb: annotate implicit fall throughs Date: Mon, 14 Jan 2019 21:40:44 +0100 Message-Id: <20190114204044.20528-1-malat@debian.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a plan to build the kernel with -Wimplicit-fallthrough and these places in the code produced warnings (W=1). Fix them up. This commit remove the following warnings: drivers/video/fbdev/offb.c:211:5: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/offb.c:142:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre --- drivers/video/fbdev/offb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c index 31f769d67195..e0f0c5351306 100644 --- a/drivers/video/fbdev/offb.c +++ b/drivers/video/fbdev/offb.c @@ -141,6 +141,7 @@ static int offb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, /* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */ out_le32(par->cmap_adr + 0x58, in_le32(par->cmap_adr + 0x58) & ~0x20); + /* fall through */ case cmap_r128: /* Set palette index & data */ out_8(par->cmap_adr + 0xb0, regno); @@ -210,6 +211,7 @@ static int offb_blank(int blank, struct fb_info *info) /* Clear PALETTE_ACCESS_CNTL in DAC_CNTL */ out_le32(par->cmap_adr + 0x58, in_le32(par->cmap_adr + 0x58) & ~0x20); + /* fall through */ case cmap_r128: /* Set palette index & data */ out_8(par->cmap_adr + 0xb0, i); -- 2.19.2