Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] lib/siphash.c:: annotate implicit fall throughs
To:     Mathieu Malaterre <malat@debian.org>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-kernel@vger.kernel.org
References: <20190114201911.13725-1-malat@debian.org>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Message-ID: <481e4a45-29fb-7546-74c7-f23f61f9dc4c@embeddedor.com>
Date:   Mon, 14 Jan 2019 15:04:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190114201911.13725-1-malat@debian.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/14/19 2:19 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings (W=1). Fix them up.
> 
> This commit remove the following warnings:
> 
>    lib/siphash.c:71:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/siphash.c:72:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/siphash.c:73:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/siphash.c:75:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/siphash.c:434:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@debian.org>


Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>


> ---
>   lib/siphash.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/lib/siphash.c b/lib/siphash.c
> index 3ae58b4edad6..b95624f5aa34 100644
> --- a/lib/siphash.c
> +++ b/lib/siphash.c
> @@ -69,10 +69,14 @@ u64 __siphash_aligned(const void *data, size_t len, const siphash_key_t *key)
>   #else
>   	switch (left) {
>   	case 7: b |= ((u64)end[6]) << 48;
> +		/* fall through */
>   	case 6: b |= ((u64)end[5]) << 40;
> +		/* fall through */
>   	case 5: b |= ((u64)end[4]) << 32;
> +		/* fall through */
>   	case 4: b |= le32_to_cpup(data); break;
>   	case 3: b |= ((u64)end[2]) << 16;
> +		/* fall through */
>   	case 2: b |= le16_to_cpup(data); break;
>   	case 1: b |= end[0];
>   	}
> @@ -432,6 +436,7 @@ u32 __hsiphash_aligned(const void *data, size_t len, const hsiphash_key_t *key)
>   	}
>   	switch (left) {
>   	case 3: b |= ((u32)end[2]) << 16;
> +		/* fall through */
>   	case 2: b |= le16_to_cpup(data); break;
>   	case 1: b |= end[0];
>   	}
>