Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] lib/assoc_array: annotate implicit fall through
To:     Mathieu Malaterre <malat@debian.org>,
        David Howells <dhowells@redhat.com>
Cc:     linux-kernel@vger.kernel.org
References: <20190114202454.14551-1-malat@debian.org>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Message-ID: <475381f8-3fdf-5b5e-da34-23d57ae757e7@embeddedor.com>
Date:   Mon, 14 Jan 2019 15:08:46 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190114202454.14551-1-malat@debian.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/14/19 2:24 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
> 
> This commit remove the following warning:
> 
>    lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

> ---
>   lib/assoc_array.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/assoc_array.c b/lib/assoc_array.c
> index c6659cb37033..0b61d3b77e5c 100644
> --- a/lib/assoc_array.c
> +++ b/lib/assoc_array.c
> @@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array,
>   						index_key))
>   				goto found_leaf;
>   		}
> +		/* fall through */
>   	case assoc_array_walk_tree_empty:
>   	case assoc_array_walk_found_wrong_shortcut:
>   	default:
>