Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] capabilities:: annotate implicit fall through
To:     Mathieu Malaterre <malat@debian.org>,
        Serge Hallyn <serge@hallyn.com>
Cc:     linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190114202835.15878-1-malat@debian.org>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Message-ID: <7cba59f5-d59a-f8fe-9717-0ecbab47eeaf@embeddedor.com>
Date:   Mon, 14 Jan 2019 15:15:30 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190114202835.15878-1-malat@debian.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/14/19 2:28 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
> 
> In this particular case change put the fall through comment on a single
> line so as to match the regular expression expected by GCC.
> 
> This commit remove the following warning:
> 
>    kernel/capability.c:95:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks

> ---
>   kernel/capability.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 1e1c0236f55b..e60be18b98e2 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -93,9 +93,7 @@ static int cap_validate_magic(cap_user_header_t header, unsigned *tocopy)
>   		break;
>   	case _LINUX_CAPABILITY_VERSION_2:
>   		warn_deprecated_v2();
> -		/*
> -		 * fall through - v3 is otherwise equivalent to v2.
> -		 */
> +		/* fall through - v3 is otherwise equivalent to v2. */
>   	case _LINUX_CAPABILITY_VERSION_3:
>   		*tocopy = _LINUX_CAPABILITY_U32S_3;
>   		break;
>