Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4098040imu; Mon, 14 Jan 2019 15:04:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN6aMNkCuKS7iAmEFh0z4vVzbZOOJHD7rtizX0t/CwikpA2yf6tDmc0WfCbiSkcJNioCIG2o X-Received: by 2002:a63:ca02:: with SMTP id n2mr835048pgi.187.1547507081178; Mon, 14 Jan 2019 15:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547507081; cv=none; d=google.com; s=arc-20160816; b=dS/Ueh7TP4+JckxkaQPIYZJ/v0fks7hBHBlBdb6px3E6Nhj6a6tBO4MxqeEgfDQWpi cF0QvoOrGQxYC9A+evcjAfULFSV4sDSqqn8EcEhnFxj4Da0ujzDVB6A4BRvtTWx6QMX0 2SM4hJ1dBFV//zySOmgiseSxs134O+tVsO4k0ktij7BKwNsF6QKd+FldWBPcBPIKP4pK QVOI1pansP0Xsg/Sy1n9H6lkRm04NE0042pCMLSYHdM2hjhZtLwsviyc5I2mTceX87Ep sVSlwwsj2mbsuDL/IedkgK7kk6wfeRLxUpnK7fofhqbKh6CP9h8C/4nfBRpU1N0HEWK5 Ky9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=97yCdOyQkOXGj1xB/dQfBWI/KOJ74qUNGiydIqZJiQU=; b=lgGY60z0N1zBoOyDSXMVcIhtTeGqR8l92MB0WxMz8kbW5zvmbp56r9Oqxe4tS48jgF S3+YXZ937YuJy9ktkfI7RbfS+qhkyD7OTKllLC0MxNTgLbgUxOhmtfnXbKBdNaiZzgux 9GQhKcRGQfkNaatHWLc38VFj3YjOxc+/+dHZ0fllVMZlXkJgevehZMyNTygMUAZ6UDaX SxEf4AhHQ+edOjXtUY4Rxhh0ZfgKkjdhoR+NB5bckKfcsmIHauHKKVQppwHpRBha13DQ hakQ8rwId5yBHHg6cQTB5BRnmzdEvo3jl2NUnkeKqFR3GHLTfs/vxAAhc8NB76uazSwy 7ZHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si1406090plk.275.2019.01.14.15.04.25; Mon, 14 Jan 2019 15:04:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbfANXDT (ORCPT + 99 others); Mon, 14 Jan 2019 18:03:19 -0500 Received: from mga18.intel.com ([134.134.136.126]:27788 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726747AbfANXDR (ORCPT ); Mon, 14 Jan 2019 18:03:17 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 15:03:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,479,1539673200"; d="scan'208";a="291543069" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.143]) ([10.7.153.143]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2019 15:03:15 -0800 Subject: Re: [PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver To: Joel Stanley Cc: Lee Jones , Rob Herring , Jean Delvare , Guenter Roeck , Mark Rutland , Andrew Jeffery , Jonathan Corbet , Greg Kroah-Hartman , Gustavo Pimentel , Kishon Vijay Abraham I , Lorenzo Pieralisi , "Darrick J . Wong" , Eric Sandeen , Arnd Bergmann , Wu Hao , Tomohiro Kusumi , "Bryant G . Ly" , Frederic Barrat , "David S . Miller" , Mauro Carvalho Chehab , Andrew Morton , Randy Dunlap , Philippe Ombredanne , Vinod Koul , Stephen Boyd , David Kershner , Uwe Kleine-Konig , Sagar Dharia , Johan Hovold , Thomas Gleixner , Juergen Gross , Cyrille Pitchen , linux-hwmon@vger.kernel.org, devicetree , Linux Kernel Mailing List , linux-doc@vger.kernel.org, OpenBMC Maillist , James Feist , Jason M Biils , Vernon Mauery References: <20190107214136.5256-1-jae.hyun.yoo@linux.intel.com> <20190107214136.5256-9-jae.hyun.yoo@linux.intel.com> From: Jae Hyun Yoo Message-ID: <7f63d8f1-2af6-e386-d5b2-c78e3881d789@linux.intel.com> Date: Mon, 14 Jan 2019 15:03:15 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/2019 3:42 AM, Joel Stanley wrote: > On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: >> >> This commit adds PECI client driver. > > It looks like it's a PECI driver for the three CPU families, and it > implements cpu and dimm temp, with sideband functions deferred to the > future. If you add that information with a few more words it would > make for a nicer commit message. > Yes, that would be nicer. I'll add the description into the commit message. Thanks for your review! Regards, Jae >> Signed-off-by: Jae Hyun Yoo > > Reviewed-by: Joel Stanley >