Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4507212imu; Tue, 15 Jan 2019 00:57:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN6tXObiOeAv1qoVfgE6IuiLtmkOgJmdRkfdDqDXZ2m4JRvwMih8Gc0N/EpThv2/HMe6/R6j X-Received: by 2002:a17:902:be0e:: with SMTP id r14mr2852565pls.124.1547542634649; Tue, 15 Jan 2019 00:57:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547542634; cv=none; d=google.com; s=arc-20160816; b=UCBYxMveRR0RM27VQztZgBzcHrxYiwJqqLk2+qlxGdp4cO8FPcAsaZmIKcpBXov+sW nPoBgU5iuNyDmghaupiXJE5+zac4EH3QEvCOSki18hS5sBbCpvTTcFrmHNedP64LfSDc ItBKzUjycSUp3552qdyZWPoqoskao5CQ3pKMRfGI2rmZbHTi4wlqAMBwG4PUrnCYbNG4 BWJ316DQtHB3leGXpMuyLMJVz6RDzNw+mmFZyuJb1r4iXIlyY1iGuHaGhuDowFK5Is2g /rURXtbeBX0DXvlTloicpnW6udSka1IKVSTmzKexCOmveRsncXN+wL+2ezJURaq/FzOW p+3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=AEvLBlZn/8mftg4VajuyVnyyVBSF5IJc0mJx1Fn5t0c=; b=JH49QCw8sApZdALq4EKQW173OoC0ID8jb6ZrqpD3aG/hMhv7Z7wiEr5CJrgbuvjtpO 5sBF01yej0tmZLDA4pci4bA55uTb1oj+iGAw+hFzIZ/E79I/QYFtmyu+4VxYjQpd0RDY X39mBCxaDyltkIb6al3FVhj+LoAiA8cgrFdrHikFeitIKtQX+5DMxxi6wEXPOpWEIp6z Vcx4ViFTbNgjoSxx1MZSAGk3UubIRQAL1cIhiTl4baSEjw2v1dNkKHKjnWvRU9C7APq4 wlYtG4IE6a53fFeMrcTJywXd5GR3awrE48UAdLCafGoYIjiRJtbC1upu4ILNhoc9MA2t Fl3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PWGTla8x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d142si2792530pfd.93.2019.01.15.00.56.59; Tue, 15 Jan 2019 00:57:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PWGTla8x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbfAOHxm (ORCPT + 99 others); Tue, 15 Jan 2019 02:53:42 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:32999 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728174AbfAOHxm (ORCPT ); Tue, 15 Jan 2019 02:53:42 -0500 Received: by mail-pl1-f196.google.com with SMTP id z23so920469plo.0 for ; Mon, 14 Jan 2019 23:53:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=AEvLBlZn/8mftg4VajuyVnyyVBSF5IJc0mJx1Fn5t0c=; b=PWGTla8xPXHZJhFLEVc9niJ+2Y0vhunlWfEtSRRf0qSvZsrk4vGOPKU8et9lXEm1LK vJFGBEiho6XLF6aBtpR8XyRge9bNVDVbgzWimmGMJpgxnux8wngnmuDXqcLuDqaXywRt Ny4WtHmxE4ET3qp3wtpSFInOLiAhM8uXDQ1O0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=AEvLBlZn/8mftg4VajuyVnyyVBSF5IJc0mJx1Fn5t0c=; b=sYUja/Su0VM4L57lYTUq6nNavccKFs+a16+8nIkbj8m5TbUnNuIUDrcOdtg07Ts3kw vfYd5DosImOGrItAyXTZQ0sdO/LUC5USd1kj68nhkf/zlMpoaRdh1ZHuL9WCzKW9+MEF RE8ImQ407ewtD9Rdj6cp0CEkdrue+IBDbqbDRjG9xGsUymvpIr5J8FH7Ajir6BhjyY7x s/Q5zors+h/iKi40chMLoVbMkxtYpfeGdp31csb3INdvjAojIEcCGjqNkp5ShrGb2BJu VAmmlVC+NECcz+29oOLhirrUdKqIPqpsqGkzw8KZncw+aOOpBgcGrrKqtKDgj5k9BL7j Ez7g== X-Gm-Message-State: AJcUukdcKfijaGeO65vLJtqbPUzkZN95Jc04q+E/W+dWCzg8+bACOQbx 10WiCV8EBHzPezdM6B+3hgRhJw== X-Received: by 2002:a17:902:2006:: with SMTP id n6mr2812113pla.66.1547538821635; Mon, 14 Jan 2019 23:53:41 -0800 (PST) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id g3sm4340093pfe.37.2019.01.14.23.53.38 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 23:53:40 -0800 (PST) From: Baolin Wang To: linus.walleij@linaro.org, bgolaszewski@baylibre.com, orsonzhai@gmail.com, zhang.lyra@gmail.com Cc: baolin.wang@linaro.org, neo.hou@unisoc.com, broonie@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] gpio: sprd: Fix incorrect irq type setting for the async EIC Date: Tue, 15 Jan 2019 15:52:59 +0800 Message-Id: <3dd0a29b2f42d41ddfa5b30b68926eb58ebfc3a9.1547538574.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <732ea4f8ff1bf3ad28bda543ae8e1727c78f8b3b.1547538574.git.baolin.wang@linaro.org> References: <732ea4f8ff1bf3ad28bda543ae8e1727c78f8b3b.1547538574.git.baolin.wang@linaro.org> In-Reply-To: <732ea4f8ff1bf3ad28bda543ae8e1727c78f8b3b.1547538574.git.baolin.wang@linaro.org> References: <732ea4f8ff1bf3ad28bda543ae8e1727c78f8b3b.1547538574.git.baolin.wang@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Neo Hou When setting async EIC as IRQ_TYPE_EDGE_BOTH type, we missed to set the SPRD_EIC_ASYNC_INTMODE register to 0, which means detecting edge signals. Thus this patch fixes the issue. Signed-off-by: Neo Hou Signed-off-by: Baolin Wang --- drivers/gpio/gpio-eic-sprd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c index 257df59..e41223c 100644 --- a/drivers/gpio/gpio-eic-sprd.c +++ b/drivers/gpio/gpio-eic-sprd.c @@ -379,6 +379,7 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type) irq_set_handler_locked(data, handle_edge_irq); break; case IRQ_TYPE_EDGE_BOTH: + sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0); sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1); irq_set_handler_locked(data, handle_edge_irq); break; -- 1.7.9.5